Comments (17)
It seems rather pointless to distinguish between the two, maintainer is clearly a special role, but developer and contributor are the same in my mind.
from maven-tools.
Agreed.
from maven-tools.
So we have agreed to stop using "contributor", we should new issues against repos to move them to be listed as "developers".
Where should be publish the guidance on this?
from maven-tools.
In the "how to write/maintain a component" doc. Which should link from https://trac.lal.in2p3.fr/Quattor/wiki/Development/Code but I can't currently see it. :(
from maven-tools.
@ned21: it works for me! What's your problem?
from maven-tools.
Back on the original topic, I'd a look at what is expected by the quattor-build-maven plugin and I am not sure this is a good idea to deprecate contributors without changing the plugin: contributors are used if they have the role 'author' to build the author list (that is added at the top of almost all files). Other contributors are ignored. On the other hand, developers are used to build the "current developers" list.
I'd suggest cleaning up the plugin before pushing any change in the pom files. I see several alternatives:
- Remove contributors, add the role to developers (if supported by maven) and fix the plugin to look at authors in this place.
- remove developers, fix the plugin to use contributors without author role as current developers, authors being listed only as authors even if they are active developers.
- Fix the plugin to add developers and contributors without the author role to the current developers list.
- Enhance the plugin to produce a 3d cateogory, "past developers" that will be the contributors without the author role and add a
${past_developers}
to files.
My preference is probably the last choice with a variant that would be to support author role both for developers and contributors (if allowed by Maven) and add all developers (authors or not) to the "current developers" list and all contributors to the "past developers" list.
from maven-tools.
@jouvin - oh, it's labelled "CodingStyle". I think I was looking/scanning for a different name.
I dislike "past_developers" - it suggests someone has to decide whether they are being active and then get moved somewhere else when they are no longer active. I think we want to model two distinct concepts:
- Everyone who has ever contributed to this code base. That might include non-code patches like documentation but I am fine with those people being labelled "developer" or "contributor" or "author".
- The person or organisation who are currently actively maintaining this code. Almost certainly a subset of (1) since the mere act of updating the pom file with your name makes you a contributor/developer/author.
I haven't looked at the maven plugin to see what it currently supports but in general, the simpler the better I think.
from maven-tools.
I've had a look: there is no problem to define the author role attached to developers too.
I'm fine with your proposal: keep things simple. After thinking again, I'd suggest what is in fact the easiest in terms of editing required: change only the plugin, keep the source files as they are. The changes that I suggest are:
- Treat
developers
andcontributors
interchangeably: just merge their contents. Both for developers and authors. - Replace the text "Current developers" that is put in the large files by "Contributors" and add everybody, including authors.
- In authors, keep the limited list of people that wrote the first version or did a major architecture evolution (as an example, I don't consider myself as a
ncm-cdispd
author despite the total rewrite I did as I didn't change the architecture). For the record, "Authors" is just a list of name, without emails. If you don't want to see "Authors" appearing in a module, it is enough to remove all author roles (we may have to check that the plugin doesn't insert an empty "Author:" line but this should be easy to fix).
from maven-tools.
Sounds good to me.
from maven-tools.
Bumping to 14.10, this won't get fixed this week.
from maven-tools.
Bumped to 14.12 at workshop.
from maven-tools.
So this is clarified, now it just needs to be implemented.
from maven-tools.
I thought I'll be able to work on it for this release but this will have to be the next one...
from maven-tools.
No worries, it's not really urgent, just untidy
from maven-tools.
I'm afraid that this will be again for next release... Would be good to do it but really low priority for me...
from maven-tools.
@jouvin does the milestone mean that this is now implemented?
from maven-tools.
Sorry, I probably did something wrong setting the milestone... No intent to work on this in the short term...
from maven-tools.
Related Issues (20)
- build-scripts requires a Perl-Critic version not available on SL6 HOT 8
- mavenprove fails to test CAF
- tracing guideline
- tests try to generate tabcompletion
- Mocked CAF::FileWriter attempts to create directories HOT 10
- /Test/Quattor/Panc.pm: annotation regexp is incorrect HOT 1
- Test::Quattor: mock the new symlink-related methods
- random pan annotation failures HOT 5
- use diagnostics HOT 3
- Update cfg-module used to create a new component skeleton
- _make_link: allow keeps_state HOT 1
- Build fails while trying to generate docs using Java 1.8 HOT 8
- Reinstate `warn_is_ok = 0` / remove `set_caf_file_close_diff`
- Allow testing of immutable files
- Test::Quattor: review status usage
- make a maven template for scripts
- Mock NCM::Component::prefix() correctly HOT 1
- investigate missed missing import
- javadoc doclint issues HOT 1
- junit / xunit issue HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maven-tools.