quentinms/gmr-client

A Giant Multiplayer Robot Client for macOS and Linux*

gmr-client's Issues

Invalid date remaining (games with no timer)

Probably caused by my install using [email protected]

From version 2.10.3, if the target moment object is invalid the result is the localized Invalid date string. (momentjs docs)

An easy fix would be restricting the version of moment on package.js. If you see that as a problem the logic here could be changed as well.

edit: clarifying the source of the quote

Set up CI

Super basic CI that package the app on each release and/or merge into master.
Plenty of options: https://github.com/integrations/feature/continuous-integration

Save upload fails

It seems that the program attempts to upload a directory. I worked around it by replacing this line with the one below:

return fs.createReadStream(this.saveFile+'(GMR) Play this one!.Civ5Save')

The upload completed after this but I believe that this is not a good solution.

Validate JSON response from GMR's API

It looks like sometimes the API will not answer will all required field, creating undefined, and causing the UI to show nothing.

• We should validate the received JSON, so we don't try to work with invalid data
• Retry the query if the response is invalid
• Notify the user if we couldn't fetch the data (e.g after retrying multiple times)

This might be relevant: http://jsonschema.net

Error with no clear path to resolve

Pretty sure I did everything correctly, its a nice basic little app.

Error message is:

Invalid date remaining

on the game screen. It pulls the list of games successfully but I cannot upload/download.

Platform is OSX 10.11
Thanks!

Write tests

There is currently no test at all 😿

https://mochajs.org
https://docs.angularjs.org/guide/unit-testing
https://github.com/electron/spectron
https://github.com/jprichardson/electron-mocha