qufighter/colorpick

Provides Color Picking Eye Dropper for Google Chrome, Firefox

colorpick's Issues

Possible to screenshot the wrong tab

Steps to reproduce:

1. start ColorPick on one tab, (optionally: leave it in the mode where no color is yet selected). Leave the tab.
2. resize the browser window... this will cause color pick to try to take a new snapshot.
3. revisit the original ColorPick tab very quickly ( leave and immediately view a different tab )
4. when you return to the ColorPick tab it will appear to have become the other tab you visited when in reality the screenshot is out of date.

This is caused by the nature of https://developer.chrome.com/extensions/tabs#method-captureVisibleTab where for a given window ID the visible tab might change at any time, making it difficult to know if the screenshot we got matches.

Possible solutions include:

1. prior to and after capturing make sure the active tab didn't change.
2. monitor all tab change events, and discard screenshots if tab any active changes had occurred

To avoid this issue, exit color picker before you change tabs.

Also, since it is possible to reproduce this issue when not "leave it in the mode where no color is yet selected" - we can probably avoid new snapshots in this mode, but it will not solve the issue completely.

There is an argument to be made that the API should provide a safer way to guarantee we are getting a snapshot of the tab we desire based on tabID.

Add license

Would you mind adding a license?