quickns/azure-data-share-automation

Sample code on how to automate Azure Data Share

azure-data-share-automation's Issues

Data share sample review (excluding Azure function)

After going through the setup process (excluding the Azure Function), here is some feedback you might want to consider:

1. Add the following instruction after az login, to set the account to point to the right subscription: az account set -s <SUBSCRIPTION_ID>
2. Could we use also env variables for the subscription id and object id, instead of adding them directly to the py file?
3. Customize with an env variable or instruct to replace xyz on the suffixes, because it complains that a DataShare already exists with that name.
4. Add clarity on the name of the .env file that each script is expecting: source.env for the source script and dest.env to the destination script.
5. On the following sentence in the destination instructions: "After the invitation is accepted, the script can't be run again. If you need to re-run it, please create a new invitation using the dest.py python script." I think is source.py instead of dest.py.
6. azure-mgmt-datashare was missing from requirements.txt
7. I think also the Role Assignments could be automated for the Data Share account and Storage account

Other than that, the sample worked perfectly e2e. Will review the Azure function now and add another issue if necessary!

Data share sample review (Azure function)

1. When running the function with the service principal, it seems to point to the wrong destination share: "System.Private.CoreLib: Exception while executing function: Functions.AcceptDataShareInvitations. System.Private.CoreLib: Result: Failure
   Exception: HttpResponseError: (1002) properties.storageAccountName:dest-data-shareys is not a valid name.". and it creates the shared subscription in the same Source Data Share instead of in the destination Data Share. I can reproduce this if you want to see it.
2. As the code seems to run with the logged in azure identity (my user in this case), I've created manually a data share with my user and trigger the function again. I receive an email, but seems that the invitation is sent to another tenant and subscription. But all the settings, the azure login and account set are pointing to the right subscription configuration. I can reproduce it as well.

Let me know if you recognize something off on the code or if you want to have a session so I can reproduce the behaviour. Thanks!

Adding a .devcontainer

I would recommend adding a dev container that builds the pre-requisites in advance, so testing is smoother for any person no matter what their local configurations and settings are.