quickswap/quickswap-core

quickswap-core's Issues

403 when loading Wallet Connect icon (CORS issue)

The QuickSwap icon for WalletConnect can't be loaded on a different origin. The problem is demonstrated here: https://codepen.io/signorbusi/pen/rNdqPmq

The URL of the icon in question is https://quickswap.exchange/logo_circle.png

The reason is that there is a strict-origin-when-cross-origin policy on the icon. It would be great if the icon could be excluded from that policy, otherwise it's not possible to render the QuickSwap icon in web apps.

How can I find the Pair init code hash

Hello guys, I want to know what's the Pair init code hash of QuickSwap.

testnet?

Hi,
Is there a testnet for Quickswap? If so, what is the url and the router address?
Thanks!

i did not receive my whole amount of USDC on removing liquidity

https://polygonscan.com/tx/0xf97efed5bc34e6aec6ab545e6cecb195b77396e8a3b2313b0eae856809b68527

https://polygonscan.com/tx/0x1cee85458436a7bbedb33d89326cbc93ca263b78e323c0649e6ee6014acf30d4

I add liquidity to USDC to SAND and tried to remove the liquidity and this happen.

Polygon ZkEVM Chain

When I try do any task on the Polygon ZkEVM Chain, all the assets are unavailable and just stuck in the infinite loading. Cant perform any transaction. Is there an issue with Polygon ZkEVM Chain or with your platform?

Not able to find latest subgraph to build a website showing latest graph of Quickswap tokens

We in middle of building a solution of quickswap tokens so that users can see latest graph and other information easily.
But I am enable to figure out which subgraph is used by quickswap for latest data.

Get Token spot price

Hi @sameepsi ,

thanks for the great work done on quickswap.

I was going through the docs at https://docs.uniswap.org/protocol/V2/reference/smart-contracts.
since these contracts are used by https://quickswap.exchange/

I am looking for a better solution where I can get a spot price for a pair.
I came across this https://docs.uniswap.org/protocol/V2/reference/smart-contracts/pair#swap

Event will be triggered as soon as swap will happen at uniswap.

Our code will continuously listen for events on that pair and as swap happens we will calculate the spot price.

As there any better approach for the given problem?
TIA

Amoy testnet

Hi there!

Do you plan to deploy the contract on Amoy ?

thank you!

Negative fee?

I added USDC and Mai coin liquidity to the pool.
I am looking at my account. And it says that I have earned negative fee on(Of around 2% on my liquidity).
How could be this possible?

Small balance farm shows for a second then dissapears on Brave browser

When accessing the exchange from brave browser on a mac, farms are listed, but when connecting with metamask and having staked on one farm, when expecting to see the farms with deposits, the site would show the farm for half a second then the listing would dissapear.

Where can I find the contract address of the StakingRewards contract for a particular pool?

tests are broken

Hi

trying to run the project
and the tests are broken...

yarn

yarn compile

yarn test

Approve button not functioning

Hello, I cannot approve a coin, when depositing or withdrawing from a farm or liquidity pool. Clicking the button simply does nothing.
I noticed it about 2 or 3 weeks ago.

I googled a bit and it seems to be bug number 1034 and 1172 in Uniswap, since quickswap is a clone maybe you caught the same bug. Is there a fix or workaround?

Error calling getAmountsOut when liquidity is added on WMATIC

Hi, i've been trying the functions from the router using the web3.py library. However am getting into troubles when calling the function with a WMATIC/Token liquidity pair and using USDC as currency to buy the token. The problem doesn't arise when the liquidity is added directly as a USDC/Token pair, using the exact same functions.

I've defined the qs_contract and the usdc contract as follows:

# public sender address
sender_address = ""

# This is the router plus abi definition
qs_router = "0xa5E0829CaCEd8fFDD4De3c43696c57F7D7A678ff"
with open("qs_router_abi.json") as qsJsonAbi:
    qs_abi = json.load(qsJsonAbi)
    qsJsonAbi.close()

qs_contract = w3.eth.contract(address=qs_router, abi=qs_abi)

# This is the USDC contract definition
usdc_contract_id = w3.toChecksumAddress("0x2791bca1f2de4661ed88a30c99a7a9449aa84174")

# Here goes the token created
token_to_buy = ""

# lets say budget to spend is $1
budget = 1000000
estimated_amounts = qs_contract.functions.getAmountsOut(
        budget, [usdc_contract_id, tokenToBuy]
    ).call({"from": sender_address})

As mentioned early, this functions goes well on USDC/Token pairs, but fails with WMATIC/Token pairs with the following error:

File "/home/basti/.local/lib/python3.8/site-packages/web3/contract.py", line 957, in call
    return call_contract_function(
  File "/home/basti/.local/lib/python3.8/site-packages/web3/contract.py", line 1501, in call_contract_function
    return_data = web3.eth.call(
  File "/home/basti/.local/lib/python3.8/site-packages/web3/module.py", line 57, in caller
    result = w3.manager.request_blocking(method_str,
  File "/home/basti/.local/lib/python3.8/site-packages/web3/manager.py", line 181, in request_blocking
    return self.formatted_response(response,
  File "/home/basti/.local/lib/python3.8/site-packages/web3/manager.py", line 161, in formatted_response
    apply_error_formatters(error_formatters, response)
  File "/home/basti/.local/lib/python3.8/site-packages/web3/manager.py", line 61, in apply_error_formatters
    formatted_resp = pipe(response, error_formatters)
  File "cytoolz/functoolz.pyx", line 667, in cytoolz.functoolz.pipe
  File "cytoolz/functoolz.pyx", line 642, in cytoolz.functoolz.c_pipe
  File "/home/basti/.local/lib/python3.8/site-packages/web3/_utils/method_formatters.py", line 554, in raise_solidity_error_on_revert
    raise ContractLogicError('execution reverted')
web3.exceptions.ContractLogicError: execution reverted

Can I participate in writing code ?

I am new to polygon and I want to participate in writing code. I am new to this and I want to gain some experience of polygon with hands on exp. Can I participate ?

Not able to switch to matic

Hi, while following this tutorial on how to swtich to MATIC I found the following error on my console:

inpage.js:1 MetaMask - RPC Error: The method 'wallet_addEthereumChain' does not exist / is not available. {code: -32601, message: "The method 'wallet_addEthereumChain' does not exist / is not available.", data: {

I just logged with my wallet and clicked Switch to Matic

browser: Brave Version 1.22.71 Chromium: 89.0.4389.114 (Official Build) (64-bit)
os: Windows 10

Any questions I'm here, I like the project