quytelda/focs

Functional Open C Structures - C Data Structures Library

focs's Issues

'__addr_to_index()' can produce out of range values (< 0).

The '__addr_to_index()' function should only return positive values, per it's return type (size_t), but it can return values that are negative. This can result in out-of-range indices being used in the program.

Ring Buffer: 'rb_push_head/tail()' don't update the buffer size.

After calling 'rb_push_head/tail()', the length of the ring buffer is still zero no matter how many values have been pushed to it. The length of the buffer should equal one after 'rb_push_head/tail()' is called on an empty list, or one greater than the length before the call.

The Singly Linked List API doesn't have a function to access its length.

There is no function in the Singly Linked List API that gives access to the length of the list. The only way to access it is to reference the data structure's private area, and read the length variable, which should be private.

There is no function in the Doubly Linked List API that returns list length.

There is no function in the Doubly Linked List API that gives access to the length of the list. The only way to access it is to reference the data structure's private area, and read the length variable, which should be private.

'empty()/null()' and 'contains()/elem()' functions aren't higher order functions.

The 'empty()/null()' and 'contains()/elem()' functions of FOCS data structures should not be grouped with other higher order functions because they are not higher order functions. They would be better grouped with other data structure management functions, like 'size()'.

No Unit Tests for Generics API

The generics API has no associated unit tests, and the exported macros are not used in the unit tests for any data structure.

double_list doesn't conform to data structure API.

The doubly linked list data structure double_list isn't defined using the new data structure API defined in 'focs/data_structures.h'.

The Ring Buffer API lacks a "reverse" function.

The other data structure APIs in FOCS have some form of reverse function, but ring_buffer lacks this functionality.

'single_list' doesn't support generics macros

The higher order functions and management operations data structures are set to NULL in the singly linked list implementation, so that singly linked lists can't be used with the generic macros.