qy-h00/ped

ped's Issues

Usage of statAppt

In my opnion, such command may not be useful.

Feedback of conflict appointments

When typing the feedback of conflict appointments, the feedback only says that the appointment already exists in the records as followings:

Would you think it's better to add the explict reason for that? Since the application will be used to serve NUS where there are many students. When the appointments are many, it may be hard for user to find what's wrong with the command.

Lack of screenshot in delete

Lack of screenshot in deleteAppt

Wrong input instance in the feedback of add command

When using add command in wrong format, the user will receive the feedback where the example is also in wrong format.

In this example, the matriculation numbers should be of the format A + 7 digit numueric sequence + alphabet according to UG.

Inconsistent command format for edit and editAppt

For the edit format, the application uses number as parameters.
For the editAppt format, the application uses matriculation as parameters.

If the user type wrongly for the matriculation number, he cannot edit that appointment which means he can only delete it and add a new one which causes innconvenient.

Lack of screenshot in editAppt

Incorrect format of name

The name format can be 123123, which may not be the correct format of Student Name.

description of SCHOOL_RESIDENCE

In the paramter formats, the SCHOOL_RESIDENCE doesn't contain the DOES_NOT_LIVE_ON_CAMPUS. But it's important when using filter or stats.

Can add an appointment for vaccinated student

Lack of screenshot of filter

I think because filter will change the view of list, it may be better to add a screenshot.

Integerate the command find and filter

On my opinion, the function of filter is exactly the same as find. Maybe it's better to combine these two commands?

Lack of screenshot in statsAppt

Lack of screenshot of edit

Length of phone number can in wrong size

I set this as medium severity since the invalid contaction may be a serious feature flaw because of the basic function of such application is used to track COVID-19 vaccinations. It may be quite risk if we cannot contact the student immediately since it's related to the personal safety.

Incorrect format of address

The address format can be any string.. Maybe it's better to add a formatter although it's an inheritance from AB3.

Wrong sample description of stas all