rabobank-nederland/omnikassa-php-sdk

This repository contains the official PHP SDK for Rabo OmniKassa.

omnikassa-php-sdk's Issues

LICENSE.md contradicts license property in composer.json

Should be MIT, however the composer.json file says proprietary.

Add an exception if Omnikassa is unavailable

Hello,

We use omnikassa in our application, and sometimes the sandbox environment is unavailable, the problem is that the error that is send when the service is unavaible doesn't speak for itself. We hava a Warning: Trying to access array offset on value of type null send from the class AccessToken line 48.

Maybe a fix can be to see if the access token contain an error message before creating the access token from the json in the method retrieveNewToken in the class ApiConnector like this:

    /**
     * @return AccessToken
     */
    private function retrieveNewToken()
    {
        $refreshToken = $this->tokenProvider->getRefreshToken();

        $this->restTemplate->setToken($refreshToken);
        $accessTokenJson = $this->restTemplate->get('gatekeeper/refresh');

        if (str_contains($accessTokenJson, 'Tijdelijk niet beschikbaar')) {
            throw new \HttpException('OmniKassa is temporarily unavailable', 503);
        }

        return AccessToken::fromJson($accessTokenJson);
    }

What do you think?

Updating to guzzlehttp/guzzle 7

Is there any chance the PHP implementation will be updated to use guzzle version 7?

Guzzle 7 support

To upgrade a few projects with this package, Guzzle 7 is needed.

There are multiple Pull Requests to address this issue.

Action required:

• Choose one or more solutions to fix the problem

PRs:

• #26
• #23

Fatal error: Uncaught GuzzleHttp\Ring\Exception\ConnectException: cURL error 6

Hello, I have an issue with making transactions with certain amounts(37.91 and 68.57, EUR), in an older version of your SDK, this was an issue with the rounding of numbers and is fixed in the newer versions, but when I updated our entire SDK, I got an error which states " Fatal error: Uncaught GuzzleHttp\Ring\Exception\ConnectException: cURL error 6: Could not resolve host: gatekeeper;".
So I ended up updating only the part that rounds the total price of the transaction, but when this is done, it takes those 2 amounts, adds 1 cent and creates the transaction, which results in the amount to be paid ends up being 37.92 or 68.58.
Do you current solution for these problems?