Using env.merge in urlmap stops you from being be able to pass env changes back up the chain

[rack]

Using env.merge in urlmap stops you from being be able to pass env changes back up the chain

[knzconnor]

I've made the change and a test, but my fork is having problems. I can shoot you the patch if you want.

[knzconnor]

http://github.com/downloads/timocratic/rack/0001-test-for-mapping-in-builder.patch
http://github.com/downloads/timocratic/rack/0002-don-t-dupe-env-in-urlmap-so-it-can-be-modifying-down.patch

[manveru]

I'd like to close this issue, the current behavior is intentional so that urlmap can proxy the same env to each app.
I don't think we can resolve this issue to satisfy everybody, and it's not really a lot of code we're talking about, so how about you subclass and write the method the way you want it to behave?

[knzconnor]

That's funny, on the mailing list I thought ryan was saying he agreed, it should be in the spec that it should use merge! I'll go re-read the chain and try to see what I am misunderstanding. Maybe I did a bad job searching for the issue, but I couldn't find any discussion about why it was intentionally that way, my bad.

I also am not quite sure I get the benefit of using the duplicating version of merge when you want "the same env to each app." Or do you actually mean "a different copy of the env, at the state it was first passed in?"

[knzconnor]

Maybe discuss here? http://groups.google.com/group/rack-devel/browse_thread/thread/e1fc1d0f17b7790d/bb998ce5a632b9dd?hl=en

[knzconnor]

Thanks. Closed by: http://github.com/rack/rack/compare/fa324e371d...7c5a9b8f6b