radiofrance/dib

An Opinionated Docker Image Builder

dib's Issues

Make trivy cli options configurable

Is your feature request related to a problem? Please describe.
We want the option we use to run trivy to be configurable via dib config

Describe the solution you'd like
Make it possible, either in dib config file or in command line, to override the default args for trivy command

Integrate trivy scan reports in dib html report

Is your feature request related to a problem? Please describe.
We want the reports generated by trivy to be integrated in dib html report

Describe the solution you'd like
Parse the json file and output results in html

Describe alternatives you've considered
We could have used the template format in trivy with a custom html template, but it would have been more difficult to integrate easily with our existing html generation

Make graph and test options the default

and revert options to disable graph and disable tests

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update minor-updates (golang.org/x/term, golangci/golangci-lint-action, goreleaser/goreleaser-action)

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• chore(deps): update module k8s.io/client-go to v11

Detected dependencies

dockerfile

pkg/dockerfile/dockerfile.go

github-actions

.github/workflows/lint.github-action.yml

• actions/checkout v3.5.3@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
• zgosalvez/github-actions-ensure-sha-pinned-actions v2.1.3@555a30da2656b4a7cf47b107800bef097723363e

.github/workflows/lint.golang.yml

• actions/setup-go v4.0.1@fac708d6674e30b6ba41289acaab6d4b75aa0753
• actions/checkout v3.5.3@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
• golangci/golangci-lint-action v3.5.0@5f1fec7010f6ae3b84ea4f7b2129beb8639b564f

.github/workflows/lint.yaml.yml

• actions/checkout v3.5.3@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
• ibiqlik/action-yamllint v3.1.1@2576378a8e339169678f9939646ee3ee325e845c

.github/workflows/release.goreleaser.yml

• actions/checkout v3.5.3@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
• actions/setup-go v4.0.1@fac708d6674e30b6ba41289acaab6d4b75aa0753
• goreleaser/goreleaser-action v4.2.0@f82d6c1c344bcacabba2c841718984797f664a6b

.github/workflows/test.golang.yml

• actions/setup-go v4.0.1@fac708d6674e30b6ba41289acaab6d4b75aa0753
• actions/checkout v3.5.3@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
• actions/upload-artifact v3.1.2@0b7f8abb1508181956e8e162db84b466c27e18ce
• actions/checkout v3.5.3@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
• actions/download-artifact v3.0.2@9bc31d5ccc31df68ecc42ccf4149144866c47d8a
• codecov/codecov-action v3.1.4@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d

gomod

go.mod

• go 1.20
• github.com/aws/aws-sdk-go-v2 v1.18.0
• github.com/aws/aws-sdk-go-v2/config v1.18.25
• github.com/aws/aws-sdk-go-v2/service/s3 v1.33.1
• github.com/docker/cli v24.0.2+incompatible
• github.com/mholt/archiver/v3 v3.5.1
• github.com/moby/patternmatcher v0.5.0
• github.com/olekukonko/tablewriter v0.0.5
• github.com/sirupsen/logrus v1.9.3
• github.com/spf13/cobra v1.7.0
• github.com/spf13/pflag v1.0.5
• github.com/spf13/viper v1.16.0
• github.com/stretchr/testify v1.8.4
• github.com/wolfeidau/humanhash v1.1.0
• gitlab.com/radiofrance/go-container-registry v0.1.6
• gitlab.com/radiofrance/kubecli v0.3.0
• golang.org/x/sync v0.2.0
• golang.org/x/term v0.8.0
• gopkg.in/yaml.v3 v3.0.1
• k8s.io/api v0.27.2
• k8s.io/apimachinery v0.27.2
• k8s.io/cli-runtime v0.27.2
• k8s.io/client-go v0.27.2
• k8s.io/kubectl v0.27.2
• k8s.io/utils v0.0.0-20230505201702-9f6742963106@9f6742963106

Dib should fail when an incorrect value is passed via `--config`

Describe the bug
Dib doesn't say anything when passing an incorrect value in --configoption. Not even a log.

To Reproduce
Steps to reproduce the behavior:

1. run command dib build --config Yolo

Expected behavior
I would expect a crash or an error about the configuration file that does not exists

System (please complete the following information):

• OS: osx
• Go version 1.19
• dib version master

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update actions/checkout action to v4.1.6
• chore(deps): update kubernetes packages to v0.30.1 (k8s.io/api, k8s.io/apimachinery, k8s.io/cli-runtime, k8s.io/client-go, k8s.io/kubectl)
• chore(deps): update module github.com/aws/aws-sdk-go-v2/config to v1.27.16
• chore(deps): update module github.com/docker/cli to v26.1.3+incompatible
• chore(deps): update codecov/codecov-action action to v4.4.1
• chore(deps): update dependency golangci/golangci-lint to v1.58.2
• chore(deps): update dependency goreleaser/goreleaser to v1.26.2
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

dockerfile

pkg/dockerfile/dockerfile.go

github-actions

.github/workflows/docs.yml

• actions/checkout v4.1.5@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b
• actions/setup-go v5.0.1@cdcb36043654635271a94b9a6d1392de5bb323a7
• mhausenblas/mkdocs-deploy-gh-pages e55ecab6718b449a90ebd4313f1320f9327f1386

.github/workflows/qa.yml

• actions/checkout v4.1.5@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b
• actions/setup-go v5.0.1@cdcb36043654635271a94b9a6d1392de5bb323a7
• golangci/golangci-lint-action v6.0.1@a4f60bb28d35aeee14e6880718e0c85ff1882e64
• actions/checkout v4.1.5@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b
• actions/setup-go v5.0.1@cdcb36043654635271a94b9a6d1392de5bb323a7
• tlylt/install-graphviz v1.0.0@b2201200d85f06f0189cb74d9b69208504cf12cd
• actions/upload-artifact v4.3.3@65462800fd760344b1a7b4382951275a0abb4808
• actions/checkout v4.1.5@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b
• actions/download-artifact v4.1.7@65a9edc5881444af0b9093a5e628f2fe47ea3b2e
• codecov/codecov-action v4.3.1@5ecb98a3c6b747ed38dc09f787459979aebb39be

.github/workflows/release.yml

• actions/checkout v4.1.5@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b
• actions/setup-go v5.0.1@cdcb36043654635271a94b9a6d1392de5bb323a7
• goreleaser/goreleaser-action v5.1.0@5742e2a039330cbb23ebf35f046f814d4c6ff811

.github/workflows/security.yml

• actions/checkout v4.1.5@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b
• zgosalvez/github-actions-ensure-sha-pinned-actions v3.0.5@40e45e738b3cad2729f599d8afc6ed02184e1dbd

.github/workflows/yaml.yml

• actions/checkout v4.1.5@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b
• ibiqlik/action-yamllint v3.1.1@2576378a8e339169678f9939646ee3ee325e845c

gomod

go.mod

• go 1.22.2
• github.com/aws/aws-sdk-go-v2 v1.27.0
• github.com/aws/aws-sdk-go-v2/config v1.27.11
• github.com/aws/aws-sdk-go-v2/service/s3 v1.54.3
• github.com/docker/cli v26.1.1+incompatible
• github.com/google/uuid v1.6.0
• github.com/mholt/archiver/v3 v3.5.1
• github.com/moby/patternmatcher v0.6.0
• github.com/olekukonko/tablewriter v0.0.5
• github.com/pterm/pterm v0.12.79
• github.com/spf13/cobra v1.8.0
• github.com/spf13/pflag v1.0.5
• github.com/spf13/viper v1.18.2
• github.com/stretchr/testify v1.9.0
• github.com/wolfeidau/humanhash v1.1.0
• gitlab.com/radiofrance/go-container-registry v0.2.0
• gitlab.com/radiofrance/kubecli v0.5.1
• golang.org/x/sync v0.7.0
• gopkg.in/yaml.v3 v3.0.1
• k8s.io/api v0.30.0
• k8s.io/apimachinery v0.30.0
• k8s.io/cli-runtime v0.30.0
• k8s.io/client-go v0.30.0
• k8s.io/kubectl v0.30.0
• k8s.io/utils v0.0.0-20240502163921-fe8a2dddb1d0@fe8a2dddb1d0

pip_requirements

requirements.txt

• pymdown-extensions >=9.10

regex

.github/workflows/qa.yml

• golangci/golangci-lint v1.57.2

.github/workflows/release.yml

• goreleaser/goreleaser v1.25.1

---

• Check this box to trigger a request for Renovate to run again on this repository

Make available --build-arg option

Hello,
Is your feature request related to a problem? Please describe.
We want to use the --build-arg option of the docker build command in order to pass variables for each build.

Describe the solution you'd like
If possible, make available the usage of --build-arg option either in dib conf file or command line

Additional context
Following an example of the bash script where we build the image and our --build-arg usage

docker build -t "$REGISTRY_K8S"/"$image":"latest" "$image_path" \
    --no-cache \
    --build-arg CI_JOB_TOKEN=${CI_JOB_TOKEN} \
    --build-arg CI_GLPI_APPTOKEN=${CI_GLPI_APPTOKEN} \
    --build-arg CI_GLPI_USERTOKEN=${CI_GLPI_USERTOKEN} \

Thanks in advance