radioo/linclelink

Arcade data storage and deduplication utility.

linclelink's Issues

Link to torrent: uncaught exception with files in relative data path

When using Link to torrent > Check Files,
and within the torrent there is 1+ file in the directory specified by "Torrent relative data path"
and the value given to "Torrent relative data path" does not end with a directory separator

...an uncaught exception occurs:

System.ArgumentOutOfRangeException: 'startIndex cannot be larger than length of string. Arg_ParamName_Name'

This doesn't affect most Bemani games (I think DDR A/20 is an exception) if the "data" directory is used, as recommended.

The cause AFAICT is that, when the first file in the torrent (within the relative path) is checked, RelativePath is given a separator if it doesn't have one, then its new length is used to try to get a substring from the file's directory path (which doesn't have a separator).

Related code:

LincleLINK/LincleLINK/Logic/MainWindowLogic.cs

Lines 535 to 545 in fe02874

	if (relPath.StartsWith(RelativePath))
	{
	string relPathQ = relPath;
	if (relPath != string.Empty && !string.IsNullOrEmpty(RelativePath))
	{
	if (!Path.EndsInDirectorySeparator(RelativePath))
	{
	RelativePath += Path.DirectorySeparatorChar;
	}
	relPathQ = relPath.Substring(RelativePath.Length);
	}

Also, if I understand the code correctly:
Exception on the first file aside, relPath.StartsWith(RelativePath) would return false for any other files in the relative data path.
Again, this doesn't affect most Bemani games, but any such files would not be handled.

Unhandled IOException when disk is full

Wasn't seeing any low disk messages but LL kept crashing mid-copy.

CoreCLR Version: 6.0.722.32202
.NET Version: 6.0.7
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IO.IOException: There is not enough space on the disk. : 'F:\bemanipc\LincleLink\db\3BCC7A48FB59D37584260B128C6E343D.ifs'
   at System.IO.FileSystem.CopyFile(String sourceFullPath, String destFullPath, Boolean overwrite)
   at System.IO.File.Copy(String sourceFileName, String destFileName, Boolean overwrite)
   at System.IO.File.Copy(String sourceFileName, String destFileName)
   at LincleLINK.AddInstanceWindowLogic.<>c__DisplayClass41_1.<CreateInstance>b__0() in C:\Users\radio\Documents\Coding\WPFLinkTool\LincleLINK\Logic\AddInstanceWindowLogic.cs:line 209
   at System.Threading.Tasks.Task.InnerInvoke()
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location ---
   at LincleLINK.AddInstanceWindowLogic.CreateInstance() in C:\Users\radio\Documents\Coding\WPFLinkTool\LincleLINK\Logic\AddInstanceWindowLogic.cs:line 209
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(Object obj)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at MS.Internal.CulturePreservingExecutionContext.Run(CulturePreservingExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Window.ShowHelper(Object booleanBox)
   at System.Windows.Window.Show()
   at System.Windows.Window.ShowDialog()
   at LincleLINK.MainWindowLogic.OpenAddInstanceWindow(Object o) in C:\Users\radio\Documents\Coding\WPFLinkTool\LincleLINK\Logic\MainWindowLogic.cs:line 231
   at LincleLINK.RelayCommand.Execute(Object parameter) in C:\Users\radio\Documents\Coding\WPFLinkTool\LincleLINK\Logic\Base\RelayCommand.cs:line 41
   at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
   at System.Windows.Controls.Primitives.ButtonBase.OnClick()
   at System.Windows.Controls.Button.OnClick()
   at System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(MouseButtonEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)
   at System.Windows.Input.InputManager.ProcessStagingArea()
   at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
   at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
   at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.Run()
   at System.Windows.Application.RunDispatcher(Object ignore)
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run()
   at LincleLINK.App.Main()

"File in use" uncaught exception during torrent piece check

When running Link to Torrent > Check Pieces, LL will crash silently if one of the data files is in use.

I got this when I had a torrent application open, seeding from one folder of hardlinked data and also downloading to a folder that had previously been initialised with Link to Torrent (don't know whether one or both was responsible).

Occurs at

LincleLINK/LincleLINK/Logic/MainWindowLogic.cs

Line 622 in fe02874

byte[] fileBytes = File.ReadAllBytes(Path.Combine(dbDir, iQ.Single().HashedFileName));

Error:

System.IO.IOException: 'The process cannot access the file 'path\to\LinkleLink\db\E13CAB130F2C395C5306219DC4D4E6F0.ifs' because it is being used by another process.'