Giter Site home page Giter Site logo

firefox-gnome-theme's Introduction

firefox-gnome-theme's People

Contributors

73 avatar adryd325 avatar birdinfire avatar charosw avatar cleomenezesjr avatar commenter25 avatar dyegoaurelio avatar garrett avatar hellcp avatar kisuyami avatar lunakurame avatar lunaneff avatar majjejjam avatar markx86 avatar oscfdezdz avatar piousdeer avatar proxzima avatar rafaelmardojai avatar seadve avatar seungheonoh avatar shawntax avatar silejonu avatar soumyadghosh avatar svito3 avatar thelich132 avatar thuhtoosan avatar titaniumtown avatar tombursch avatar trevnels avatar tripleight avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

firefox-gnome-theme's Issues

Fix GNOME stack icons coloring issues

The headerbar buttons color need some improvements. they are greyed out. even with the dark theme enabled.

The headerbar buttons with light theme (they should be black like the reload button!!).
image image

The headerbar buttons with dark theme (they should be in white color!).
image

Script Errors

This errors occurs when the auto install method is applied.

./scripts/install.sh: linha 26: cd: /home/arch/.mozilla/firefox//*.default: Arquivo ou diretório inexistente
Installing theme in /home/arch/Repositories/firefox-gnome-theme
Coping repo in /home/arch/Repositories/firefox-gnome-theme/chrome
cp: não é possível copiar um diretório, '/home/arch/Repositories/firefox-gnome-theme', para si próprio, '/home/arch/Repositories/firefox-gnome-theme/chrome/firefox-gnome-theme'
Enabling GNOMISH extra features
Set configuration user.js file
Done.

Instructions unclear

Do we clone the repo into the chrome folder, or do we just replace our userChrome.css with the one in this repo?

It looks like the userChrome.css is dependent on the themes folder in this repo, but you cannot tell this from the README.

Empty space at the right side of tab bar

There's an empty space to the right of the tabs at all times, which doesn't seem to serve a purpose and makes the tab bar look uneven.

A screenshot depicting the issue.

The space does not seemingly represent an element which could be removed via ‘Customize…’ However, it does shrink to a smaller length when the window's width decreases significantly (to 400px or so).

I'm running GNU Icecat 60.7.2 (freed & tweaked Firefox), installed with the package manager GNU Guix on Parabola GNU+Linux-libre (freed Arch). I suppose the issue might stem from my somewhat odd setup, but am not sure. Please let me know if I can do anything to investigate further!

Extension pop-ups have inconsistent white background

Pop-ups of extensions may have white background or background of other colors. Like this one:
Popup

Is there any way to make the white gray, or crop the original popups instead of adding borders with round corners?

Mozilla Account icon

I use Fedora 30, Firefox 67 and the latest firefox-gnome-theme. Mozilla account name is above the icon in the menu.

20190704192724

(Thanks for the project, I am really happy to use it)

Window inactive issues

Latest Firefox on Wayland. Fedora. When dragging headerbar the window chrome becomes unfocused.

Improvements/Issues dump

Broken :

  • Add Bookmark buttons look broken
  • Add Search engine option from address bar looks broken
  • Extensions like feeds use dark font on dark backgrounds
  • Volume button too close to X button
  • Bookmark animation is broken
  • Dropdown selected tab with blue line gets obscured when hovering

Improvements :

  • Scrollbar theming (it's not dark on dark mode and doesn't act like GTK programs)
  • Find view could be changed to be more similar to Epiphany's and other gnome programs
  • Results Not connected to URL bar and no limit to height like Epiphany has
  • Certificate information theming
  • Permission request buttons theming
  • Download overview theming

I didn't create an issue for each since I thought it'd be be too much

The Close Tab Button Looks Ugly

Screenshot-20190715051421-138x124
The Close Tab button doesn't look good. The rectangle that shows up when the cursor hover over the button should be smaller and shouldn't border with the tab.
firefox-gnome-theme Close Tab

Nicely center findbar search field when sidebar is present

Hello, thanks for this theme!

I wanted to mention that the findbar's search field is nicely centered in an ordinary Firefox window, but it is no longer when you have a sidebar such as the bookmarks sidebar open.

It seems to always center itself on your screen, and not on the viewport of the site or the findbar's width.

Thanks!

Support diferent GTK themes

I use the Mojave-Light theme from gnome look and it doesn't use that theme. Any possibility for this to simply adopt the theme from the user instead of having Adwaita coded into it?

Installation script

Please test WIP installation script.

bash <(curl -s https://raw.githubusercontent.com/rafaelmardojai/firefox-gnome-theme/master/scripts/install.sh)

It optionally accepts flags:

  • -f $firefox_folder (Sets custom Firefox folder)
  • -p $profile_folder (Sets custom profile folder)
  • -g (Auto enable GNOMISH extra features hide-single-tab.css & matching-autocomplete-width.css)

For example this will work for flatpak and icecat:
bash <(curl -s https://raw.githubusercontent.com/rafaelmardojai/firefox-gnome-theme/master/scripts/install.sh) -f ~/.var/app/org.mozilla.FirefoxNightly/.mozilla/firefox/

bash <(curl -s https://raw.githubusercontent.com/rafaelmardojai/firefox-gnome-theme/master/scripts/install.sh) -f ~/.mozilla/icecat/

"List all tabs" button is invisible

The icon to list all tabs is missing when using Adwaita icons provided by the theme. I installed using the install script and the "-g" option. It looks like this.

Different active tab colors

For some reason, the active tab color is different for certain tabs (couldn't identify a pattern yet). At the first image below, it is good but at the second one it is hard to identify the active tab.

2019-07-17-174551_582x347_scrot
2019-07-17-174528_752x449_scrot

Theme variants behavior

I have discover the @media (prefers-color-scheme: dark/light) media query. So now we have a way to detect if host theme is light or dark when default theme is selected in Firefox.

Should we keep support for Firefox light/dark theme selector? (:-moz-lwtheme and :-moz-lwtheme-brighttext pseudo classes)

Distribute patches

I think this is the way to go for easy installation.
New repo should be created to this purpose, and keep this repo as CSS source and theme-hack. (I'm also considering switch to sass/less, for a easy code maintenance and generate a single css file)

I have no idea about patching/packaging, so i'm asking for:

  • Figure out what needs to be put where.
  • Name proposals, we should rebrand Firefox to distribute it.
  • Package maintainers, to distribute css patches.

user.js

A user.js needs to be created.

Proof of concept:

// Enable customChrome.css
user_pref("toolkit.legacyUserProfileCustomizations.stylesheets", true);

// Enable CSD
user_pref("browser.tabs.drawInTitlebar", true);

Installation script should include a flag for dark mode (maybe -d), to add ui.systemUsesDarkTheme.

Download manager icons are too big

I use Fedora 30, Firefox 67 and the latest firefox-gnome-theme.

20190704192911

It is Download manager (sorry for Russian UI). The Back and Forward buttons are too big.

Dragging the headerbar buttons doesn't drag the window

I don't know if this can be implemented in the theme, but in GNOME applications, click+dragging a button in the headerbar drags the window, thus providing a larger draggable area. With this theme, if Firefox has a small window, the UI elements pack closely together, and the draggable area becomes quite small.

Issue dump 2

  • Sign/Account item in the hamburger menu is off-set when not logged in resulting in a blank space.
  • Container tab colors are no longer lines but instead circles
  • List all tabs has space on the left of the volume icon
  • Library and other items use black items on dark backgrounds
  • Broken back button functionality due to #14 (It normally can be dragged to show back history)
  • Block element item (From ublock origin) in context menu has more spacing than other items

I'll post screenshots if you need

Findbar content alignment

Textbox and next & previous buttons are not aligned as you can see, buttons are higher than textbox

Untitled

Bookmarks and History use dark background with bad readability

Thanks for fixing previous 2 issues so quickly.

Hope you didn’t mind if I will bring another small issue:

20190705155524
20190705155536

Here are Bookmarks and History side panel. In the light theme, it uses a dark gray background. Black is not really readable on this background.

Dropping gnome-icons.css

Soon GNOME icons will be included in theme as SVG to fix #8. And Adwaita icon theme will be "hardcoded".

So gnome-icons.css main functionality will be included by default.

But I'm considering create system-icons.css, with similar functionality, for the ones not using Adwaita icons and want to use their system icon theme. But facing moz-icon://stock/ issues.

Inconsistent tab alignment when playing audio

First of all, thank you for the theme! I love it.

I noticed an inconsistency when you have a tab that is sharing your webcam. Definitely not a critical bug -- everything works fine -- but it threw me off for a split second.

Here's what the tab looks like when the tab is focused: (text is centered, all is well)
screenshot_2019-07-18-12:34:08

And here's what the tab looks like when it's unfocused: (text is left-aligned, unlike other tabs)
screenshot_2019-07-18-12:34:29

I'd expect the text to remain centered when the tab is unfocused, but it becomes left-aligned.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.