rafali/flickr-uploader

flickr-uploader's Issues

Provide Up Navigaton when in upload queue mode

For some reason, there's an up missing. Up should take you back to shows/videos/feed, etc.

Uploading stopping after 80-ish photos uploaded

I'd got something like 900 photos for uploading.
Uploader started to upload, reached ~70 and was staying still not uploading anymore. Tried stop/start wifi - didn't help. Killed the app. Started it. All thumbnails were gone. The app started empty cycling on the same photo at 0%. The same it couldn't upload last time. Killed it again. The whole UI was empty (no photos shown) but still saying that it was uploading the same photo.
Restarted the phone.
It started to upload, reached 118 and stopped again. And everything repeated. Tried to send feedback from phone but button did nothing. It used to flash as having been pressed but no mail client launched.
Restarted again, this time uploaded 82 photos until the problem

using Flickr Uplolader 2.3.2 on slimrom 4.4.4 on samsung s2

"Waiting for wifi" notification

I've set the app to only upload photos when WiFi is available.

1. I don't want notifications about this. If I'm out and about taking photos, I'm well aware that I'm not connected to WiFi. Please don't to notify me about this at all.
2. Clearing the notification is ineffective. It returns only seconds later with the exact same message. Unsurprisingly, since the wireless antenna is off, a WiFi connection did not magically become available in the past 30 seconds.
3. I haven't looked at the source code, but is the upload attempt actually polling on a timer? If this is the case, it should instead listen for CONNECTIVITY_ACTION broadcasts. With my chosen setting, there's no need for the app to even be running, let alone attempt an upload, when the wireless antenna is disabled.

Folders not reloading

Needs a long time to detect new files , even when sliding down ( shows reload icon), there is no button to trigger refreshing file list

Race Condition when loading media and changing the view size

Description

It is possible to change the view size of media while they are loading in the background.
As a result the medias can be temporary shown in the wrong order.

Steps to reproduce the issue

Initial state: main activity showing the listing of medias by folder is shown and view size is set to medium

1. click on option at top of the screen and change the group by to Date. As a result a background task is created that first loads the medias and sorts them based on the selected grouping.
2. while the medias are loading, change the view size to small. The application takes currently shown medias and immediately redraws them with the new view size. However, it already accounts for the changed grouping option and takes the old medias (ordered by folder) and groups them by date. As a result they are very likely to be in the wrong order.
   
3. The background task created in step 1. finishes and redraws the medias in the correct order.
   

The wrong execution can be easily triggered after adding Thread.sleep to simulate slow database before Utils.loadMedia(false) call.

Possible Fix

We can make the two events (changing the view size and loading) commutative by always resorting the current medias when the view size changes.

Order upload queue by date, so oldest photos are uploaded first

Attempts to re-upload everything when my phone restarts

Not sure if anyone else is having this problem, but it means I have to clear the upload queue each restart, which is quite irritating if I don't remember straight away.

My phone is a rooted i9505 with a custom ROM, but the ROM is just stock android (TouchWiz sucks).

Not all photos uploaded/queued

Both me and my girldfriend is using this on our main camera-folders to upload "all" photos to flickr automatically. But we are both seeing randomly ignored photos, ie, they have no icon on them, and they are not uploaded to flickr?

Worryingly, some un-marked photos are uploaded and some are not. Is there any way to get at the logfiles? I could not find a way.

Disappeared from the Play Store❗

Where's it gone? :(

Show some kind of warning in case of network issues while uploading

I will probably add a progress view inside the main app where the user can see what's going on when she/he wants to monitor the uploads.

Provide option to hide media from feed/photos/video etc

Media views should default to monitored folders with an option in the overflow to show other/additional folders.

Check if a file is being modified before uploading it

https://mail.google.com/mail/ca/u/0/#label/FlickrUploader/13fc44e4935a81de

Use Navigation Drawer

There are enough top level views that a Navigation Drawer would be justified.

Use AndroidStaggeredGrid for photos and videos

There library enables you to view photos in the dimensions intended and gracefully. Currently the thumbs are squares.

https://github.com/etsy/AndroidStaggeredGrid

When enabling/disabling auto upload on a folder, also do it for all virtual links

https://mail.google.com/mail/ca/u/0/#label/FlickrUploader/13fc44e4935a81de

"Upload finished" notification

It appears the "Upload finished" notification is still marked with setOngoing(true). This prevents the Android OS from showing a "Clear" button to remove it from the notification bar.

Furthermore, why is this even a notification at all? Notifications should describe ongoing processes or things that require my attention (e.g., progress or failure). We shouldn't be using notifications for standard, business-as-usual events.

Upload failed due to SSL requirement

I'm a premium user and encounter an issue with the Android last version. All my uploads failed with a code 95 and a message saying "SSL is required".

Multiple background task loading the media at the same time

Description

Whenever filtering and grouping options are changed a new background task is created in the FlickrUploaderActivity to load the media, despite the fact that one or more of such tasks running might be already running.
If there are multiple loads at the same time the order in which they finish is non-deterministic which might lead to displaying old results.

Possible Fix

Android annotations since version 3.0 provide a way to assign id to each task created using @Backround annotation as follows:

@Background(id="cancellable_task")
void load() {
...
}

after this, before each call to load method we can simply cancel any active tasks using

BackgroundExecutor.cancelAll("cancellable_task", true); 

Premium features with trial period

• auto-upload feature will now only be available in Premium
• it will be available to new user as a 7-day trial
• previous users will have a 6 months free use
• users who donated or helped debugging the app will have the Premium for free