raiderrobotix/blue-alliance-api-java-library

Java library for The Blue Alliance APIv3

blue-alliance-api-java-library's Issues

NullPointerException with team requests

 Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String com.thebluealliance.api.v3.requests.APIResponse.getJson()' on a null object reference

My code:

TBA tba = new TBA("key");
Team robot = new Team();
TeamRequest c = tba.teamRequest;
Event[] e = c.getEvents(2658);(the error seems to be directed to this line)
robot = c.getTeam(2658);

District rankings deserialization

Trying to get teams from an event throws IllegalAccessException

When calling getTeams on an EventRequest, the JSON parser will invoke the wrong constructor for Team and result in an IllegalAccessException.

https://github.com/RaiderRobotix/blue-alliance-api-java-library/blob/master/src/main/java/com/thebluealliance/api/v3/requests/EventRequest.java#L57
https://github.com/RaiderRobotix/blue-alliance-api-java-library/blob/master/src/main/java/com/thebluealliance/api/v3/models/Team.java#L17

java.lang.RuntimeException: Failed to invoke com.thebluealliance.api.v3.models.Team() throws java.lang.IllegalAccessException with no args
    at com.google.gson.internal.ConstructorConstructor$3.construct(ConstructorConstructor.java:118)
Caused by: java.lang.IllegalAccessException: You've called the constructor of Team
    at com.thebluealliance.api.v3.models.Team.<init>(Team.java:17)

Unhandled NullPointerException if a team number or event code does not exist

When passing in a team number to TeamRequest.getTeam(), the method .getJson() is called on the API response, which will cause a NullPointerException if the team number does not exist. The same result will happen if an invalid event code is provided, or any other similar invalid parameter. Since the method does not handle the exception, there is no way for the implementer to handle the exception. Perhaps the methods should throw NullPointerException, that way the implementer can catch the Exception in the event the team number does not exist.

https://github.com/RaiderRobotix/blue-alliance-api-java-library/blob/master/src/main/java/com/thebluealliance/api/v3/requests/TeamRequest.java#L34

TeamEventStatus model class is missing @Value tag, values cannot be accessed

It appears that the TeamEventStatus class should have the @Value annotation in order to automatically generated getter methods. The values of that model class are currently not able to be accessed outside of the package.

https://github.com/RaiderRobotix/blue-alliance-api-java-library/blob/master/src/main/java/com/thebluealliance/api/v3/models/TeamEventStatus.java#L8