rakshazi/getsettrait

Magic getter/setter trait for any PHP class in one string of code.

getsettrait's Issues

Class Rakshazi\\string does not exist

getSetTrait/src/GetSetTrait.php

Line 101 in 5a5cd0e

public function setDataProperty(string $property)

string is not a valid type for type hinting until PHP 7

Implement a hasData method

I have a use case where it would be useful to be able to test whether or not a property has been assigned. Being able to call a $dummy->hasFoo() method that returns a boolean indicating whether the property has been set.

Implement a getAllData method

In our use case it would be desirable to fetch all assigned properties from the object in an array.

Unable to mock (using Mockery) classes using this trait

If in unit testing, try to mock classes using this trait with the Mockery library an error occurs:

ErrorException: Declaration of Mockery_2_Class_Name_Here::__call($method, $args) should be compatible with Class\Name\Here::__call($method = NULL, $params = Array)

The issue is that Mockery replaces the __call method of it's own, and the declaration of the parameters doesn't match. Mockery should probably take care to ensure it doesn't do that, but in this case I think getSetTrait is partially at fault.

The __call magic method is invoked when you attempt to call a method that doesn't exist, so the first param (the method name) will always be supplied. Likewise if the method was called with no params, the second parameter will be an empty array, so that will also always be supplied. Hence there's no value in declaring these as optional, and changing that fixes the issue with mocking as well.