randomcodenz/rails_deprecation_log_analyser

rails_deprecation_log_analyser's Issues

except!

Build classifier to classify the following:

Method except! is deprecated and will be removed in Rails 5.1, as ActionController::Parameters no longer inherits from hash. Using this deprecated behavior exposes potential security problems. If you continue to use this method you may be creating a security vulnerability in your app that can be exploited. Instead, consider using one of these documented methods which are not deprecated: http://api.rubyonrails.org/v5.0.3/classes/ActionController/Parameters.html (called from consumer_params_security at /var/lib/jenkins/powershop/app/controllers/admin/consumers_controller.rb:267)

Missing documentation

There is no documentation - add some!

Passing a class as a value in an ActiveRecord query

Build a classifier to classify the following:

Passing a class as a value in an Active Record query is deprecated and will be removed. Pass a string instead. (called from find_or_initialize_by at /var/lib/jenkins/gems/ruby/2.3.0/gems/protected_attributes_continued-1.3.0/lib/active_record/mass_assignment_security/relation.rb:53)

:restrict_dependent_destroy.many

Build a classifier to classify the following:

The error key :'restrict_dependent_destroy.many' has been deprecated and will be removed in Rails 5.1. Please use :'restrict_dependent_destroy.has_many' instead. (called from block in transaction_with_isolation_level at /var/lib/jenkins/gems/ruby/2.3.0/gems/transaction_isolation_level-1.1.0/lib/transaction_isolation_level/adapter_patches.rb:43)

Returning `false` in Active Record and Active Model callbacks

Build a classifier to classify the following:

Returning false in Active Record and Active Model callbacks will not implicitly halt a callback chain in Rails 5.1. To explicitly halt the callback chain, please use throw :abort instead. (called from block in transaction_with_isolation_level at /var/lib/jenkins/gems/ruby/2.3.0/gems/transaction_isolation_level-1.1.0/lib/transaction_isolation_level/adapter_patches.rb:43)

Classifier auto-discovery or inclusion test

Find a way to make it easier for the classifiers to be included in the config. I have added classifiers a couple of times and forgotten to include them in the config so they are used. Could build auto-discovery but a simpler option may be to add a single test that finds all of the classifiers and asserts they are all present in the config.

Generate a valid file if there are no warnings

Ensure that the analyser generates a valid checkstyle file if there are no warnings.

Missing tests

There is very limited test coverage. Need to add tests for most of the core classes.

Comparing equality between `ActionController::Parameters` and a `Hash`

Build a classifier to classify the following:

Comparing equality between ActionController::Parameters and a Hash is deprecated and will be removed in Rails 5.1. Please only do comparisons between instances of ActionController::Parameters. If you need to compare to a hash, first convert it using ActionController::Parameters#new. (called from == at /var/lib/jenkins/gems/ruby/2.3.0/gems/rspec-expectations-3.5.0/lib/rspec/matchers/built_in/eq.rb:35)

#to_hash

Build a classifier to classify the following:

#to_hash unexpectedly ignores parameter filtering, and will change to enforce it in Rails 5.1. Enable raise_on_unfiltered_parameters to respect parameter filtering, which is the default in new applications. For the existing deprecated behaviour, call #to_unsafe_h instead. (called from merge at /var/lib/jenkins/powershop/app/controllers/admin/fees_controller.rb:57)

Method with_indifferent_access classifier

Build a classifier to classify the following:

Method with_indifferent_access is deprecated and will be removed in Rails 5.1, as ActionController::Parameters no longer inherits from hash. Using this deprecated behavior exposes potential security problems. If you continue to use this method you may be creating a security vulnerability in your app that can be exploited. Instead, consider using one of these documented methods which are not deprecated: http://api.rubyonrails.org/v5.0.3/classes/ActionController/Parameters.html (called from assign_nested_attributes_for_one_to_one_association at /var/lib/jenkins/gems/ruby/2.3.0/gems/protected_attributes_continued-1.3.0/lib/active_record/mass_assignment_security/nested_attributes.rb:53)

redirect_to :back

Build a classifier to classify the following:

redirect_to :back is deprecated and will be removed from Rails 5.1. Please use redirect_back(fallback_location: fallback_location) where fallback_location represents the location to use if the request has no HTTP referer information. (called from destroy at /var/lib/jenkins/powershop/app/controllers/admin/consumers_controller.rb:209)

Deprecation warning de-duplication doesn't work

Currently deprecation warnings are de-duplicated by using a sha generated from the deprecation warning fields and the log lines processed. This will generate different shas for the same deprecation warning if the log lines are different (e.g. different deprecation warning line leaders).

Fix is to move the sha into the deprecation warning class and use that to de-duplicate deprecation warnings.

map

Build a classifier to classify the following:

Method map is deprecated and will be removed in Rails 5.1, as ActionController::Parameters no longer inherits from hash. Using this deprecated behavior exposes potential security problems. If you continue to use this method you may be creating a security vulnerability in your app that can be exploited. Instead, consider using one of these documented methods which are not deprecated: http://api.rubyonrails.org/v5.0.3/classes/ActionController/Parameters.html (called from parse_date at /var/lib/jenkins/powershop/app/controllers/admin/interactions_controller.rb:35)

each_with_object

Build a classifier to classify the following:

Method each_with_object is deprecated and will be removed in Rails 5.1, as ActionController::Parameters no longer inherits from hash. Using this deprecated behavior exposes potential security problems. If you continue to use this method you may be creating a security vulnerability in your app that can be exploited. Instead, consider using one of these documented methods which are not deprecated: http://api.rubyonrails.org/v5.0.3/classes/ActionController/Parameters.html (called from create at /var/lib/jenkins/powershop/app/controllers/admin/disputed_reads_controller.rb:34)

deep_symbolize_keys

Build a classifier to classify the following:

Method deep_symbolize_keys is deprecated and will be removed in Rails 5.1, as ActionController::Parameters no longer inherits from hash. Using this deprecated behavior exposes potential security problems. If you continue to use this method you may be creating a security vulnerability in your app that can be exploited. Instead, consider using one of these documented methods which are not deprecated: http://api.rubyonrails.org/v5.0.3/classes/ActionController/Parameters.html (called from inbound_consumer_params_for_creation at /var/lib/jenkins/powershop/app/controllers/admin/inbound_consumers_controller.rb:894)

render :text

Build a classifier to classify the following:

render :text is deprecated because it does not actually render a text/plain response. Switch to render plain: 'plain text' to render as text/plain, render html: 'HTML' to render as text/html, or render body: 'raw' to match the deprecated behavior and render with the default Content-Type, which is text/html. (called from reload_page at /var/lib/jenkins/powershop/app/controllers/admin/daily_consumption_overrides_controller.rb:68)

member?

Build a classifier to classify the following:

Method member? is deprecated and will be removed in Rails 5.1, as ActionController::Parameters no longer inherits from hash. Using this deprecated behavior exposes potential security problems. If you continue to use this method you may be creating a security vulnerability in your app that can be exploited. Instead, consider using one of these documented methods which are not deprecated: http://api.rubyonrails.org/v5.0.3/classes/ActionController/Parameters.html (called from load_icp at /var/lib/jenkins/powershop/app/controllers/admin/daily_consumption_overrides_controller.rb:64)