Giter Site home page Giter Site logo

subpost's People

Contributors

randyhoyt avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

marco-s hemeda3

subpost's Issues

Lots of notice warnings when activated.

Thanks Randy for fixing the other issues!

Another one I wanted to flag is when define('WP_DEBUG', true) there a lot of notices that show up in the admin and subordinate post type interface all over the place.

Set default View All label in sidebar

subordinate menu structure
Just some feedback on what this looks like with show_in_menu true on subordinate post types ... in my case I will need to leave these in the menu to be accessed on their own as well as from within the parent editor ... but, as is, the visual structure is confusing. There are two links ... one for the title, and one for the dash. Wouldn't it be better to lose the redundant dash?

Bug with getCurrentPostType

I have three subordinate custom post types which all share one parent post type.

On the parent admin edit screen:
subpost_add_meta_box renders correctly for all three subordinate post types
However ...
subpost_render_meta_box renders the same post type in all three metaboxes

$post_types[$sub_post_type_factory->getCurrentPostType()] returns only one value

I believe the problem is happening here ...
public function getCurrentPostType() {

    return self::$sub_post_type_current;

}

but, I am not skilled enough to confirm that.
Anything I can do to test this to get it fixed?

Unregistration

Randy, I use the following function courtesy of Nacin to properly remove stuff when I decide I don't want the post type I've created any more ( for instance I created a "test" custom post type while trying to figure out the issue with the add_meta_box ) ... it would be great to extend this to include all things subordinate.
When I used this unregister function to remove the test subordinate post type, the menu items still lingered until I actually removed the registration code ... so, I imagine it isn't an entirely clean unregistration right?

if ( ! function_exists( 'unregister_post_type' ) ) :
function unregister_post_type( $post_type ) {
global $wp_post_types;
if ( isset( $wp_post_types[ $post_type ] ) ) {
unset( $wp_post_types[ $post_type ] );
return true;
}
return false;
}
endif;

add_action( 'init', 'remove_post_init', 11 );

function remove_post_init()
{
unregister_post_type( 'tsa_test' );
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.