Giter Site home page Giter Site logo

Comments (2)

onecreative avatar onecreative commented on July 20, 2024

As it turns out, it's more than just that. It appears the plugin isn't intended to work on secure pages. Can't access leaflet-src.js on the cdn.

from ckeditor-leaflet.

ranelpadon avatar ranelpadon commented on July 20, 2024

Thanks for your valuable feedback. I'm just catching up now since I'm busy for the past weeks.

As you've suggested, I've converted the Absolute URLs to Protocol-Independent URLs:
It turned out that there's now support for secured protocols via https://cdnjs.com/libraries/leaflet. The widget works now as intended.

Note that there will be a bunch of harmless notices also in the browser's console since we use Leaflet Tile Providers (https://github.com/leaflet-extras/leaflet-providers ) which contains hardcoded Absolute URLs (see the JS file in leaflet/scripts/leaflet-providers/leaflet-providers.js). I've tried also hacking this 3rd-party file by converting all the URLs to relative ones. Fortunately, all map tile services work except the MapQuest tiles. But, I'll just try to inform the author of Leaflet Tile Providers to make the necessary changes on his plugin.

In summary, the widget now works for secured protocols except for some harmless notices. I'll just wait for the changes upstream in Leaflet Tile Providers and/or MapQuest secured protocol support.

You may want to see also the commit regarding the Protocol-Independent URLs:
b8472bd

Cheers!

from ckeditor-leaflet.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.