ranelpadon/ckeditor-leaflet

Leaflet Maps Plugin for CKEditor

Latest Articles

• How (and Why) You Should Split Your .bashrc or .zshrc Files
• Pimp Your Python and Django Shells
• How to interact with Memcached using Telnet, Netcat, Python, or Django
• Keys on Steroids: Simple Setting Tweak to Increase Your Efficiency
• Vim Targets: Work on Distant Text Objects with Fewer Keystrokes

ckeditor-leaflet's Issues

Widget application?

Is this specific only for Drupal Leaflet or can be use to any framework that uses Leaflet and Ckeditor?

ERR_NAME_NOT_RESOLVED

Hi,
after update from 1.5 to 1.7 I got only errors and no image map. Its happened after I choose searched address:

Google Maps API warning: NoApiKeys https://developers.google.com/maps/documentation/javascript/error-messages#no-api-keys
iB.j @ util.js:210
(anonymous) @ js?libraries=places&callback=dummy:140
(anonymous) @ js?libraries=places&callback=dummy:50
(anonymous) @ js?libraries=places&callback=dummy:42
(anonymous) @ js?libraries=places&callback=dummy:50
(anonymous) @ js?libraries=places&callback=dummy:111
(anonymous) @ js?libraries=places&callback=dummy:42
(anonymous) @ js?libraries=places&callback=dummy:111
Xb @ js?libraries=places&callback=dummy:44
Wb.cb @ js?libraries=places&callback=dummy:111
(anonymous) @ stats.js:1
jquery.min.js?v=qoyg:4 Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
send @ jquery.min.js?v=qoyg:4
ajax @ jquery.min.js?v=qoyg:4
a.ajax @ jquery-migrate.min.js?v=qoyg:2
r.(anonymous function) @ jquery.min.js?v=qoyg:4
getJSON @ jquery.min.js?v=qoyg:4
commit @ leaflet.js?t=GB8C:277
(anonymous) @ ckeditor.js?v=qoyg:588
foreach @ ckeditor.js?v=qoyg:587
commitContent @ ckeditor.js?v=qoyg:588
(anonymous) @ plugin.js?t=GB8C:1148
m @ ckeditor.js?v=qoyg:10
CKEDITOR.event.CKEDITOR.event.fire @ ckeditor.js?v=qoyg:12
onClick @ ckeditor.js?v=qoyg:598
(anonymous) @ ckeditor.js?v=qoyg:538
m @ ckeditor.js?v=qoyg:10
CKEDITOR.event.CKEDITOR.event.fire @ ckeditor.js?v=qoyg:12
click @ ckeditor.js?v=qoyg:537
(anonymous) @ ckeditor.js?v=qoyg:529
m @ ckeditor.js?v=qoyg:10
CKEDITOR.event.CKEDITOR.event.fire @ ckeditor.js?v=qoyg:12
(anonymous) @ ckeditor.js?v=qoyg:62
otile3.mqcdn.com/tiles/1.0.0/map/10/550/344.jpeg:1 GET http://otile3.mqcdn.com/tiles/1.0.0/map/10/550/344.jpeg net::ERR_NAME_NOT_RESOLVED
otile4.mqcdn.com/tiles/1.0.0/map/10/551/344.jpeg:1 GET http://otile4.mqcdn.com/tiles/1.0.0/map/10/551/344.jpeg net::ERR_NAME_NOT_RESOLVED
otile4.mqcdn.com/tiles/1.0.0/map/10/550/345.jpeg:1 GET http://otile4.mqcdn.com/tiles/1.0.0/map/10/550/345.jpeg net::ERR_NAME_NOT_RESOLVED
otile1.mqcdn.com/tiles/1.0.0/map/10/551/345.jpeg:1 GET http://otile1.mqcdn.com/tiles/1.0.0/map/10/551/345.jpeg net::ERR_NAME_NOT_RESOLVED
otile3.mqcdn.com/tiles/1.0.0/map/5/16/10.jpeg:1 GET http://otile3.mqcdn.com/tiles/1.0.0/map/5/16/10.jpeg net::ERR_NAME_NOT_RESOLVED
otile4.mqcdn.com/tiles/1.0.0/map/5/17/10.jpeg:1 GET http://otile4.mqcdn.com/tiles/1.0.0/map/5/17/10.jpeg net::ERR_NAME_NOT_RESOLVED
otile1.mqcdn.com/tiles/1.0.0/map/5/17/11.jpeg:1 GET http://otile1.mqcdn.com/tiles/1.0.0/map/5/17/11.jpeg net::ERR_NAME_NOT_RESOLVED
otile4.mqcdn.com/tiles/1.0.0/map/5/16/11.jpeg:1 GET http://otile4.mqcdn.com/tiles/1.0.0/map/5/16/11.jpeg net::ERR_NAME_NOT_RESOLVED

i18n

Do you have any plans to support other languages? I'd like to add a translation but it seems that current version doesn't support it.

Absolute protocols vs relative protocols

Instead of writing http:// on all the urls in the plugin, you could write //. That way, when someone puts it on a secure page (https), it won't refuse to load the resources.

Mapquest discontinued direct access to tiles

The Mapquest provider is no longer functioning properly due to Mapquest making a change in their api.

You can read about it here: http://stackoverflow.com/questions/38315300/mapquest-direct-tile-access-discontinued

Error in Google autocomplete

Hi! I have some problems with Google autocomplete when I tested your demo on my domains. I tried to find some info about configuring this feature in the Installation Guide https://github.com/ranelpadon/ckeditor-leaflet/blob/master/Installation%20Guide.txt but I had no luck. Do I have to do anything to make it (Google autosuggest) work or it has to work right out of the box without any additional settings? I tested both your demo and my custom CKBuilder build on 2 different servers/domains - the result is the same. Thanks in advance and sorry for (maybe) stupid question!

Synchronous XMLHttpRequest

I got error after I got map. Its in v.1.5.
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.

After disabling plugin via `config.removePlugins` scripts from maps.googleapis.com are still loaded

I wanted to disable plugin in some forms, so I tried

config.removePlugins = 'leaflet'

Toolbar button disappeared, but there are still plenty of scripts loaded from maps.googleapis.com which affect performance.

Plugin was included by CKEditor builder.

ckeditor-leaflet is not GPLv2 compatible

I'd like to include ckeditor-leaflet in a Drupal distribution that I'm working on but, unfortunately, the LGPL v3 license used by ckeditor-leaflet is not compatible with GPLv2 (which is what all code on Drupal.org must be licensed as, per the license policy: http://drupal.org/licensing/faq#q4).

A list of GPLv2-compatible licenses can be found at http://drupal.org/node/1475972#gplv2-compatible-licenses.

I was wondering if it would be possible to change the plugin's license or dual-license it under MIT or another permitted license.

It would be great to be able to use ckeditor-leaflet with GPLv2 projects such as Drupal, Wordpress, etc!

Autocomplete not working when there are multiple instances of CKEditor in the same page.

Hello, it seems autocomplete works only in the first CKEditor instance and not in the rest.

One solution is to use native CKEditor methods for accessing dialog fields instead of jQuery. The native methods ensure access to instance-specific fields.

Lon/lat/zoom artifact values when closing dialog by pressing anything except ok.

In order to test this just create two maps with different locations (say Athens, Berlin). Open the dialog of the Athens map take a look at the lat lon values and click cancel or x to close the dialog. Now open the dialog of the Berlin map. Observe that the lat/lon values have changed to the values of Athens. If you press the ok button the Berlin map will change to Athens although no modification was performed by the user inside the dialog.

The problem lies to mapcontainer reset being done only on commit, when it probably should be done on hide.

Load scripts from maps.googleapis.com only after showing the dialog

Hi Ranel! It's me again! First of all I'd like to tell you some words about my use case. I'd like to use your plugin in my homegrown CMS which I use in my small sites. Sites have many pages and only a few of them (like "Contacts" page, for example) really needs maps. On other pages it's not necessary. So I don't want the addition of new feature negatively affect perfomance. If I add your plugin I can see that many scripts from maps.googleapis.com are loaded on the page load even if I don't open "Create Map" dialog. So I tried to move googleapis loading into the dialog and it seems that it works as I expected:

1. Google scripts are actually loaded only after opening the dialog
2. Google autocomplete works OK
   I just moved the line
   CKEDITOR.scriptLoader.load('//maps.googleapis.com/maps/api/js?libraries=places&callback=dummy&key=...');
   into the 2nd line of the Leaflet.js file. If you want I can make a pull request, but I think you should check everything twice before it and decide is it a good idea or not. I'm not sure, maybe I missed something. You can compare my version here:
   http://florako.ru/leaflet/demo/
   with yours
   http://www.ranelpadon.com/sites/all/libraries/ckeditor/plugins/leaflet/demo/index.html
   Look at the "Network" tab of the developer tools

Google Type ahead does not update coordinates on hitting return

If I type a location like Shenzhen and then hit "Return" the type head box looks up the location but then on hitting return the dialog sheet is dismissed and the map is not updated. As a user I would like to be able to type the name of the place, hit return and have the coordinates updated. Then click the ok button to dismiss the dialog and update the map.

Not show map

Its not work.
When I search address I see In console message:
This API project is not authorized to use this API. Please ensure this API is activated in the Google Developers Console: https://console.developers.google.com/apis/api/places_backend?project=_ For more information on authentication and Google Maps JavaScript API services please see: https://developers.google.com/maps/documentation/javascript/get-api-key
And popup message that its impossible open any map.