raphaeldussin/dicrivers

A preprocessing tool to specify river nutrient concentration for ocean models

DICRIVERS

A preprocessing tool to specify river biogeochemistry input for ocean models

This tool is intended to be use by ocean modelers to specify river concentrations of nutrients or other biogeochemical variable of interest (DIC, Alkalinity,...). It produces gridded fields of river concentrations from a pandas.dataframe Its name is a tribute to singer Dick Rivers, who made a living covering american classic tunes in french with a significant loss in musicality. See full documentation here:

dicrivers at readthedocs.org

To run binder examples, click on the launch binder badge then go to the doc folder to find notebooks.

dicrivers's Issues

Question about the plume spreading algorithm

Thanks again for this package. I just experimented a bit and I noticed that the spreading algorithm does produce a 'box-shaped' field away from the coast.

As far as I can tell, the approach is to dilate the original location n times until a predefined box is full.

1. Could the same result be obtained by simply filling the initially defined plume_zoom and then applying the mask? This would be a lot faster I assume

2. If the above would work, we could simply draw a mask using different shapes (e.g. with scikit-image), which might create more 'well behaved' tracer fields (might be more relevant for the spreading of runoff actually).

Or am I missing something important here?

Optional plot feature for 'missed' features.

I think it would be great to have an optional output or plot function, with the rivers that were missed. This way the user can ensure that no relevant rivers were omitted.

Make search for rspread optional?

The current version looks for a column named rspread in the input dataframe here.

I suggest that we make this optional, so that we have a keyword argument make_bgc_river_input(rspread=...). If an integer is passed we used that on each river, if a string is passed that columname will be used (enabeling more flexibility with the input) and if None is passed the river is not spread at all.