raptor831/rfstockalike

rfstockalike's Issues

Inconsistent role for SXT BlackAdder engines

The SXT "BlackAdder" engines are set up with the 0.625m version as type L and the 1.25m version as type O. The historical versions, the Bristol Siddeley Gamma 2 and Gamma 8, are both listed on the linked site as having the same Isp curve: 251 sea level and 265 vacuum.

Changing the 1.25m BlackAdder 8 to type L would be a closer match to the historical engine, and I think it would make it a more useful engine.

Malformed MM selection in Jet_modularEngines

more than one :HAS tag detected, ignoring all but the first: RealFuels-Stockalike/Jet_modularEngines/@part[]:HAS[@module[ModuleEngines]]:HAS[@propellant[LiquidFuel]]:FOR[z_RealFuels_StockEngines]
more than one :HAS tag detected, ignoring all but the first: RealFuels-Stockalike/Jet_modularEngines/@part[]:HAS[@module[ModuleEngines]]:HAS[@propellant[Oxidizer]]:FOR[z_RealFuels_StockEngines]

Malformed MM selection in AJE.cfg

trailing : detected

(apparently refering to @PART[JetEngine,aje_AL-31F]:BEFORE[RealPlume]:NEEDS[AJE]:

Add SELV engines

Bimodal NTRs with in flight switching

The bimodal NTRs like the Atomic Age LANTERN & the LV-N Trimodal have "Switch Engine Mode" and "Toggle Mode" buttons in flight. This can allow more than one active mode at a time. I think there are four total engine modes instead of two.

Screenshots

RCS thrusters not configured properly

The mod sets up RealFuels engine configs on some of the RCS thrusters, but not others:

• The stock "Place-Anywhere 7 Linear RCS Port" is supported, but not the "RV-105"; this is probably due StockAlike_RCS_RF.cfg referencing the latter as "RCSBlock", when (to my limited understanding) that part is deprecated and superseded by "RCSBlock_v2" in stock.

• Of the orbital RCS thrusters from the Near Future Spacecraft mod, only the RX-1, RX-15 and RX-30 are supported, while the RX-15T , RX-45 and RX-55 are not. This is presumably just because corresponding entries haven't been added to the Stockalike_NFSpacecraft.cfg yet.

Add Bluedog Design engines

Errant character in config

[WRN 13:58:01.266] 1 warning related to GameData/RealFuels-Stockalike/fix-part-categories.cfg

There's an errant 'L' a the end of the second config.

Add Cormorant Aeronology

try to debug

cannot edit rocket engine

I already tested RealFuels & ModularFuelTanks

Resizing engine makes craft float

After adding some mods to my game I decided to start a carreermode game. After some time I discovered the swivel engine. So I decided to use it as it was my only liquid fuel engine available.
I only had a 0.625m probe unit. So I resized my fuel tanks and swivel engine accordingly.
Added some wings to get the center of lift lower than the center of mass. And I decided to launch it.
However it didn't launch it just floated in the air.

KSP 1.1.3

Reducing my mods to the following:
FAR 15.7.2
ModuleFlightIntegrator 1.1.6.0
CommunityResourcePack 5.4.0
RealFuels v11.3.1
RealFuels Stockalike 3.2.1
SolverEngines 2.3.0.0
TweakScale 2.2.13.0
ModuleManager 2.6.25 (also tried ModuleManager 2.6.24)

Steps for reproduction:

1. Load Buggedcraft.zip into a save.
2. Try to launch it
3. Release clamps
4. Watch it float mid air

I removed RealFuels stockalike and tried again. No issues occured. Added it again and the craft floated again.

RCS configs don't handle effects properly

The stock RCS now uses ModuleRCSFX, which uses EFFECTS nodes the same way ModuleEnginesFX does. This config:

RFStockalike/GameData/RealFuels-Stockalike/StockAlike_RCS_RF.cfg

Line 11 in 9aa8910

@name = ModuleRCS

converts it back to ModuleRCS but without changing the configs, causing them to always show.

The two stock modules should be compatible except for effects so I don't think RF Stockalike needs to worry about which one is being used

Additional description of the effect of this problem at KSP-RO/RealFuels#163

Change Starshine config to the new methalox thrust scaling

Same as SpaceY, need to get the methalox numbers in line, and really get the engines into the webapp.

Copy Engine name changes from KSP 1.10

In KSP 1.10 they updated a couple of engines with new versions and gave them new names, thus they aren't included in the Stockalike_Squad.cfg file.
The following engines are affected:
24-77 Twitch: smallRadialEngine -> smallRadialEngine_v2
LV-1 Ant: microEngine -> microEngine_v2
LV-1R Spider: radialEngineMini -> radialEngineMini_v2 (for some reason its new .cfg file is in liquidEngineLV-1_v2)
RE-M3 Mainsail: liquidEngine1-2 -> liquidEngineMainsail_v2
RE-I5 Skipper: engineLargeSkipper_125m -> engineLargeSkipper_v2

Note: the same fix has previously been applied to 48-7S Spark, LV-909 Terrier and the RE-L10 Poodle.

Just noticed: Same applies to the RV-105 RCS Block.

The RCS Block and the single RCS port both need the line thrustRating = thrusterPower in the ModuleEngineConfigs so they show the thrusts in VAB

Throttle limits not working

Engines with throttle limits are fully throttleable. One example of this is the LV-T15 from Ven's Stock Revamp (added in my most recent pull request), which has a Min Throttle of 100% at low tech levels.

possible syntax error

[WRN 13:58:01.266] 2 warnings related to GameData/RealFuels-Stockalike/Jet_modularEngines.cfg

I made the following changes with no subsequent errors.

ln1: replace second HAS with comma:
@part[]:HAS[@module[ModuleEngines]],[@propellant[LiquidFuel]]:FOR[z_RealFuels_StockEngines]

ln13: replace second HAS with comma:
@part[]:HAS[@module[ModuleEngines]],[@propellant[Oxidizer]]:FOR[z_RealFuels_StockEngines]

Engine Ignitor support

Hello,

I noticed that a lot of the engines don't have the correct amount of available ignitions according to their type. For example, a lot of Orbital or Upper engines have only one available ignition.

Is this something you can perhaps write a script for? Check for engine type and assign the correct amount of ignitions?

Not exactly the highest priority since no one seems to be complaining yet and Engine Ignitor isn't updated for 0.90.

Add Real Scale Boosters config

Decoupler bag RealFuels-Stockalike

Conflict with RO_RCS_Config.cfg

When loaded these configs give warnings and 2 errors due to changes in RO's RCS system.
RF is forced to install the configs by CKAN.

WRN 20:03:39.584] [ModuleManager] Cannot find key thrusterPower in CONFIG
[ERR 20:03:39.587] [ModuleManager] Error - Cannot parse variable search when replacing (%) key maxThrust = #$thrusterPower$
[WRN 20:03:39.589] [ModuleManager] Cannot find key thrusterPower in CONFIG
[ERR 20:03:39.591] [ModuleManager] Error - Cannot parse variable search when replacing (%) key minThrust = #$thrusterPower$

Fuel_Conversions.cfg errors

With TAC-LS and SDHI installed, at startup Module Manager says:

"ModuleManager: X patches applied, found 3 errors
3 errors related to GameData/RealFuels-Stockalike/Fuel_Conversions.cfg"

Here's what I found in the output log:

[ModuleManager] Error - Cannot parse variable search when editing key volume = #$/RESOURCE[MonoPropellant]/maxAmount$

[ModuleManager] Error - Cannot parse variable search when inserting new key maxAmount = #$/RESOURCE[ElectricCharge]/maxAmount$

[ModuleManager] Error - Cannot parse variable search when inserting new key maxAmount = #$/RESOURCE[MonoPropellant]/maxAmount$ 

Add check for AJE in B9 jet configs

AJE compatibility

Using RF + RF_Stockalike and AJE. AJE's jet engine "J85-GE-4 turbojet" would be override with RF.

Fix KW SPS engine

can not I edit resources bag

I have not been able add htp for rcs

Upper Stages

There are a couple of engines which I will argue should be upper stages, but are currently marked as lowers. I can make the config changes myself and submit a pull request, but I wanted to run them by you first.

Squad

• KR-2L "Rhino": tech description and post-1.0 Isp (255-340s) definitely peg it as an upper stage

KW

• Titan V: The tech description says it can be used as a lower stage so I guess this could be argued either way. The obvious RL equivalent though is the Saturn V second stage which is definitely an upper. Slight complication in that comparison though - SII uses J-2 engines which are gas generator cycle engines and thus will have somewhat lower Isp than the RF stockalike calcs will predict - is that at all worth accounting for?

CryoEngines

• Ct10 "Chelyabinsk": Tech description and extendable nozzle peg it as U+
• CT2X "Tunguska": Low SL Isp pegs it as an upper, not to mention it completes the pattern of one lower and one upper per size in this pack. Not sure about U vs U+ though.
• Ct5 "Yucatan": Tech description and Isp make this solidly an upper.

Tantares new release, possible incompatibility

Just a heads up, Tantares 15.5 comes with its own set of Real Fuels configs and it's conflicting with the ones included in Stockalike. Not sure if you want to deprecate these or integrate the new ones.

Add tagging to all configs

Add a "tag" to each config that will identify the part as edited by RF and/or Stockalike. This will help with potential mod conflicts, such as the one here: KSP-RO/RealFuels#98

Add Launchers Pack support

Link to form thread: http://forum.kerbalspaceprogram.com/index.php?/topic/71323-112-launchers-pack-spacex-v23-atlas-v-is-back-up/&page=1

Stockalike_SpaceY.cfg needs updating

As per KSP-RO/RealFuels#98 (comment),
looks like https://github.com/Raptor831/RFStockalike/blob/master/GameData/RealFuels-Stockalike/Stockalike_SpaceY.cfg uses wrong type - ModuleEngines - instead of ModuleEnginesRF, like every other config does.

As a result,. for those engines, ullage and ignition limiting does not function.

Downloads for v3.2.5.4 and v3.2.6 are empty

Both of these versions are 176 bytes, containing only a directory called RFStockalike and no files.

• https://github.com/Raptor831/RFStockalike/releases/download/v3.2.6/RFStockalike--v3.2.6-33.zip
• https://github.com/Raptor831/RFStockalike/releases/download/v3.2.5.4/RFStockalikeRFStockalike--v3.2.5.4-32.zip

Atomic Age engines missing

Atomic Age is missing it's atmos-breathing engine and the small RTG-derivative engine. There are also radiators that were recently added to the pack but I don't think that the fuel configs concern themselves about those.

Fix NFSpacecraft configs

Hey @Raptor831 ,

Not sure if you're aware of this issue or not, but the engines implemented by NFSpacecraft [LV-T95, LV-T95-8, and LV-T18] were deprecated back in v0.6.1. The new engines, therefore, do not have RL fuel mixtures; they just run on Monopropellant now.

I'm not very knowledgeable about real engine configs; however, I will try my best (and probably submit a PR later). If I make a fool of myself in making real configs for those engines, please point that out to me.

Thanks in advance.

Config app only accepts whole numbers

I apologize if this is the wrong place for this.

The RFStockalike config app won't accept values with decimals for mass and thrust. Is this intended? It makes diversifying RCS thrusters somewhat difficult. And it would be nice to have for larger engines if only for the ability to fine-tune TWR.

Change SpaceY engines to new Methalox thrust

Need to update the SpaceY methalox configs to the 95% thrust. This is in line with the rest of the new configs, now that methalox has a proper thrust scaling factor (like hydrolox does).

KSPI - Possibly remove configs in favor of FreeThinkers

This was brought up, so we can discuss it here.

I was not under the impression that FreeThinker's configs would interfere with the engines (since Northstar1989 has been very vocal if I goof anything up with KSPI). But I certainly could be wrong...

Update Tantares configs