Giter Site home page Giter Site logo

Comments (10)

rf152 avatar rf152 commented on July 29, 2024

From a quick look in the linked document, this would require a re-writing the code to apply the lens shading to the mmal capture object (see the section 2.5 Change the Raspistill.c file)

I don't have an arducam lens, and cannot test this. If you want to create a pull request to add this functionality then feel free.

from raspindi.

IrPgFKS0 avatar IrPgFKS0 commented on July 29, 2024

I don’t know much about C, but I followed the linked instructions for my arducam camera and it worked like a charm for “raspistill”, so maybe I will take a stab at it.

Do you know what “.c” object I would need to edit (just main.cpp?) and would that be configurable for other lens, otherwise this change would really be pointless?

from raspindi.

rf152 avatar rf152 commented on July 29, 2024

The whole program is in main.cpp, so that's the file you'd need, yes.

The MMAL configuration is set between lines 440 and 485, so it would make most sense probably to put the configuration below that. If you want to have a config file option then you will need to add some logic to pull that out (see line 328 for an example of reading a config value).

from raspindi.

IrPgFKS0 avatar IrPgFKS0 commented on July 29, 2024

Thank you

from raspindi.

yomebzh avatar yomebzh commented on July 29, 2024

Hello, if you have found the solution, I am interested
thank you

from raspindi.

github-actions avatar github-actions commented on July 29, 2024

No update to this issue for 30 days. Closing

from raspindi.

IrPgFKS0 avatar IrPgFKS0 commented on July 29, 2024

I just wanted to post here for other people that may have this question, that I did end up solving this issue. Thanks to Jörn Nettingsmeier for the idea, I made another fork which allows you to simply apply the --tuning-file command directly to the raspindi binary and this for my Arducam worked perfectly...

https://github.com/IrPgFKS0/raspindi

Example:
/opt/raspindi/bin/raspindi -t 0 --width 1920 --height 1080 --tuning-file imx477_original.json --codec yuv420 --framerate 25

from raspindi.

rf152 avatar rf152 commented on July 29, 2024

There's some interesting work you've done. I'll try to have a proper look, and see if I can come up with a way of making it backward compatible with the config file format, and merge it into the main repo, if you're ok with that?

from raspindi.

IrPgFKS0 avatar IrPgFKS0 commented on July 29, 2024

Yes, I am fine either way. I mostly just wanted to post this solution so anyone could fix that shading issue (drove me nuts)! Also the native libraries do support a config file flag so maybe that could be merged together with raspindi's config file.

rpicam-vid -h

-c [ --config ] [=arg(=config.txt)] Read the options from a file. If no filename is specified, default to
config.txt. In case of duplicate options, the ones provided on the command line
will be used. Note that the config file must only contain the long form
options.

from raspindi.

github-actions avatar github-actions commented on July 29, 2024

No update to this issue for 30 days. Closing

from raspindi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.