raveren/php-arr

powerful PHP5 array manipulation

php-arr's Issues

Arr::unshift() does not move the inserted value to the top if the key was already present.

I assumed that Arr::unshift() would return the array with the inserted key at the beginning, but if the key was already present it stays at the same position it was.

The following version of the function moves the key (and the new value) to the top.
It's also very simple and takes half the time to execute (I think it only copies the array once while the original version does it twice with array_reverse), but you have to be handling an awful lot of data to notice that.

function MyArrayUnshift(array & $array, $key, $val) {
  return [$key => $val] + $array;
}

( $countries taken from: https://gist.github.com/DHS/1340150#gistcomment-1244239 )

d(Arr::unshift($countries, 'AQ', 'Antarctica'));
d(MyArrayUnshift($countries, 'AQ', 'Antarctica'));

d(microtime());
for($a=1;$a<10000000;$a++) Arr::unshift($countries, 'AQ', 'Antarctica');
d(microtime()); --> 50 seconds
for($a=1;$a<10000000;$a++) MyArrayUnshift($countries, 'AQ', 'Antarctica');
d(microtime()); --> 27 seconds