raviraa/browser-refresh

atom editor browser refresh plugin

browser-refresh's Issues

Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.

Atom.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app/src/atom.js:54:11)
Object.activate (/Users/alfbrand2/.atom/packages/browser-refresh/lib/browser-refresh.coffee:18:9)

Failed to load the browser-refresh package

browser-refresh throws a stack trace every time I launch atom.

Steps to reproduce:

1. Launch atom

Atom Version: 0.196.0 ⚠️ in 1.0 API Preview Mode ⚠️
System: Mac OS X 10.10.3
Thrown From: browser-refresh package, v0.8.3

Stack Trace

Failed to load the browser-refresh package

At Cannot read property 'prototype' of undefined

TypeError: Cannot read property 'prototype' of undefined
    at __extends (/Users/kulin/.atom/packages/browser-refresh/lib/status-view.coffee:4:199)
    at /Users/kulin/.atom/packages/browser-refresh/lib/status-view.coffee:9:5
    at Object.<anonymous> (/Users/kulin/.atom/packages/browser-refresh/lib/status-view.coffee:38:5)
    at Object.<anonymous> (/Users/kulin/.atom/packages/browser-refresh/lib/status-view.coffee:40:4)
    at Module._compile (module.js:452:26)
    at Object.requireCoffeeScript (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/coffee-cash/lib/coffee-cash.js:85:19)
    at Module.load (module.js:347:32)
    at Function.Module._load (module.js:302:12)
    at Module.require (module.js:357:17)
    at require (module.js:376:17)

Commands

Config

{
  "core": {
    "disabledPackages": [
      "term2"
    ],
    "themes": [
      "seti-ui",
      "base16-tomorrow-dark-theme"
    ]
  },
  "browser-refresh": {
    "safari": true,
    "saveFilesBeforeRefresh": true,
    "googleChrome": false
  }
}

Installed Packages

# User
angularjs, v0.1.0
atom-color-highlight, v3.0.9
atom-terminal, v0.7.0
autocomplete-plus, v2.12.1
browser-refresh, v0.8.3
emmet, v2.3.8
file-icons, v1.5.5
git-tab-status, v1.7.0
go-plus, v3.3.10
language-haskell, v1.0.0
linter, v0.12.1
project-palette-finder, v2.4.17
seti-ui, v0.7.1

# Dev
No dev packages

Deprecated Atom APIs will be removed June 1st

Atom will no longer load this package after June 1st without changes. There are a couple deprecations on the latest version (0.8.3) of this package:

1. Requiring View from atom is no longer supported. Please require atom-space-pen-views instead: {View} = require 'atom-space-pen-views' Add "atom-space-pen-views": "^2.0.3" to your package dependencies.
2. Store package style sheets in the styles/ directory instead of stylesheets/ in the <pack-name> package
3. atom.workspaceView is no longer available. In most cases you will not need the view. See the Workspace docs for alternatives: https://atom.io/docs/api/latest/Workspace. If you do need the view, please use atom.views.getView(atom.workspace), which returns an HTMLElement.
4. Use a config schema instead. See the configuration section of https://atom.io/docs/latest/hacking-atom-package-word-count and https://atom.io/docs/api/latest/Config for more details

Visit https://gist.github.com/benogle/6d09e295c84b717ef9b4 and search for your package name to see up-to-date deprecations.

If this package has been replaced by another package or functionality in core, please reply with this information.

See atom/atom#6867 for more info. Thanks!

activate browser

The sublime package has an "activate_browser": true option.

Is this intended to be supported for this atom package?

Object.Object.defineProperty.get is deprecated.

Requiring View from atom is no longer supported.
Please require atom-space-pen-views instead:
{View} = require 'atom-space-pen-views'
Add "atom-space-pen-views": "^2.0.3" to your package dependencies.

Object.Object.defineProperty.get (C:\Users\Mike\AppData\Local\atom\app-0.201.0\resources\app.asar\exports\atom.js:66:11)
Object.<anonymous> (C:\Users\Mike\.atom\packages\browser-refresh\lib\status-view.coffee:1:1)
Object.<anonymous> (C:\Users\Mike\.atom\packages\browser-refresh\lib\status-view.coffee:40:4)
Module._compile (module.js:452:26)
Object.requireCoffeeScript (C:\Users\Mike\AppData\Local\atom\app-0.201.0\resources\app.asar\node_modules\coffee-cash\lib\coffee-cash.js:85:19)
Module.load (module.js:347:32)

Uncaught Error: Can't save buffer with no file path

I'm using coffee-compile which shows the current coffeescript file compiled in another pane. Browser refresh throws the following error on trigger:

Uncaught Error: Can't save buffer with no file path
/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:759

I suppose this is because coffee-compile's pane doesn't hold an actual file, only a temporary buffer. It happens even though that pane is not in focus.

Would it be possible to prevent this somehow? I'll also let the author of coffee-compile know about it.

Permission error on OSx Mojave

Since updating my Macbook to Mojave, I have been getting this permission error I am unsure how to fix.

Use the `atom-workspace` tag instead of the `workspace` class.

In keymaps/browser-refresh.cson: Use the atom-workspace tag instead of the workspace class.

Package.activateConfig is deprecated.

Use a config schema instead. See the configuration section
of https://atom.io/docs/latest/hacking-atom-package-word-count and
https://atom.io/docs/api/latest/Config for more details

Package.activateConfig (C:\Users\Mike\AppData\Local\atom\app-0.201.0\resources\app.asar\src\package.js:263:11)
Package.activateNow (C:\Users\Mike\AppData\Local\atom\app-0.201.0\resources\app.asar\src\package.js:234:14)
<unknown> (C:\Users\Mike\AppData\Local\atom\app-0.201.0\resources\app.asar\src\package.js:219:30)
Package.measure (C:\Users\Mike\AppData\Local\atom\app-0.201.0\resources\app.asar\src\package.js:163:15)
Package.activate (C:\Users\Mike\AppData\Local\atom\app-0.201.0\resources\app.asar\src\package.js:211:14)
PackageManager.activatePackage (C:\Users\Mike\AppData\Local\atom\app-0.201.0\resources\app.asar\src\package-manager.js:435:21)

Window version

Will this has window version in future?
Then it will be perfect

Safari Background Refresh?

I had configured Sublime to refresh Safari in background, without focusing on Safari. Doesn't seem that's possible with this package. Is this possible to implement?

Refresh delay option

Something I used often in the Sublime plugin was the delay option. When uploading files to remote servers this option comes in handy to allow file transfers to complete prior to refreshing the browser.

Use the selector `atom-panel.modal` instead of the `overlay` class.

In stylesheets/browser-refresh.less: Use the selector atom-panel.modal instead of the overlay class.

Error when trying to save (yosemite)

Uncaught NotFoundError: Failed to execute 'appendChild' on 'Node': The node to be removed is no longer a child of this node. Perhaps it was moved in a 'blur' event handler?

Bug with visual indicator for "file modified"

Hi, thanks for the amazing package. It really saves that extra annoying step and makes me more productive.

I found out that, when saving, the visual cue (located next to the tab name) indicating that the file was modified doesn't go away.

Do you think this can be fixed?

Thank you.

Save files before refresh saves all open files

Save Files Before Refresh saves all open files before refreshing. It would be great to have an option to save only the active file/tab before refreshing. Many times I don't want to save every file I have open, just the one I'm working on.

Unsupported Platform

Upon downloading the package and attempting to run while having a project open, as I am viewing a working HTML file (which invokes two javascript files), it yields the error "Unsupported Platform" within Atom and does not refresh chrome.

Browser: Chrome

Operating System: Windows 8.1

Refresh the active page

When press F5 the plugin refresh the active page on Chrome, not the modified page. Idem with Safari and Firefox

Package.getStylesheetsPath is deprecated.

Store package style sheets in the styles/ directory instead of stylesheets/ in the browser-refresh package

Package.getStylesheetsPath (/usr/share/atom/resources/app.asar/src/package.js:430:9)
Package.getStylesheetPaths (/usr/share/atom/resources/app.asar/src/package.js:441:32)
Package.loadStylesheets (/usr/share/atom/resources/app.asar/src/package.js:423:38)
<unknown> (/usr/share/atom/resources/app.asar/src/package.js:167:19)