ravisumit33/mysterio

Anonymous chat web app

mysterio's Issues

Remove dependency on global eslint

Branch: dev

Currently, we have to install eslint globally

npm install -g eslint

for pre-commit to run eslint.

This is because pre-commit hooks are run at root directory and we don't have node_modules folder at root.
It is inside frontend directory. We should remove dependency on global eslint and find an alternative way to run the hook with local eslint.

ESLint runs on whole repo instead of staged files in pre-commit hook

Currently, ESLint runs on whole repo while commiting. This happens because eslint lint is run using following command:
npm run --silent lint due to limitations considered in #15. We also cannot use pass_filenames=true directly in .pre-commit-config.yaml because it passes path relative to root folder but we need paths relative to frontend folder.

We have to somehow use pass_filenames=true with file paths resolving relative to frontend folder so that linting happens only on files to be commited.

Wrong server address

Mysterio/frontend/src/stores/ChatWindowStore/socket.js

Line 15 in 42d528b

this.socket = new ReconnectingWebSocket(`ws://${SERVER_ADD}:8000/ws/chat${groupChatURL}`);

@nileshvaishnav Don't you think adding 8000 will create problem in production ?