Where was the bug located
Bug Description
The release binaries contain all of the parent directories instead of just the relevant directory.
Steps to Reproduce (for bugs)
Download
- Download Release 1.0.4 - linux-x64.tar
- Unzip linux-x64.tar
Roll your own
git clone https://github.com/rbaker26/SAP1EMU.git
cd SAP1EMU/SAP1EMU.Engine-CLI/
make
The compressed outputs should be at:
SAP1EMU/SAP1EMU.Engine-CLI/bin/Release/netcoreapp3.1/publish/output
Note how the unzipped directory contains a bunch of parent directories instead of just the files at the target directory.
cd SAP1EMU/SAP1EMU.Engine-CLI/bin/Release/netcoreapp3.1/publish/output
tar -xf linux-x64.tar
cd SAP1EMU.Engine-CLI
ls -l
total 0
drwxrwxrwx 1 rbaker rbaker 4096 Apr 28 11:59 bin
cd bin
ls -l
total 0
drwxrwxrwx 1 rbaker rbaker 4096 Apr 28 11:59 Release
# etc etc
Expected Behavior
When unzipped, the resulting folder should only contain the contents of linux-x64.
For example:
tar -xf linux-x64.tar
cd linux-x64
ls -l
total 364
-rwxrwxrwx 1 rbaker rbaker 204800 Jan 1 19:01 CommandLine.dll
-rwxrwxrwx 1 rbaker rbaker 7168 Apr 22 10:19 SAP1EMU.Assembler.dll
-rwxrwxrwx 1 rbaker rbaker 1676 Apr 22 10:19 SAP1EMU.Assembler.pdb
-rwxrwxrwx 1 rbaker rbaker 6656 Apr 22 10:19 SAP1EMU.Engine.dll
-rwxrwxrwx 1 rbaker rbaker 1612 Apr 22 10:19 SAP1EMU.Engine.pdb
-rwxrwxrwx 1 rbaker rbaker 19456 Apr 22 10:19 SAP1EMU.Lib.dll
-rwxrwxrwx 1 rbaker rbaker 7932 Apr 22 10:19 SAP1EMU.Lib.pdb
-rwxrwxrwx 1 rbaker rbaker 86424 Apr 22 10:19 SAP1Emu
-rwxrwxrwx 1 rbaker rbaker 1950 Apr 22 10:19 SAP1Emu.deps.json
-rwxrwxrwx 1 rbaker rbaker 14336 Apr 22 10:19 SAP1Emu.dll
-rwxrwxrwx 1 rbaker rbaker 2952 Apr 22 10:19 SAP1Emu.pdb
-rwxrwxrwx 1 rbaker rbaker 146 Apr 22 10:19 SAP1Emu.runtimeconfig.json
Current Behavior
Currently, the unzipped folder contains:
linux-x64/SAP1EMU.Engine-CLI/bin/Release/netcoreapp3.1/publish/linux-x64/the_target_files
instead of
linux-x64/the_target_files
Possible Solution
The Makefile needs to be adjusted to ensure the extra directories do not get included.
Screenshots (If applicable)
This is a screenshot of the win10-x64, but it has the same nested directory behavior.
Note the URI box at the top of the window.
Context
Creates unnecessary work for the user.
Your Environment
- Version used: 1.0.4
- Operating System and version (desktop or mobile): Window 10 - 10.0.19041 Build 19041
- Operating System and version (desktop or mobile): Ubuntu 18.04.4 LTS - WSL2 - HyperV UltraThin