rcaputo/dzp-changelogfromgit

Dist::Zilla plugin to generate changelogs from git commits

dzp-changelogfromgit's Issues

Mojibake in generated Changes files

This issue was originally created in RT 9 years ago.

I copying the original comments here:

My name is « Olivier Mengué », not « Olivier Mengué ».
Examples of failures:
https://metacpan.org/source/BINGOS/Dist-Zilla-Plugin-GithubMeta-0.54/Changes#L1
https://metacpan.org/source/GETTY/Dist-Zilla-Plugin-TravisCI-0.008/Changes#L1
https://metacpan.org/source/APOCAL/Dist-Zilla-Plugin-MinimumPerl-1.006/CommitLog#L1

It seems that DZP::ChangelogFromGit has a double encoding problem.

It appears as if the content from git is being fetched as a sequence of utf8-encoded bytes, so the thing to do here is to pass encoding => 'bytes' to Dist::Zilla::File::InMemory's constructor so it is not encoded again.

However, Git::Repository probably should be returning data in (decoded) characters... I'm not sure how complicated this would be. Git::Wrapper is getting Unicode things right now, but it's been a struggle to make it work everywhere (i.e. Windows).

Probably the ticket in RT should be closed first.

Undef value during substituition

During my distribution build with Dist::Zilla, I'm getting the following warnings:

[DZ] beginning to build Linux-Info
Use of uninitialized value $1 in substitution iterator at /home/alceu/perl5/perlbrew/perls/perl-5.38.2/lib/site_perl/5.38.2/Dist/Zilla/Plugin/ChangelogFromGit/Debian.pm line 89.
Use of uninitialized value $1 in substitution iterator at /home/alceu/perl5/perlbrew/perls/perl-5.38.2/lib/site_perl/5.38.2/Dist/Zilla/Plugin/ChangelogFromGit/Debian.pm line 89.
Use of uninitialized value $1 in substitution iterator at /home/alceu/perl5/perlbrew/perls/perl-5.38.2/lib/site_perl/5.38.2/Dist/Zilla/Plugin/ChangelogFromGit/Debian.pm line 89.
Use of uninitialized value $1 in substitution iterator at /home/alceu/perl5/perlbrew/perls/perl-5.38.2/lib/site_perl/5.38.2/Dist/Zilla/Plugin/ChangelogFromGit/Debian.pm line 89.
Use of uninitialized value $1 in substitution iterator at /home/alceu/perl5/perlbrew/perls/perl-5.38.2/lib/site_perl/5.38.2/Dist/Zilla/Plugin/ChangelogFromGit/Debian.pm line 89.
Use of uninitialized value $1 in substitution iterator at /home/alceu/perl5/perlbrew/perls/perl-5.38.2/lib/site_perl/5.38.2/Dist/Zilla/Plugin/ChangelogFromGit/Debian.pm line 89.
Use of uninitialized value $1 in substitution iterator at /home/alceu/perl5/perlbrew/perls/perl-5.38.2/lib/site_perl/5.38.2/Dist/Zilla/Plugin/ChangelogFromGit/Debian.pm line 89.
Use of uninitialized value $1 in substitution iterator at /home/alceu/perl5/perlbrew/perls/perl-5.38.2/lib/site_perl/5.38.2/Dist/Zilla/Plugin/ChangelogFromGit/Debian.pm line 89.
Use of uninitialized value $1 in substitution iterator at /home/alceu/perl5/perlbrew/perls/perl-5.38.2/lib/site_perl/5.38.2/Dist/Zilla/Plugin/ChangelogFromGit/Debian.pm line 89.
[DZ] guessing dist's main_module is lib/Linux/Info.pm

It seems everything works after that.

I running version 0.017 of Dist::Zilla::Plugin::ChangelogFromGit.

Wrong characters encoding

Hi,
I'm not sure that is a bug of your module, probably the bug is related to Git::Repository::Plugin::Log.

For this message:

il codice 5.0.1 anziché 5.1.1

on my CHANGES I have:

il codice 5.0.1 anziché 5.1.1.

With this little patch the problem seem disappeared:

--- ChangelogFromGit.pm.orig    2018-01-25 11:13:37.569513561 +0100
+++ ChangelogFromGit.pm 2018-01-25 11:34:07.442426985 +0100
@@ -14,6 +14,7 @@
 
 use DateTime;
 use DateTime::Infinite;
+use Encode qw(decode);
 use Software::Release;
 use Software::Release::Change;
 use Git::Repository::Log::Iterator;
@@ -224,7 +225,7 @@
                                                committer_email => $log->committer_email,
                                                committer_name  => $log->committer_name,
                                                date            => $commit_date,
-                                               description     => $log->message
+                                               description     => decode('UTF-8', $log->message),
                                        )
                                );
                        };

Thank you in advance,
Emanuele