Giter Site home page Giter Site logo

Comments (7)

zacharyrs avatar zacharyrs commented on July 21, 2024

Unfortunately this is breaking cross compatibility with mmtf-python, which by default dumps everything as 64bit floats (doubles).
The msgpack-python implementation doesn't support packing a particular field (the transforms) as 64bit floats, and everything else as 32bit floats - see here.

from mmtf-java.

zacharyrs avatar zacharyrs commented on July 21, 2024

I have a partial workaround, by making mmtf-python follow the same decisions as here (all 32bit except the transforms list) - rcsb/mmtf-python#50.

from mmtf-java.

josemduarte avatar josemduarte commented on July 21, 2024

Good catch @zacharyrs ! Thanks for the detailed report.

Changing the RCSB mmtf files is doable but as you say may cause quite some trouble. I like your python workaround as a solution. However, to be consistent the spec would have to officially acknowledge that ncsOperList uses doubles, right?

One important note. MMTF is now is in minimal maintenance mode. The preferred compressed format for PDB data is BinaryCIF.

from mmtf-java.

zacharyrs avatar zacharyrs commented on July 21, 2024

Thanks @josemduarte!

Yes, the python solution basically just means both implementations violate the specification in the same way. It avoids the hassle of breaking things.

I didn't realise mmtf had been dropped to maintenance... I assume BinaryCIF follows the CIF spec, it's just encoded?

I recall CIF not caring about bond information, which was what I liked about mmtf - I guess I'll have to read into it more.

from mmtf-java.

josemduarte avatar josemduarte commented on July 21, 2024

I assume BinaryCIF follows the CIF spec, it's just encoded?

Yes, that's correct

I recall CIF not caring about bond information, which was what I liked about mmtf - I guess I'll have to read into it more.

Bond information is available but indirectly via the chemical component dictionary

from mmtf-java.

zacharyrs avatar zacharyrs commented on July 21, 2024

Bond information is available but indirectly via the chemical component dictionary

Is that guaranteed for all molecules or is it optional?

from mmtf-java.

josemduarte avatar josemduarte commented on July 21, 2024

The chemical component dictionary contains all intra-residue bond information. But it is not embedded within the structure BCIF files. We will consider offering the whole chemical component dictionary as one BCIF bundle that should make it more convenient to use.

from mmtf-java.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.