rdbende/flake8-tkinter

A flake8 plugin that helps you write better Tkinter code

Hello, I'm rdbende 👋

• 🐍 Most of the time I'm programming in Python. I like making GUIs with GTK4 and sometimes with Tkinter.
• 😻 You might wanna check out my themes for Tkinter. The Sun Valley ttk theme can even make it look like Windows 11!
• 🦀 Lately I've been into GUI development using gtk-rs
• 🎹 I'm also interested in sound engineering, synths and electronic music, you can find some related projects on my profile
• 🐧 My distro of choice is Fedora Silverblue 👣
• 🐘 If you're interested in what I'm working on at the moment, check out my Mastodon profile
• 📫 Feel free to contact me via email, or chat with me on Matrix

flake8-tkinter's Issues

Multiple assignment and tuple unpacking issues

Looks insane, but should work

import tkinter as tk
import time


root = window, btn = tk.Tk(), tk.Button(command=time.sleep(1))


btn.mainloop()

tag_bind + statement with body in loop

flake8 --select=TK emits no errors for this:

import tkinter

text = tkinter.Text()
for lel in range(500):
    if True:
        text.tag_bind("foo" + str(lel), print)

I don't like all the checks being classes anymore

At first it seemed a good idea to split each check into a separate class, but now it led to a lot of boilerplate code.

AttributeError: 'Attribute' object has no attribute 'id'

flake8-tkinter v0.1.2, Python 3.8

During check of the following code, it throws an exception:

import tkinter as tk

root = tk.Tk()


def func():
    a.b.c


bar=tk.Button(root, text="some text", command=func)
bar.pack(side=tk.TOP, fill=tk.X)

root.mainloop()

Error:

❯ flake8 bug.py
Traceback (most recent call last):
  File "/home/insolor/.local/bin/flake8", line 8, in <module>
    sys.exit(main())
  File "/home/insolor/.local/lib/python3.8/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "/home/insolor/.local/lib/python3.8/site-packages/flake8/main/application.py", line 360, in run
    self._run(argv)
  File "/home/insolor/.local/lib/python3.8/site-packages/flake8/main/application.py", line 348, in _run
    self.run_checks()
  File "/home/insolor/.local/lib/python3.8/site-packages/flake8/main/application.py", line 262, in run_checks
    self.file_checker_manager.run()
  File "/home/insolor/.local/lib/python3.8/site-packages/flake8/checker.py", line 325, in run
    self.run_serial()
  File "/home/insolor/.local/lib/python3.8/site-packages/flake8/checker.py", line 309, in run_serial
    checker.run_checks()
  File "/home/insolor/.local/lib/python3.8/site-packages/flake8/checker.py", line 589, in run_checks
    self.run_ast_checks()
  File "/home/insolor/.local/lib/python3.8/site-packages/flake8/checker.py", line 496, in run_ast_checks
    for (line_number, offset, text, _) in runner:
  File "/home/insolor/.local/lib/python3.8/site-packages/flake8_tkinter.py", line 172, in run
    visitor.visit(self.tree)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
    self.visit(item)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/home/insolor/.local/lib/python3.8/site-packages/flake8_tkinter.py", line 148, in visit_FunctionDef
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
    self.visit(item)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
    self.visit(value)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/home/insolor/.local/lib/python3.8/site-packages/flake8_tkinter.py", line 151, in visit_Attribute
    if node.value.id == data_dict.get("tkinter_imported_as") and node.attr in {
AttributeError: 'Attribute' object has no attribute 'id'

Better warning messages

I don't want to write a complete novel for every check, but a little explanation would be helpful for those who don't understand why their code is bad.

Also the current messages are really inconsistent in wording.

Better ordering for rules

For example, add=True and tag_bind in loop are in the "Best practices" section. They should be in "Common mistakes"

Keep track of tkinter widgets?

Currently flake8-tkinter assumes that only tkinter widgets can have methods like config, bind or mainloop.

For things like w.update or w["blah"] this won't be enough, because we don't want to warn on a dictionary update, or subscript for example.