rdegges/cryptocompare

A static website that compares cryptocurrency prices for popular currencies.

Hey, I'm Randall!

It's great to meet you. I'm a long-time software developer, speaker, author, and entrepreneur.

• 🛠️ I’m currently working at Snyk leading Developer & Security Relations
• 📫 How to reach me: [email protected] (personal) || [email protected] (work)
• 💻 You can see what I've written about on my personal website

cryptocompare's Issues

CryptoCompare API closed

They recommend to use https://min-api.cryptocompare.com/ but no Image inside :(

https://www.cryptocompare.com/api/#

DUE TO ABUSIVE USAGE, IF YOU WANT YOUR CLIENTS TO DIRECTLY USE OUR APIS, USE THE MIN-API PATH. (THE HEADER Access-Control-Allow-Origin: * is only set on min-api paths)

Demo site has cross-origin denied doesn't work when pulled either.

Replicate:
Go to https://scotch-io.github.io/cryptocompare
Look at console.

Doesn't work!

Would anyone know what happened with this project?

Coin with no ImageUrl results in undefined error

When calling getCoinImage: function(symbol) {} it will return an undefined error when it try to find an image for a coin with no ImageUrl in the cryptocompare API, which breaks the app.

I fixed it with

 try {

          return CRYPTOCOMPARE_URI + this.coinData[symbol].ImageUrl

        } catch(err) {
            console.log(err)
        }

Add Euro Curency

Hello,

Thanks for this awesome project ! Do you think you could add an other column with Euro currency ?
Or Do you know how can I change the USD by an other currency ?

Regards !

TypeError: Cannot read property 'ImageUrl' of undefined

@rdegges
Hello, when I updated coinmarket cap v1 to v2 on line 54 in the app.js file, it threw up this message
"TypeError: Cannot read property 'ImageUrl' of undefined"
On looking further, the coinmarketcap data has been changed from an array to an object.

CORS error when trying to access cryptocompare api

That is what the console log shows after loading https://scotch-io.github.io/cryptocompare/

bootstrap.min.css:1 Failed to load resource: the server responded with a status of 404 ()
scotch-io.github.io/:1 Failed to load https://www.cryptocompare.com/api/data/coinlist: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://scotch-io.github.io' is therefore not allowed access.

I am on Chrome 66.

Coin prices not displaying

I've cloned the code from the repository and when launching the browser the coin image urls display but the coin pricing data does not display. Any ideas? Here is a screenshot. https://prnt.sc/k518ii