Material UI multiple checkboxes not working properly

[react-hook-form]

Material UI multiple checkboxes not working properly

[bluebill1049]

you are right @hbarcelos i will adjust the code soon 👍

[bluebill1049]

fork and submit a PR would be perfect :)

[bluebill1049]

ah cool! Whenever you are free man no pressure. Sorry tagged you twice 😅

[bluebill1049]

I will take a look at this soon :)

[hbarcelos]

I think I've found the problem here:
https://github.com/react-hook-form/react-hook-form-input/blob/master/src/index.tsx#L6

This line:

return target ? (isCheckbox ? target.checked : target.value) : target;

If we have a checkbox, it always returns the checked properties, regardless value is set or not.

To be consistent with the way react-hook-form works, it should return a value based on the following algorithm:

If `checked` is `false`:
  Then return `false`
Else if `checked` is `true`
  If `value` is non-empty
    Then return `value`
  Else
    Then return `true`

I've updated the linked sandbox to demonstrate this.

[bluebill1049]

actually you interested to contribute? you already know the solution :)

[hbarcelos]

Sure. How can I do that? Should I fork and submit a PR or would you give me some permissions for this repo?

[jtoliver]

Anything new on this. I took a stab at it today with no success. I'm trying to do grouped checkboxes with same name.

[bluebill1049]

@jtoliver i believe @hbarcelos is looking into this.
@hbarcelos any update on this PR? I am happy to take a look this over the weekend tho.

[hbarcelos]

@bluebill1049 sorry for the delay... Busy week. I'll have some time during the weekend.
It is quite an easy fix to do, but I would want to add some regression tests as well, so this could take a little bit longer than editing 1 or 2 lines.

[bluebill1049]

awesome! thanks @hbarcelos

[bluebill1049]

hey @hbarcelos, wondering if any update on this issue?

[bluebill1049]

going to close this issue for now, unless someone encounter similar problem.

[hbarcelos]

Hey, I'm sorry... This has being a pretty busy end of year for me. I'll try to work on this before x-mas though.