Doesn't unregister fields

[GProst]

Doesn't unregister fields

[bluebill1049]

sorry i know why now!

[bluebill1049]

I will test more on this feature today and get a proper fix. Idea is you don’t need to pass unregistef let register return it

[GProst]

@bluebill1049 I'm afraid this didn't fix it =(
Unfortunately, having problem of updating react-hook-form version in the Sandbox above but locally in my project it still doesn't unregister fields for me... Double-checked that version is 3.28.5, removed/installed node_modules from scratch just in case - didn't help

[bluebill1049]

oh really? what's register return?

[bluebill1049]

still return undefined?

[GProst]

@bluebill1049

ƒ () {
    return unregister(name);
}

but the fields are still passed to the onSubmit handler...

[bluebill1049]

    if (validationOptions && isString(validationOptions.name)) {
      registerIntoFieldsRef(
        { name: validationOptions.name },
        validationOptions,
      );
      return () => unregister(name);
    }

[bluebill1049]

code i have in RHF

[GProst]

@bluebill1049 no worries!

[bluebill1049]

try this beta: [email protected]
i will do proper fix today

[GProst]

@bluebill1049 I'm not sure why but some of my inputs stopped updating values at all, like I'm typing and nothings fills. I see that handleChange method is invoked, name seems to be correct and data too but the value is undefined anyway during the next render.
Interestingly that this happens to some fields, not sure I understand how they are different...

[email protected]

I was talking about handleChange in RHFInput

[GProst]

Perhaps this is something on my side, trying to debug, but all I did was updating a lib

[GProst]

Reverted to 3.28.5 and fields started to work again.

@bluebill1049 I found why some fields work okay and some don't work.
Fields work normally if they don't have default values provided to useForm (3.28.6-beta.1)

[bluebill1049]

looks like this version works: https://codesandbox.io/s/react-hook-form-field-array-advanced-with-delete-insert-append-edit-l19pz

[GProst]

@bluebill1049
If you set some default values to useForm you won't be able to update a field:
https://codesandbox.io/s/react-hook-form-field-array-advanced-with-delete-insert-append-edit-oh0jl

[bluebill1049]

ok i see

[bluebill1049]

working one: https://codesandbox.io/s/react-hook-form-field-array-advanced-with-delete-insert-append-edit-to-delete-elloq
i will have publish both libs :)

[bluebill1049]

https://codesandbox.io/s/react-hook-form-field-array-advanced-with-delete-insert-append-edit-l19pz works now going to publish both FYI