Giter Site home page Giter Site logo

Comments (20)

bluebill1049 avatar bluebill1049 commented on July 19, 2024 3

thanks a lot for your contribution. too many things in my hands it's so good to have people willing to help :) (RHF team members are helpful too) @kotarella1110 @JeromeDeLeon ❤️

from input.

bluebill1049 avatar bluebill1049 commented on July 19, 2024 1

thanks a lot @GProst much appreciated

from input.

bluebill1049 avatar bluebill1049 commented on July 19, 2024 1

1.0.14-beta.1 plz help test this out.

from input.

bluebill1049 avatar bluebill1049 commented on July 19, 2024

hmmm maybe we should remove rules in the dep

from input.

GProst avatar GProst commented on July 19, 2024

@bluebill1049 yeah, I thought the same

from input.

GProst avatar GProst commented on July 19, 2024

@bluebill1049 will it be simpler to not provide deps there at all and unregister only on unmount? If a user wants to unregister when name is changed or smth else is changed they can just manage it via key prop.

from input.

bluebill1049 avatar bluebill1049 commented on July 19, 2024

yea let's do that, you want to send a PR for this? I am trying to fix a bug for react native with this component.

from input.

GProst avatar GProst commented on July 19, 2024

@bluebill1049 of course!

from input.

GProst avatar GProst commented on July 19, 2024

@bluebill1049 I think it doesn't include changes from #8

from input.

bluebill1049 avatar bluebill1049 commented on July 19, 2024

dame...

from input.

bluebill1049 avatar bluebill1049 commented on July 19, 2024

thought you merged it hahah

from input.

GProst avatar GProst commented on July 19, 2024

😆

from input.

bluebill1049 avatar bluebill1049 commented on July 19, 2024

1.0.14-beta.2

from input.

GProst avatar GProst commented on July 19, 2024

@bluebill1049 seems to be working great now 🎉 all e2e tests in the project I'm working on passed FWIW

from input.

bluebill1049 avatar bluebill1049 commented on July 19, 2024

lovely publishing!

from input.

bluebill1049 avatar bluebill1049 commented on July 19, 2024

hey @GProst i am putting back register unregister name and only leave out rules. you ok with that?

from input.

GProst avatar GProst commented on July 19, 2024

@bluebill1049 I guess this won't harm

from input.

bluebill1049 avatar bluebill1049 commented on July 19, 2024

kk thanks :)

from input.

bluebill1049 avatar bluebill1049 commented on July 19, 2024

hey @GProst FYI when i get some more free time, i think its probably worth to make a RHFFieldArray to abstract those logic.

from input.

GProst avatar GProst commented on July 19, 2024

@bluebill1049 sounds awesome!

from input.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.