reactioncommerce/api-plugin-files

Files plugin for the Reaction API

This repository is deprecated

This code is now located in our monorepo here

api-plugin-files

Summary

Files plugin for the Reaction API

Developer Certificate of Origin

We use the Developer Certificate of Origin (DCO) in lieu of a Contributor License Agreement for all contributions to Reaction Commerce open source projects. We request that contributors agree to the terms of the DCO and indicate that agreement by signing all commits made to Reaction Commerce projects by adding a line with your name and email address to every Git commit message contributed:

Signed-off-by: Jane Doe <[email protected]>

You can sign your commit automatically with Git by using git commit -s if you have your user.name and user.email set as part of your Git configuration.

We ask that you use your real name (please no anonymous contributions or pseudonyms). By signing your commit you are certifying that you have the right have the right to submit it under the open source license used by that particular Reaction Commerce project. You must use your real name (no pseudonyms or anonymous contributions are allowed.)

We use the Probot DCO GitHub app to check for DCO signoffs of every commit.

If you forget to sign your commits, the DCO bot will remind you and give you detailed instructions for how to amend your commits to add a signature.

License

This Reaction plugin is GNU GPLv3 Licensed.

api-plugin-files's Issues

-

product upload image broken

Are you looking for help with getting started on Reaction? Please visit our Reaction documentation.

Issue Description

tried uploading jpeg and png files to product image.

shows up a blank image in media gallery.

Steps to Reproduce

create product, upload product image

Possible Solution

media items show up in

{
"_id" : "MZF7qKCw94k2Bhuw2",
"metadata" : {
"priority" : 2,
"productId" : "SWBP6se8drwdWYBZd",
"variantId" : "WWAnoQhoJTtpM3Dvn",
"ownerId" : "dDGjoKDjMNv4SvhhG",
"shopId" : "5cQ3KnALddhPpJkin",
"workflow" : "published"
},
"original" : {
"name" : "Screenshot 2020-03-26 at 2.08.12 PM.png",
"size" : 19940,
"tempStoreId" : "d21d0441704c6bfa8c9137a7b2a59e6d",
"type" : "image/png",
"updatedAt" : ISODate("2020-03-26T06:08:18.309Z"),
"uploadedAt" : ISODate("2020-03-27T08:46:24.446Z")
}
}

in Catalog, shows up as

			"media" : [
				{
					"priority" : 1,
					"productId" : "SWBP6se8drwdWYBZd",
					"variantId" : "WWAnoQhoJTtpM3Dvn",
					"URLs" : {
						"large" : "null",
						"medium" : "null",
						"original" : "null",
						"small" : "null",
						"thumbnail" : "null"
					}
				},
				{
					"priority" : 2,
					"productId" : "SWBP6se8drwdWYBZd",
					"variantId" : "WWAnoQhoJTtpM3Dvn",
					"URLs" : {
						"large" : "null",
						"medium" : "null",
						"original" : "null",
						"small" : "null",
						"thumbnail" : "null"
					}
				}
			],
			"metafields" : null,

Versions

Cannot find package `api-plugin-files` locally

api_1    | (node:105) ExperimentalWarning: The ESM module loader is experimental.
api_1    | 17:52:00.795Z ERROR Reaction: Cannot find package 'api-plugin-files' imported from /usr/local/src/app/node_modules/@reactioncommerce/api-core/src/importPluginsJSONFile.js
api_1    |   Error: Cannot find package 'api-plugin-files' imported from /usr/local/src/app/node_modules/@reactioncommerce/api-core/src/importPluginsJSONFile.js
api_1    |       at Loader.resolve [as _resolve] (internal/modules/esm/default_resolve.js:84:13)
api_1    |       at Loader.resolve (internal/modules/esm/loader.js:73:33)
api_1    |       at Loader.getModuleJob (internal/modules/esm/loader.js:147:40)
api_1    |       at Loader.import (internal/modules/esm/loader.js:131:28)
api_1    |       at importModuleDynamically (internal/modules/esm/translators.js:75:23)
api_1    | [nodemon] app crashed - waiting for file changes before starting...

Prerequisites

• [ *] Are you running the latest version?
• Are you able to consistently reproduce the issue?
• [ *] Did you search the issue queue for existing issue? [Search issues]

Steps to Reproduce

1. Install the plugin locally
2. after creating a blug to forget a file to declare or something.

Possible Solution

the core it looks for plugins in docker container first

Versions

{
  'reaction-identity': '3.0.0',
  npm: '6.14.4',
  ares: '1.16.0',
  brotli: '1.0.7',
  cldr: '37.0',
  http_parser: '2.9.3',
  icu: '67.1',
  llhttp: '2.0.4',
  modules: '72',
  napi: '6',
  nghttp2: '1.41.0',
  node: '12.18.0',
  openssl: '1.1.1g',
  tz: '2019c',
  unicode: '13.0',
  uv: '1.37.0',
  v8: '7.8.279.23-node.37',
  zlib: '1.2.11'
}

GridStore is deprecated, and will be removed in a future version. Please use GridFSBucket instead

(node:75) DeprecationWarning: GridStore is deprecated, and will be removed in a future version. Please use GridFSBucket instead
api_1    | (node:75) DeprecationWarning: collection.ensureIndex is deprecated. Use createIndexes instead.
api_1    | ReactionError: Error: Input buffer contains unsupported image format
api_1    |     at Sharp.<anonymous> (file:///usr/local/src/app/node_modules/api-plugin-files/src/setUpFileCollections.js:99:19)
api_1    |     at Sharp.emit (events.js:223:5)
api_1    |     at Sharp.EventEmitter.emit (domain.js:475:20)
api_1    |     at /usr/local/src/app/node_modules/sharp/lib/output.js:707:18 {
api_1    |   eventData: {},
api_1    |   error: 'error-sharp-resize-internal',
api_1    |   isClientSafe: true,
api_1    |   reason: [Error: Input buffer contains unsupported image format],
api_1    |   details: {}
api_1    | }
api_1    | 19:53:24.757Z  INFO Reaction: Stopping Reaction API...
api_1    | 19:53:24.758Z  INFO Reaction: Running shutdown function "jobQueueShutdown" for plugin "job-queue"...
api_1    | Failing 1 jobs on queue stop.
api_1    | 19:53:24.765Z  INFO Reaction: Shutdown function "jobQueueShutdown" for plugin "job-queue" finished in 6ms
api_1    | 19:53:24.775Z  INFO Reaction: Reaction API stopped
api_1    | [nodemon] app crashed - waiting for file changes before starting...

Issue Description

Steps to Reproduce

1. Put A image in diroctory public
2. Save image by calling it through url by using fileRecord = await FileRecord.fromUrl(fileUrl, { fetch });

Possible Solution

Versions

Error: Input buffer contains unsupported image format

==> typeDefault
api_1    |  image/jpeg jpg image/jpeg 
api_1    |  
api_1    | 11:35:02.082Z  INFO Reaction: After transformWrite file info is { name: 'WWuTm5nfvKx38A3yd.jpg', type: 'image/jpeg' }
api_1    | 11:35:02.083Z  INFO Reaction: S3Store _fileKeyMaker fileRecord info: { name: 'WWuTm5nfvKx38A3yd.jpg', type: 'image/jpeg' }
api_1    | 11:35:02.084Z  INFO Reaction: S3Store _fileKeyMaker fileRecord size: 38
api_1    | ReactionError: Error: Input buffer contains unsupported image format
api_1    |     at Sharp.<anonymous> (file:///usr/local/src/app/node_modules/api-plugin-files/src/utils/transformWrite.js:37:11)
api_1    |     at Sharp.emit (events.js:223:5)
api_1    |     at Sharp.EventEmitter.emit (domain.js:475:20)
api_1    |     at /usr/local/src/app/node_modules/sharp/lib/output.js:707:18 {
api_1    |   eventData: {},
api_1    |   error: 'error-sharp-resize-internal',
api_1    |   isClientSafe: true,
api_1    |   reason: [Error: Input buffer contains unsupported image format],
api_1    |   details: {}
api_1    | }

The Solution is here

0ca95a3