Giter Site home page Giter Site logo

Comments (10)

smikitky avatar smikitky commented on May 13, 2024 1

As an aside, if you want to always assign the same set of reviewers, I think you can just use the code owners functionality. Randomly picking a part of the reviewers is not possible, though.

from reactjs.org-translation.

tibuurcio avatar tibuurcio commented on May 13, 2024

Hey Nat, I don't quite understand the problem. How is the sync script doing it? And how it would do to assign maintainers without GitHub's API (Do you mean GitHub's UI)?

from reactjs.org-translation.

halian-vilela avatar halian-vilela commented on May 13, 2024

Hey Nat, I don't quite understand the problem. How is the sync script doing it? And how it would do to assign maintainers without GitHub's API (Do you mean GitHub's UI)?

Me neither, could you explain the issue a little bit further?

from reactjs.org-translation.

tesseralis avatar tesseralis commented on May 13, 2024

@tibuurcio @halian-vilela I just mean that when I create a sync pull request, I want to automatically assign "Reviewers" to you or the other pt-br maintainers. Since there are a lot of you, I want to do it in a way that makes sense. If I assign all of you then that might result in duplicated work. I was thinking of assigning the issue randomly to 2-3 maintainers.

from reactjs.org-translation.

halian-vilela avatar halian-vilela commented on May 13, 2024

@tibuurcio @halian-vilela I just mean that when I create a sync pull request, I want to automatically assign "Reviewers" to you or the other pt-br maintainers. Since there are a lot of you, I want to do it in a way that makes sense. If I assign all of you then that might result in duplicated work. I was thinking of assigning the issue randomly to 2-3 maintainers.

@tesseralis

Got it.. randomly to 2 maintainers seems reasonable to me.

from reactjs.org-translation.

smikitky avatar smikitky commented on May 13, 2024

Randomly assigning two of the three maintainers may not make much sense at least in the Japanese fork. We check and approve each sync PR on a first-come basis. It should be either assigning everyone or assigning no one.

from reactjs.org-translation.

QC-L avatar QC-L commented on May 13, 2024

I also think we should assigning no one.

from reactjs.org-translation.

tesseralis avatar tesseralis commented on May 13, 2024

@QC-L could you elaborate on why?

from reactjs.org-translation.

QC-L avatar QC-L commented on May 13, 2024

Random assignment does not necessarily mean someone will respond.
I refresh repo every day, so I will merge when I see it.
I assigned tasks to some people, but you may not receive mail.

from reactjs.org-translation.

QC-L avatar QC-L commented on May 13, 2024

@tesseralis I agree to use code owners.

from reactjs.org-translation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.