reacttraining/react-broadcast

Reliably communicate state changes to deeply nested React elements

react-broadcast's Issues

RFC: Use <Subscriber render> instead of <Subscriber children>

I'm personally starting to prefer using render instead of children whenever I'm using a render prop. But that may just be me.

RFC: Add support for changing <Subscriber channel>?

It should be possible to change the channel in a subscriber, but it's not implemented yet. Is this something that people need? For now I think I'll put an invariant there that prevents people from trying to change it.

Add <Subscriber quiet> prop to avoid invariant when rendered out of context

Currently, if you render a <Subscriber> out of context it'll throw an invariant. This is similar to the context API itself, where if you try to use this.context.cupcakes outside the appropriate context you'll get an error.

What we don't have is a way for users to opt-out of the invariant when they're not rendered in the right context. This would be the equivalent of the isRequired functionality currently available to consumers of the context API through contextTypes.

The idea would be to add <Subscriber quiet> to opt-out of the invariant in these situations.

Make API less verbose

The readme shows you a lot of boilerplate code, that you have to write before you can start using the library. However, it could be much simpler with the same effect:

import { createContextProvider, createContextHOC } from 'react-context-emission'

const GeoProvider = createContextProvider('geo', next => {
   navigator.geolocation.watchPosition(next)
})
const withGeo = createContextHOC('geo')

Then you can start using this immediately, no need to write generic React.Component code every time

const App = withGeo(({geo}) => {
   if(geo) {
        return <dl>
            <dt>latitude</dt>
            <dd>{geo.coords.latitude}</dd>
            <dt>longitude</dt>
            <dd>{geo.coords.longitude}</dd>
          </dl>
    else {
         return <p>Getting geoposition...</p>
    }
})

ReactDOM.render(<GeoProvider><App /></GeoProvider>, container)

Thank you for the library! The idea is awesome, but I think that API could be better.

createContext: uid clash when developing npm linked packages

Each npm linked package has its own set of node_modules, therefore there might be multiple copies of react-broadcasts required by an app (all with the same version). Each of them ofc maintains its own uid counter but broadcasts is a shared key on legacy context and all those copies override what the put in context.

Don't have better idea on how to deal with it than randomizing broadcasts key (at least in development), thoughts? Can prepare a PR handling this if you find it worthwhile.

Allow <Subscriber> to render out of context?

I'm opening this issue to discuss the change made in 57de4ff. I assume it was made so we can render <Link>s in the router outside of the context of a <Router>, right @ryanflorence?

Use the special string only for context key

It seems like the only place we should use the special string is for the key on context, to avoid clashes with others. Everything else we can make generic.

const [ Emitter, Subscriber ] = createContextEmission('keyOnContext')

<Emitter value={someValue}/>

<Subscriber>
{value => (
  // ...
)}
</Subscriber>

Just seems like less docs to do it this way, no?

Subscriber optional context

Thanks for this library.

I'm wanting to use Subscriber, but in a place where the context (broadcast) is not always set. In this case I would like to use either a default prop, or simply undefined.

Currently I can't do this, and I get this error:
browser.js:40 Uncaught Error: <Subscriber channel="filterStore"> must be rendered in the context of a <Broadcast channel="filterStore">

Remove React.Children.only restriction in <Broadcast>

React 16 introduces the ability to return multiple children from a render, so no need for this restriction any more.

Can you add a license for this project

Thanks :)

Multiple values (channel) for the same Provider (Broadcast)

Is it possible to provide multiple values (i.e. localization and theme) on the same Provider (Broadcast) or should I wrap two providers/consumers inside a single component to achieve this?

Subscriber rendered outside of context of a Broadcast but inside of another Broadcast for a different concern

@mjackson, @ryanflorence thanks for the lib!

I'm getting an error because in occasions I wrap certain components with <Subscriber> when they are not descendants of <Broadcast>. I know this was discussed (#6) and fixed but I'm still getting this error:

Uncaught Error: <Subscriber channel="concernX"> must be rendered in the context of a <Broadcast channel="concernX">

I should mention that I use different <Broadcast> - <Subscriber> pairs for different concerns.

For example:

<Broadcast channel="concern1">
  <Broadcast channel="concern2">
    {whatever}
  </Broadcast>
  <Subscriber channel="concern2">
    {whateverElse}
  </Subscriber>
</Broadcast>

There's a problem in <Subscriber channel="concern2"> because this.context.broadcasts exists but not for concern2.

Is this the expected behaviour? Any workaround?

Updating from the outside

Is there a way to update the broadcast value from a separate file. Perhaps inside a method? Having a broadcast set with channel and value, I think I'll like something like:

// different class
import { Broadcast } from 'react-broadcast'

class Foo extend React.Component {
  someMethod() {
    Broadcast.update({name: 'Brendan Eich'})
  }
}

Is it still Actual as react new similar context api available

Is it worth to mark library as deprecated?

Context API was finally stabilized in React 16.3 and is based on react-broadcast.

Therefore, it's worth to mark this as deprecate or at least state clearly in docs that React Context API provide the same interface.

What do you think? Is there any reason not to deprecate 'react-broadcast'?

There is no possible to work with two differnt components..

There is no possibility to work with two different components.
if possible then share the demo code.
I want to send data from one component to another component.

Changelog?

Is there a list of changes anywhere? Thanks!

✌️