readium / r2-lcp-swift Goto Github PK

View Code? Open in Web Editor NEW

5.0 5.0 9.0 5.8 MB

Swift LCP module

License: BSD 3-Clause "New" or "Revised" License

Swift 98.95% Objective-C 0.43% C 0.06% Ruby 0.53% Makefile 0.04%

r2-lcp-swift's People

Contributors

Stargazers

Watchers

Forkers

classwizard aferditamuriqi d-i-t-a demarque nypl-simplified openm1nd ettore m-ochyra honored-technologies

r2-lcp-swift's Issues

rename project to r2-lcp-swift

creating this issue as a reminder for myself

Importing a Publication requires the passphrase

Currently, to import a publication from a LCPL license (using LCPService.importPublication()), the reading app must have the passphrase. Otherwise, the download is discarded.

This prevents from "pre-loading" a publication on the device to be opened later by the user.

I suggest not checking the license in LCPService.importPublication(), and instead just download the package and insert the license in it.

LCP: if offline, detection should be quick

Currently, if the device is offline (e.g. plane mode), there is a timeout before the ebook is opened.

The detection of the offline state should be better, via the iOS API.

Set flag Build Libraries for Distribution to Yes

LCP: when re-opened, the license must not be always re-loaded

steps:

import a .lcpl in the app
open it, then close it
re-open it: the status doc is requested (good); the license is fetched again (bad, because the status states that the license was not updated).

LCP: make the passphrase page better designed

On an iPhone 7, the validation button is partially hidden with the virtual keyboard.

We can make it slightly more compact by merging the two first paragraphs in one.

Dates normalization

//[...]   
"rights":{
      "print":100,
      "copy":2048,
      "start":"2017-08-30T03:39:24.687663655Z",
      "end":"2017-08-31T12:40:00+09:00"
   },
// [...]

The variations encountered in the LCP server dates should be normalized, to simplify their usage.

LCPDF forever loading

Hi!

I am trying out the PDF feature in readium and am not getting it to work. I've successfully imported the publication and get the extension .lcpdf in the suggestedFilename.

I've tried with both an epub-license and a pdf license. It works with the EPUB publication, but when opening the pdf-ebook it never stops loading. I don't see any error message in the console log.

My code for parsing the publications:

do {
    print("LOCATION TYPE:", location.type, " - path: ", location.absolutePath)
    guard let (pubBox, parsingCallback) = try Publication.parse(at: URL(fileURLWithPath: location.absolutePath)) else {
         return completion(nil)
     }
     
     let (publication, container ) = pubBox
     let customIdentifier = NSURL(fileURLWithPath: location.absolutePath).deletingPathExtension?.lastPathComponent
     publication.metadata.otherMetadata["id"] = customIdentifier
     self.items[customIdentifier!] = (container, parsingCallback)

     try self.publicationServer!.add(publication, with: container)
     completion(publication)
} catch {
    ...
}

Dependencies

App's Cartfile.resolved:

github "cezheng/Fuzi" "3.1.1"
github "dexman/Minizip" "1.4.0"
github "edrlab/GCDWebServer" "3.6.2"
github "jdg/MBProgressHUD" "1.1.0"
github "krzyzanowskim/CryptoSwift" "1.2.0"
github "onevcat/Kingfisher" "5.9.0"
github "readium/r2-navigator-swift" "1.2.6"
github "readium/r2-shared-swift" "1.4.3"
github "readium/r2-streamer-swift" "1.2.5"
github "readium/readium-opds-swift" "1.2.3"
github "stephencelis/SQLite.swift" "0.12.2"
github "weichsel/ZIPFoundation" "0.9.9"

Using r2-lcp-swift (1.2.3) with a test liblcp.
DM me (Christopher N) on slack and I'll share the lcpl license I am using :)

Unexectedly found nil while implicitly unwraping an optional value

I tried to add .xib file for this controller into this pod, like in github repo, also linked resources, but no success

When loading a specific EPUB file (ask me the file epub31-makes-iostestapp-crash.epub) the app crashed.
Note: the file may be corrupted (comes from an export from another reading system), but it's still a good test file for what follows.

After restart, the file is not present in the catalog. When trying to load this file again, I've got the message "File already exists".
Remove and reinstall the app. import ok, ask passphrase ok, the app starts opening the file -> crash again.

Webpage not available

Error messages when opening/closing an LCP protected ebook (may be an application issue).

On Android 9

Steps:

open an LCP protected epub; sometime the "Webpage not available page" appears. Swiping removes the message.
close an LCP protected epub; the "Webpage not available page" appears.