realconrad/42minishell

Creating our own shell based off bash

👋 Hello, I'm Conrad

💭 About Me

• 42Heilbronn Student (Part of the 42Network)
• Programmer
• Gamer
• Anime enjoyer
• Always trying to learn something new

📊 Github Stats

Isometric view of contributions in the last year. Language pie is based on recent commits

✨ Overview

🔧 Skills:

Tech:

Tools:

Currently Learning:

Tech: C, JavaScript, TypeScript, Vue, HTML, CSS, TailwindCSS
Tools: Github, Git, Stackoverflow, VSCode
Currently Learning: C++, Go

✉️ Get In Touch

Don't hesitate to reach out to me, whether you have a question, want to hang out, or even play a game – just give me a ping!

42minishell's Issues

MALLOC, PIPE and FORK error handler

Understand allowed functions

Understand the allowed functions as described by the subject PDF

Add check for access (exit code 126)

Exit status

Get correct exit status

During testing, I encountered some inconsistencies regarding the exit status code.

minishell: syntax error near unexpected token |
minishell> echo $?
258

This should not give 258 as return value. It should return 2

ctrl+c returns 0 as exit status, but should return 130.

minishell> "
minishell: unclosed quotes 
minishell> echo $?
0

returns 0 as exit status but should also return 2.

ENV fix

1. Create a 2D array.
2. Create Array utils for copying stuff and removing stuff

Support for multiple heredocs, outfiles (parser)

The parser should support multiple infiles, outfiles, and heredoc commands for a single command

Finish writing doxygen comments for all functions and structs

Refactor functions for lexer

test

Testing redirs

Handle Ctrl+\ in child process and signal exit codes

• Fix exit codes
• In bash, Ctrl-\ (SIGQUIT), behaves the following in a child process:
  • Heredoc: nothing
  • During sleep: Displays Quit: 3, and exits the child.

bug fixing

• Fix the space after single and double quote.
• Fix the waitpid for every single command as a while loop.
• For EXPORT builtin, sorting in ascending order.
• EXIT builtin.

Heredoc expander

Create an expander for the heredoc input

Create custom built-ins

The shell must implement the following builtins:

• echo with option -n
• cd with only a relative or absolute path
• pwd with no options
• export with no options
• unset with no options
• env with no options or arguments
• exit with no options

Norminette

Fix all norm errors

Add doxygen comments

Add doxygen comments for:

• Lexer
• Parser
• Expander
• Signals
• Executor
• Utils
• Builtins
• Structs

Setup signals

Setup signals for parent and child processes

Minishell? pff, more like minihsell...

look into main.c -> line 25 ...

No collapsing pipes

Collapsing pipes

try the following command in bash and then in your shell:

cat /dev/urandom | ls

# or

cat /dev/random | ls

You will see that your shell is continuously waiting for the EOF of /dev/random/ which will never be reached and therefore your shell is getting unusable. In that scenario, your pipe should collapse and also close the filestream from cat /dev/random.

Check file access

Check if I have access to the files and return an appropriate error and error code

General error management

Provide general errors for pipe, malloc, fork etc...

Add executor

Implement logic for multiple redirections in executor

Add parser and lexer

Add the lexer and parser for minishell.