Giter Site home page Giter Site logo

realtalk's People

Contributors

blee92 avatar colinkho avatar coryshiraishi avatar hazarij avatar joryrice avatar realtalk403 avatar taylorsw avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

realtalk's Issues

Long pword causes wrong create account error

Here's what I did:

Entered 'C' as a username
Entered a longggg password
Confirmed password (I'm pretty sure I was correct)
Clicked to continue
Received error alert saying that the username was already taken
Tried again changing the name
Received same error
Tried a third name
Received same error
Shortened the password without changing the name, and it worked.

Tried again using a previously rejected name and a shorter password, and it worked

Tried to create an account with same name as I'd just created but intentionally getting the confirm wrong, and it rejected it with the proper error alert.

Tried it with a name I'm certain nobody has used and with a really long password, and received an error saying the username was taken

At this point I'm fairly certain the bug is with longgggg passwords.

Redirect activity

When someone creates a new username/password, it should automatically redirect to the chatroom page.

Back-end chat server

Implement back-end chat server that communicates with clients(android devices).

Hungarian Prefixes (& standards consistency)

We haven't been using them well beyond st. We have a few custom ones to start using too:

it - Intent
cri - ChatRoomInfo
u - User
mi - MessageInfo

Old variables names need to be updated.

Bug with ListView selection/scrolling

new messages in chatrooms are placed at the bottom of the list, but it is not automatically scrolled. and attempting to select messages crashes the program.

naming inconsistency

In ChatManager, we have 3 methods:

pullmessageresultsetChatRecentChat
rgstChatLogGet

rgmessagePostRequest

All return the same thing, a PullMessageResultSet. There should be a consistent prefix for returning that type.

Spontaneous Crash

App will spontaneously crash when entering a chatroom for the first time (sometimes...).
Need to investigate further.
Once messages have been sent into the room, it won't crash (I think).

Simultaneous Logins

Can login with the same uname/pword on two devices at the same time. Need to fix.

Bug with create user actiity

If you try to create a new user account, it throws an exception and crashes trying to call the addUser method (I think). Please look into this and fix ASAP :)

JSONParser static fields

JSONParser's fields have been left static and at package visibility. It seems like this might cause some concurrency issues if two JSONParsers get used at the same time. Is there a reason for this?

Google Cloud Messaging

Instead of pulling messages at a given interval, implement a push service for notification of new messages to chat room

Server doesn't work sometimes

For some periods of time, no matter what you query the server, it returns fSucceeded = false and doesn't let you login, create accounts, or anything.

UserManager Implementation

The TDD tests are out for UserManager but are failing because it is not yet implemented.

We need to implement our UserManager for v1.

colinkho

Coding Standards consistency

We need to go through and fix hungarian in the Android side of things. Code reviews have been held for functionality, but we need to keep consistent style.

Database schema

Design the database schema and create tables in the database on Heroku.

Redesign packages

Right now the packages are Util & activities.

Util basically contains everything.

We should break it up into more diverse packages:

ServerCommunication
DataModels
Activities

or

ServerCom
Account
Chat

This should probably be done after the end of the phase, which should minimize merge conflicts after the switch is done.

Explicit menu button

Not all phones have a menu button (mine doesn't).

I can't access AccountSettingsActivity, and I can't log out.

Basically we need a button on the screen that can access the menu.

Fix broken build

The latest pull request lacked some resources that should have been checked in. Checking out a fresh copy of the repo reveals that it did indeed break the build. I know for a fact certain string values were not checked in, but I did not investigate deeper. THIS IS A HIGH PRIORITY BUG.

ChatManager makePostRequest return value

Not a big problem now but I feel that null should not be returned if parsing threw an exception and it control ended up returning null. A PullMessageResultSet/ResultSet should be returned indicated failure. This is so that the client does not need to catch null.

By: colinkho

User login not working

I tried the latest build of realtalk and it is crashing whenever I try to login using a user name and id that does not exist.

In the stack trace, it seems like its a org.json.JSONException being thrown with no value for ERROR_CODE.

There were two pull requests today so I'm sure which one I should revert to.

This should be fixed asap.

SubmittedBy: colinkho

No timeout on network requests

Requests to the servlet have no timeout, and thus can keep the loader up in an infinite loop. Should add a timeout and/or error message.

ChatRoomModel iUsers

The field iUsers is, from an abstracted viewpoint, equivalent to rgu.size. Yet both are tracked and updated separately. We need to pick a consistent representation.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.