reasonml/reasonml.github.io

Reason's documentation site

reasonml.github.io's Issues

Try https://microsoft.github.io/monaco-editor/ for Try playground

Some small "bugs"

Hi !
The new ReasonML's website is really cool, but I have point some little bugs :

• https://reasonml.github.io/guide/tools the pictures are dead
• https://reasonml.github.io/guide/ocaml in the OCaml part, there are some anoying \ in the code

playground: show warnings

Try Reason: error obscures the lower part of the pane

If the error happens to be at the bottom of the pane, I guess you'll just have to live with it. (Alternatively you can add a few linefeeds at the bottom to push the code with the error up)

Home page title broken for me

Can consistently repro in Chrome and Opera

The first time I visit the site the title is empty (confirmed by viewing the page source)
Then when navigating around and going back home by clicking the site logo the home page title is the title of the previous page.

FAQ Question: What is the recommended standard+/core library (or libraries)?

I suppose we don't have much of an answer yet, but the question keeps coming up regardless

Runnable code examples in tutorial

I suppose this might require rewriting the guide as a tutorial

Broken html in guide/ocaml/#variants

Idempotent deploy

High pri. We'd like a deploy on master to be no-op (at least for the content itself) if the source isn't changed.

New playground fails to compile code that is incorrectly pretty-printed, when it would normally work fine

OCaml's pprintast has some bugs (among other flaws). One of those bugs is that # operators will be printed incorrectly. E.g.

let f thing => thing##x

will be printed as

let f thing = ## thing x

And because the playground compiles the pretty-printed OCaml instead of using the AST from refmt directly, it will fail to compile. When refmt is used normally as part of the build process however, it uses the AST instead and will compile correctly.

Try Reason: Base64 encode URLs

The share URLs are extremely long. It might be a good idea to base64 encode the query param value to make it merely very long. See reason-tools for inspiration.

Reason Online Tool generates incorrect reason code from Ocaml

But this code is incorrect, compilers says:

Error: This pattern matches values of type string
but a pattern was expected which matches values of type int

remove unused code in playground

just like http://bucklescript.github.io/bucklescript/js-demo/ does

For the playground we should just take https://github.com/BuckleScript/bucklescript-playground

document bundler for bs

Routing breaks after a while of use

After clicking on some links really fast I eventually get SimpleEventPlugin.js:219 Uncaught TypeError: Cannot read property 'remove' of undefined and routing no longer works.

Some API docs are reaaaaally scaring looking

We should probably tweak the css for these

cc @jsdf

Right-clicking on a relative link triggers navigation

Steps to reproduce

Right-click on a link on reasonml.github.io that points to somewhere else on reasonml.github.io.

Expected behavior

I would be able to view the context menu for the link without navigation

What actually happens

My browser navigates to the link I right-click on.

Additional information

This doesn't appear to happen on other sites using Gatsby (e.g., Segment's blog, https://www.gatsbyjs.org/).

I'm using Firefox 56 on Linux.

More prominent search

And maybe it let it float somewhere? It's nice to be able to stay on the page while searching

Quick start ideas

A few proposals for the quickstart section. I'm happy to do the work on these but wanted to get feedback first.

• Fold the editor config section into the JS and native pages, since people may otherwise neglect to go back and do it.
• Add some short hits to explain what the quickstart steps are doing ("Bucklescript is a ...", "OPAM is the ...") so people know
• Gather some possible error cases and what to do about them.
• Add a "Can't get it working?" section with where to get help. (Right now this is Discord, but that means that lots of people ask the same questions in there. It might be nice for the community to adopt a public, searchable, linkable place to provide definitive answers to common problems.)

Option to try new syntax in playground

I realise the new proposed syntax #1299 is a bit of a minefield, but would it be possible to have an option on the Try page to explicitly select the WIP (with appropriate warnings, 'beta' status, summary of differences/changes, code-snippets showing real-life examples/advantages, etc) branch.

I would like to try it for myself before jumping to conclusions and the only way right now seems to download the repo, switch branch and use rtop/refmt or build and run the website locally. This may also help with testing, as people try to (a) understand and explore and (b) think up pathological case and (c) convince people of benefits.

Sharable Try links

We can encode the snippet in the URL in the simple case

"Try Reason" generated javascript bleeds into program output in Firefox

First screenshot is Firefox 54 on Linux. Second is Chromium 60 on Linux.

Catch broken links

Overview needs an easy "your first program" section

The overview is nice because it gives easy syntax tips. However, I cannot see (as a non-Reason-programmer) how my first program should look. How can I print values? Do I need a main function? etc, etc

Next page at the bottom of each section

I think it makes sense to add a next page button in the bottom right corner of each chapter/section. It gets tedious to scroll up (on small screens) after reading a section to find the next one.

add full function syntax

labelled argument with renaming + default value

Try Reason: Javascript execution error is displayed in OCaml pane, and clears JavaScript pane

If there is an error in execution of the generated JavaScript, the error will be displayed in the OCaml pane. Additionally, the JavaScript pane will be cleared, so you'll have no idea what even caused the error! 😀

Permalink pages for blog posts

I have a feeling that links to individual blog posts are going to break because they're just fragment identifiers on a single page.

Example tweet that is doomed to break when the index page gets too long or we change the link format: https://twitter.com/wincent/status/901116644600172544

Ideally we'd have standalone permalink pages with stable URLs which will last "forever".

reasonml windows installation instruction

Hi, as one of OS - windows user, I've been tried the different solution for installing reason on windows.
As last and most successful way which works mostly out of the box
is that package ocaml-on-windows.
Full IDE(vscode) support including merlin, refmt and other tools:

What do you think, should we add that package to documentation? I think it will help a lot of window-users newcomers.
I can make a PR

Middle click swallowed

On localhost this opens a new tab. On prod it turns into a left click.

cc @bassjacob

Try Reason page should have several examples to try out/start from

Deploy Production build

Currently the development build is published.

(Runnable) code example on front page

Missing words in `External` Guide

The last sentence of this section https://reasonml.github.io/guide/language/external is missing some words.

CodeMirror lint integration

I tried to get the CodeMirror lint plugin working with the online playground.

Seems doable. So I wanted to ask if you like the idea and if I should proceed and finalize the proof of concept.

Playground: Add support for Standard Library Modules

It would be great to make use of the standard library in the playground.

let len = List.length [];

gets transpiled correctly into

var List = require("stdlib/list");
var len = List.length(/* [] */0);
exports.len = len;

Bucklescript Compilation Error
require is not defined

Playground extremely slow for anything past 10 lines of code

We should debounce. Though the bucklescript playground is super fast... http://bucklescript.github.io/bucklescript/js-demo/

Put companies section at the bottom of front page instead

JSX parser error

This line produces an error
<span className="filter-label"><span>(ReasonReact.stringToElement "Has interface")</span></span>
Though if to format it manually like this, then it works:

<span className="filter-label">
     <span>(ReasonReact.stringToElement "Has interface")</span>
</span>

So as you can see from error, it complains that code contains some reserved BuckleScript keyword.

P.S.
Was redirected from BuckleScript team: rescript-lang/rescript-compiler#1874

Modules page edits

Before actually writing copy, I'd like to get feedback on a few suggested changes to the modules page in the language basics section.

Here's my proposal:

• Add an introduction that defines modules by what they do and makes clear that they don't just group related code, but also serve as the means of abstraction and generic programming. (This occurs later on in the current article, but perhaps beyond where most people would read.)
• Reorganize the example sections so that they are not grouped by language feature ("Module signatures", "Module functions") but instead by the purpose they serve ("Building abstractions", "Generic programming"). Add a callout to features from other languages that modules serve in Reason (templates, generics, type classes, etc.).
• Similarly, rename syntax-related sections from the language names ("opening a module") to the purpose they serve ("Using code from another module").
• Add more detail to the drawbacks section, which currently seems like a let-down after the rest of the article got you excited about modules. I'd like to add some more text on cases where modules aren't the right answer, and make clear that there are many cases where they are.

Anchors for headings

So that we could link to sub-sections in e.g. this section: https://reasonml.github.io/guide/language/types

Should the menu titles be capitalized?

quickstart -> Quickstart

icon overlaps quickstart link on mobile

maybe just hide the icon at mobile sizes?

Upload source file into Playground.

It will be nice to be able to upload a source file and extract it's code into the playground. My initial thoughts are we add a custom right-click menu by attaching it's event listener to the playground textarea(reason). Something like this jsfiddle.

Memorize last Try snippet in localStorage

Font size too large [discussion]

Looking at a few pages, I find the font size to be too large. It gets computed as '18px'. I took a look at the documentation for other sites and find the text to be more readable, where they have a computed font size of '16px'.

See Rust and Elixir

Translation infra

Not sure what we should do here. High pri, as many translations are coming in.

Translation to other languages

Playground eval timeout to avoid the infiniteness of infinite loops

Auto-evaluating an accidental infinite loop caused by some intermediate editing state kind of sucks. Not just because the whole tab freezes, but you'll also lose everything you did up to that point. Even with the new localStorage, a kill & refresh will just land you straight back into the same infinite loop of suckiness.

So yea.. Timeout good.

Debounce search keystrokes