redhat-openshift-ecosystem/preflight-trigger

preflight-trigger's Issues

Remove release-image-ref option

We are not creating a ClusterDeployment therefore a reference to a release image CR is not required.

Switch Cobra CMDs from `Run` to `RunE`

In this project we are logging fatal everywhere and processing the errors ourself. It would be better if we switched to RunE for all our cobra cmds, and then just log the error and return the error for cobra to handle.

Add the Ability to Pass a `token` to GitHub Client

Issue

Due to the fact that Github rate limits requests, some executions to preflight-trigger fail. To mitigate this issue we should allow the caller to pass an optional token to our Github Client Implementation.

Proposed Changes

• Add an optional flag/env to accept the token from the caller.
• Update the go-github library to latest (and probably go versions while we are at it)
  • This update to latest will give us an option on the client to pass a token with method WithAuthToken.
• If the caller calls with the new flag/env add the above WithAuthToken to the github client, otherwise create the client as default.