redhatgov/devsecops-workshop

DevSecOps Workshop for OpenShift

devsecops-workshop's Issues

Support for RHPDS provisioning

Targeting RHPDS as a deployment option. This could be something we put in this repo or just reference to another repo from here. Either way, would like to track here.

Add playbooks to uninstall workshop

Add playbooks to delete the projects created by the workshop. Probably can delete all projects that are associated with each user in the workshop since part of the workshop is that they create a project. They might change the name from what is in the workshop instructions.

Fix Ansible deprecation warnings

Fix ansible deprecation warnings which include, but are not limited to:

TASK [install-jq : Install jq command-line JSON processor] ********************************************************************************************************************************************************
Monday 04 November 2019  23:55:04 +0000 (0:00:00.672)       0:00:21.501 *******
 [WARNING]: Consider using the get_url or uri module rather than running 'curl'.  If you need to use command because get_url or uri is insufficient you can add 'warn: false' to this command task or set
'command_warnings=False' in ansible.cfg to get rid of this message.

TASK [setup-cicd : Update docker options] *************************************************************************************************************************************************************************
Tuesday 05 November 2019  00:04:57 +0000 (0:04:33.621)       0:10:14.836 ******
 [WARNING]: Consider using the replace, lineinfile or template module rather than running 'sed'.  If you need to use command because replace, lineinfile or template is insufficient you can add 'warn: false' to
this command task or set 'command_warnings=False' in ansible.cfg to get rid of this message.

RUNNING HANDLER [setup-cicd : Restart sshd] ***********************************************************************************************************************************************************************
Tuesday 05 November 2019  00:04:59 +0000 (0:00:00.261)       0:10:16.007 ******
[DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of using `result|success` use `result is success`. This feature will be removed in version 2.9. Deprecation warnings can be disabled by
setting deprecation_warnings=False in ansible.cfg.
changed: [bastion.dan.redhatgov.io]

Cleanup wetty/butterfly code

AFAIK wetty/butterfly is being deployed on a per user bases in the cluster and no longer being installed on the master node. Remove the code/tasks that install a bunch of stuff on the master since that is no longer needed.

Install oc command only if not present

The install-oc role installs the oc binary to /usr/bin/oc on the bastion host for the cluster. In most cases this bastion host is a master node which already has the correct oc command installed to /usr/bin/oc. Update the install-oc role to only install the oc binary if /usr/bin/oc is not present.

Update variable files

1. Playbooks should be updated to use aws,env and aws.yml, not aws.example.env and aws.example.yml. The intent is that the example files be copied without the example extension and then customized

2. The aws.yml file comes from an older version of the openshift provision tool. The additional variables needed to deploy this workshop have been added to that file. This makes it hard to tell which variables go to what. Split out the variable required for the workshop into devsecops.yml with corresponding devsecops.example.yml. This will also all users to make a symlink for aws.yml to the same file they already have from the provision tool.