redhatgov/terraform-packet-openshift

Resources and artifacts for OCP 4 UPI on Packet using Terraform

terraform-packet-openshift's Issues

Publish this module in the Terraform registry

In order for users to more rapidly take advantage of this Terraform configuration, it should be packaged as a Terraform module (or set of modules).

https://www.terraform.io/docs/modules/publish.html
https://www.terraform.io/docs/registry/modules/publish.html

The modules should fit the best practices: https://www.terraform.io/docs/modules/index.html

https://registry.terraform.io/browse/modules?provider=packet

Modules should be reusable as the base of new projects:
terraform init --from-module=packet/openshift/packet packet-openshift

And modules should allow for reuse as dependencies in more complex projects:

module "openshift" {
  source = "packet/openshift/packet"
  version = "0.1.0"
  packet_token = "..."

  ...
}

provider "kubernetes" {
  config_path = module.openshift.kube_config 
  // this does not exist, but it could be a new output ${abspath(path.root)}/auth/kubeconfig (maybe path.module)
}

Steps to publish:

1. Adopt file naming conventions (main.tf, outputs.tf, variables.tf)
2. Ensure paths are module safe (path.module + “/assets/foo.sh“)
3. Ensure that all variables and outputs have a description
4. Ensure that the README.md is present and in good shape (mentions module install and use)
5. All sub-modules must also adhere to the previous four bullets as if they were root modules
6. Include examples/ showing how to use this project as a module
7. Rename the project (terraform-packet-openshift) (or terraform-packet-redhat-openshift) (github automatically redirects visitors and git users using the old name)
8. Tag the project
9. Publish the project: registry.terraform.io/sign-in

Configure nginx to listen on non-default port for ignition/ipxe

• Leave TCP80 free for incoming connection to OpenShift ingress controller/router.
• Update references to ignition URL and ipxe scripts

Host installer artifacts on bastion

Speed up deployment by mirroring OCP installer binaries to bastion host.

Document targeted bootstrap node cleanup

Should reference the bootstrap resource specifically for destroy: https://www.terraform.io/docs/commands/destroy.html

Document/automate deploy OpenShift Virtualization Operator

Post-install, and post-storage configuration, deploy CNV/kubevirt/OpenShift Virtualization/whatever the latest product name is. Depends on #21 to successfully launch VM's

Support Let's Encrypt certs (post-install)

Use acme.sh and Cloudflare for automation:

• https://github.com/acmesh-official/acme.sh#8-automatic-dns-api-integration
• https://www.openshift.com/blog/requesting-and-installing-lets-encrypt-certificates-for-openshift-4

Auto-approve "Pending" CSRs before install completes

while looping executing:

oc get csr -oname | xargs oc adm certificate approve

Get iPXE working on Packet for RedHat CoreOS

Get iPXE working on Packet for RedHat CoreOS:
Drop some files in a folder named ipxe

Document deploy of OpenShift Container Storage (OCS)

This would help with #22, particularly with consideration of VM live migration when running CNV, and provide an integrated s3 endpoint for OCP tenants. Couple of notes:

• only applies to worker count >= 3
• requires a few extra steps to enable/subscribe to the operator
• might require custom configuration for supplemental storage on worker nodes

operator subscription manifest (and prereqs for singleNamespace deployment):

apiVersion: v1
kind: Namespace
metadata:
  labels:
    openshift.io/cluster-monitoring: "true"
  name: openshift-storage
spec: {}
---
apiVersion: operators.coreos.com/v1
kind: OperatorGroup
metadata:
  name: openshift-storage-operatorgroup
  namespace: openshift-storage
spec:
  serviceAccount:
    metadata:
      creationTimestamp: null
  targetNamespaces:
  - openshift-storage
---
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
  name: ocs-operator
  namespace: openshift-storage
spec:
  channel: stable-4.3
  installPlanApproval: Automatic
  name: ocs-operator
  source: redhat-operators
  sourceNamespace: openshift-marketplace
  startingCSV: ocs-operator.v4.3.0

Optional Components

Hey @liveaverage:
I think we should be trying to keep OpenShift 100% vanilla and opinionated in things such as NFS.
This can be done with variables such as enable_nfs = ture and if it's not enabled then NFS doesn't get installed. This will allow us to make these things modular and if we want to do things like OpenShift Container Storage we can optionally.

I'd also like to see if we could make NS1 and Route53 options for DNS as well.

Document OpenShift API token generation

Need to share the link to generate a bearer token for pullSecret generation: https://cloud.redhat.com/openshift/token

Document (re)deploy of registry via operator patch

Something like this should work fine since we're using NFS storage:

oc patch configs.imageregistry.operator.openshift.io/cluster --type merge -p '{"spec":{"managementState": "Managed", "storage":{"pvc":{"claim":""}}}}'

That should cover enabling managementState + allowing an automated claim via NFS-provisioner

Add variable bearer token for pullSecret generation

This will ensure proper association with a customer's RHN ID. This only needs to be done once and configured as a variable. Generation of pullSecret will remain automatic.

Write documentation for user to create cloudflare free account

Write documentation for user to create cloudflare free account.
And gather the API token for Terrafrom

Fix reference to openshift router/ingress controller

Currently referencing the wrong nodes hosting the router:

https://github.com/RedHatSI/openshift-packet-deploy/blob/master/terraform/modules/bastion/templates/nginx-lb.conf.tpl#L32-L34

Template out the Ignition files for deployment

Template out the Ignition files for deployment

Enable deployment from macOS by adding to vars.tf

Currently the only supported execution environment is Linux, but we should be able to accommodate macOS (and the relevant oc and openshift-install binaries) by checking for execution environment via variable. Need to update the bash script for https://github.com/RedHatSI/openshift-packet-deploy/blob/master/terraform/modules/prereq/scripts/get-ocp-installer.sh to check for a PLATFORM var

Enable HA for loadbalancer

• Requires updating DNS to point at shared/anycast address

Support 3-node clusters with OpenShift 4.5

With the recent release of 4.5, 3-node bare metal deployments are now supported. Offer this as a deployment configuration: https://docs.openshift.com/container-platform/4.5/installing/installing_bare_metal/installing-bare-metal.html#installation-three-node-cluster_installing-bare-metal

Uniform Standards Request: Experimental Repository

Hello!

We believe this repository is Experimental and therefore needs the following files updated:

• The Experimental badge
• The Experimental Statement in the README.md
• Getting Started Tutorial
• README.md
• LICENSE
• CI/CD
• OWNERS.md
• Developer Certificate of Origin
• At least one maintainer

If you feel the repository should be maintained or end of life or that you'll need assistance to create these files, please let us know by filing an issue with https://github.com/packethost/standards.

Packet maintains a number of public repositories that help customers to run various workloads on Packet. These repositories are in various states of completeness and quality, and being public, developers often find them and start using them. This creates problems:

• Developers using low-quality repositories may infer that Packet generally provides a low quality experience.
• Many of our repositories are put online with no formal communication with, or training for, customer success. This leads to a below average support experience when things do go wrong.
• We spend a huge amount of time supporting users through various channels when with better upfront planning, documentation and testing much of this support work could be eliminated.

To that end, we propose three tiers of repositories: Private, Experimental, and Maintained.

As a resource and example of a maintained repository, we've created https://github.com/packethost/standards. This is also where you can file any requests for assistance or modification of scope.

The Goal

Our repositories should be the example from which adjacent, competing, projects look for inspiration.

Each repository should not look entirely different from other repositories in the ecosystem, having a different layout, a different testing model, or a different logging model, for example, without reason or recommendation from the subject matter experts from the community.

We should share our improvements with each ecosystem while seeking and respecting the feedback of these communities.

Whether or not strict guidelines have been provided for the project type, our repositories should ensure that the same components are offered across the board. How these components are provided may vary, based on the conventions of the project type. GitHub provides general guidance on this which they have integrated into their user experience.

Determine how/where to host ipxe script

Currently hosting on a CloudFlare Worker, but best to move existing js code to the bastion host: http://shifti.us/ipxe/

Source code (for javascript or PHP) hosted here, but will soon be merged into this repo: https://github.com/liveaverage/ocp-dynamic-ipxe-script/blob/master/boot.js

Use node IPs for NFS exports

NFS provisioner deploys fine but exports to DNS names proving problematic. Switch to IPs similar to: https://github.com/RedHatSI/openshift-packet-deploy/blob/master/terraform/modules/install/main.tf#L24-L41

Add final openshift-install call

Post-bootstrap entry removal from nginx:

./openshift-install --dir=install wait-for install-complete

Add documentation for cluster scale-up

Super easy, but good to have it noted:

## You should permanently set count_bootstrap=0 by updating your vars.tf, but for the sake of time:
terraform apply -var="count_compute=4" -var="count_bootstrap=0" --auto-approve

Once the node has been provisioned, approve the pending CSR as cluster admin:

oc get csr -oname | xargs oc adm certificate approve

Once CSR is approved, you can quickly see the node appear, first NotReady then Ready:

[jrmorgan@localhost terraform]$ oc get nodes
NAME                        STATUS     ROLES    AGE   VERSION
master-0.og.pkt.shifti.us   Ready      master   35h   v1.17.1+912792b
master-1.og.pkt.shifti.us   Ready      master   35h   v1.17.1+912792b
master-2.og.pkt.shifti.us   Ready      master   35h   v1.17.1+912792b
worker-0.og.pkt.shifti.us   Ready      worker   34h   v1.17.1+912792b
worker-1.og.pkt.shifti.us   Ready      worker   34h   v1.17.1+912792b
worker-2.og.pkt.shifti.us   Ready      worker   34h   v1.17.1+912792b
worker-3.og.pkt.shifti.us   NotReady   worker   3s    v1.17.1+912792b
[jrmorgan@localhost terraform]$ oc get nodes
NAME                        STATUS   ROLES    AGE     VERSION
master-0.og.pkt.shifti.us   Ready    master   35h     v1.17.1+912792b
master-1.og.pkt.shifti.us   Ready    master   35h     v1.17.1+912792b
master-2.og.pkt.shifti.us   Ready    master   35h     v1.17.1+912792b
worker-0.og.pkt.shifti.us   Ready    worker   34h     v1.17.1+912792b
worker-1.og.pkt.shifti.us   Ready    worker   34h     v1.17.1+912792b
worker-2.og.pkt.shifti.us   Ready    worker   34h     v1.17.1+912792b
worker-3.og.pkt.shifti.us   Ready    worker   2m45s   v1.17.1+912792b

Update OCP release to 4.5

Just need to update vars to ref OpenShift 4.5 and test/validate. Should have this done soon.

Remove deprecated s3 endpoint documentation

Due to early provider initialization, we needed to avoid use of s3 endpoints for ignition config hosting. Remove old docs mentioning it.

Add support for NFS storage provisioner

90% completed, but need to test provisioner creation post-install. Snippet to be moved to a template:

resource "null_resource" "ocp_nfs_provisioner" {

  depends_on = [ null_resource.ocp_installer_wait_for_completion ]

  provisioner "local-exec" {
  command    = <<EOT
    source ${path.root}/artifacts/install/auth/kubeconfig;
    curl https://raw.githubusercontent.com/kubernetes-incubator/external-storage/master/nfs-client/deploy/rbac.yaml > ${path.root}/artifacts/install/nfsp-rbac.yaml
    curl https://raw.githubusercontent.com/kubernetes-incubator/external-storage/master/nfs-client/deploy/deployment.yaml > ${path.root}/artifacts/install/nfsp-deployment.yaml
    curl https://raw.githubusercontent.com/kubernetes-incubator/external-storage/master/nfs-client/deploy/class.yaml > ${path.root}/artifacts/install/nfsp-class.yaml
    export oc=${path.root}/artifacts/oc
    $oc create namespace openshift-nfs-storage
    $oc label namespace openshift-nfs-storage "openshift.io/cluster-monitoring=true"
    NAMESPACE=`$oc project openshift-nfs-storage -q`
    sed -i'' "s/namespace:.*/namespace: $NAMESPACE/g" ${path.root}/artifacts/install/nfsp-rbac.yaml
    sed -i'' "s/namespace:.*/namespace: $NAMESPACE/g" ${path.root}/artifacts/install/nfsp-deployment.yaml
    sed -i'' "s/10.10.10.60/${var.bastion_ip}/g" ${path.root}/artifacts/install/nfsp-deployment.yaml
    sed -i'' "s/fuseim.*/storage.io\/nfs/g" ${path.root}/artifacts/install/nfsp-deployment.yaml
    sed -i'' "s/\/var\/nfs/\/mnt\/nfs\/ocp/g" ${path.root}/artifacts/install/nfsp-deployment.yaml
    sed -i'' "s/fuseim.*/storage.io\/nfs/g" ${path.root}/artifacts/install/nfsp-deployment.yaml
    sed -i'' "s/fuseim.*/storage.io\/nfs/g" ${path.root}/artifacts/install/nfsp-class.yaml
    $oc create -f ${path.root}/artifacts/install/nfsp-rbac.yaml
    $oc adm policy add-scc-to-user hostmount-anyuid system:serviceaccount:$NAMESPACE:nfs-client-provisioner
    $oc create -f ${path.root}/artifacts/install/nfsp-class.yaml
    $oc create -f ${path.root}/artifacts/install/nfsp-deployment.yaml
  EOT
  }
}