rednaks/django-ip-geolocation

IP Geolocation Hooks for django

Hi there 👋

💬 Ask me about FreeSoftware and Python !

GitHub Stats:

GitHub Trophies:

---

django-ip-geolocation's Issues

cloudflare backend

ENABLE_COOKIE not working without ENABLE_RESPONSE_HOOK in decorator

geolocation backends settings

• custom header
• enable/disable on request
• enable/disable on response

set location in cookies

data function not returning the right format

Add support for ipgeolocation.io

It would be nice to have support for ipgeolocation.io

decorators geolocation is None

Enhance the readme

• Download stats
• Builds stability
• Test coverage

Middleware response hook is disabled when request hook is disabled

be able to force an ip

add force ip to the settings, it's very useful in dev mode

user consent checks

Add support for doapi.us

http://doapi.us/ip/ { IP }/json
This is free api, unlimited request, hope you add this

tests

configurable loggers

CI/CD

use travis or githubworkflows to test and publish on pypi

Makefile for builds and tests and deployments

protect raw data from being None

This happens on some occasions when geolocate IP couldn't find the IP's location

Error log:

backend_1      |  [2021-03-24 11:20:45,391] root         ERROR    Couldn't geolocate ip (middleware 1 140405557767496)
backend_1      | Traceback (most recent call last):
backend_1      |   File "/usr/local/lib/python3.8/site-packages/django_ip_geolocation/middleware.py", line 26, in process_request
backend_1      |     self._get_geolocation(request)
backend_1      |   File "/usr/local/lib/python3.8/site-packages/django_ip_geolocation/middleware.py", line 61, in _get_geolocation
backend_1      |     self._geolocation_data = get_geolocation(request)
backend_1      |   File "/usr/local/lib/python3.8/site-packages/django_ip_geolocation/utils.py", line 52, in get_geolocation
backend_1      |     return backend_instance.data()
backend_1      |   File "/usr/local/lib/python3.8/site-packages/django_ip_geolocation/backends/base.py", line 33, in data
backend_1      |     self._parse()
backend_1      |   File "/usr/local/lib/python3.8/site-packages/django_ip_geolocation/backends/ipdataco.py", line 26, in _parse
backend_1      |     self._continent = self._raw_data.get('continent_name')
backend_1      | AttributeError: 'NoneType' object has no attribute 'get'
backend_1      | [2021-03-24 11:20:45,533] root         ERROR    Couldn't geolocate ip (middleware 1 140405557767496)
backend_1      | Traceback (most recent call last):
backend_1      |   File "/usr/local/lib/python3.8/site-packages/django_ip_geolocation/middleware.py", line 42, in process_response
backend_1      |     self._get_geolocation(request)
backend_1      |   File "/usr/local/lib/python3.8/site-packages/django_ip_geolocation/middleware.py", line 61, in _get_geolocation
backend_1      |     self._geolocation_data = get_geolocation(request)
backend_1      |   File "/usr/local/lib/python3.8/site-packages/django_ip_geolocation/utils.py", line 52, in get_geolocation
backend_1      |     return backend_instance.data()
backend_1      |   File "/usr/local/lib/python3.8/site-packages/django_ip_geolocation/backends/base.py", line 33, in data
backend_1      |     self._parse()
backend_1      |   File "/usr/local/lib/python3.8/site-packages/django_ip_geolocation/backends/ipdataco.py", line 26, in _parse
backend_1      |     self._continent = self._raw_data.get('continent_name')
backend_1      | AttributeError: 'NoneType' object has no attribute 'get'

ipdata.co

https://docs.ipdata.co/

Use django cache to cache geolocation data

Requirements:

1. Should be implemented at middleware/decorator level
2. Should be unique per ip and backend.
3. Cache is invalidated each week.

doc: https://docs.djangoproject.com/fr/3.0/topics/cache/

raw_data is not needed for the cookies

cookies size can impact the webapp perfs, and must be minimized as possible.
thus the raw_data should be removed from cookies.

cookies not working in python 3.x

  File "django-ip-geolocation/django_ip_geolocation/middleware.py", line 46, in process_response
    set_cookie(response, cleaned_geolocation_data)
  File "django-ip-geolocation/django_ip_geolocation/utils.py", line 68, in set_cookie
    encoded_data = base64.b64encode(json.dumps(geolocation_data))
  File "/usr/lib/python3.7/base64.py", line 58, in b64encode
    encoded = binascii.b2a_base64(s, newline=False)
TypeError: a bytes-like object is required, not 'str'

IP2Location geolocation web service

Would you be considered to add another geolocation service - IP2Location web service into this project? If yes, you can sign up for a trial account at https://www.ip2location.com/web-service/ip2location for development. If you need any assistance, please let us know.

Idea of retrieving geolocation data from cookie if present

@rednaks have you thought about retrieving the geolocation from the cookie so that we don't need to call the API every single request?

Use case: a typical user will visit multiple pages per site and it's very unlikely their geolocation will change on every request. But calling the API on every single request can be changed to only when the cookie doesn't exist.

returns None

The view django_ip_geolocation.decorators.inner didn't return an HttpResponse object.
It returned None instead.

Middleware fails

Using the middleware in settings.py throws error:

File "C:\Program Files\Python37\lib\site-packages\django_ip_geolocation\middleware.py", line 15, in __init__
  super(IpGeolocationMiddleware).__init__(get_response)
TypeError: super() argument 1 must be type, not function

refactor interface

the _parse() method should be called before requesting data, not after geolocation.