refinery/refinerycms

An extendable Ruby on Rails CMS that supports Rails 6.0+

Refinery Framework

This is a little project to see if we can write a tidy underlying framework.

refinerycms's Issues

Request to turn off all resource bundling for read-only filesystems e.g. Heroku

Request to set :cache => false for all javascript_include_tags whenever you are on a read-only filesystem. Right now when the "Use Google Ajax Libraries" is true (using_google_libs = true), the javascripts don't work in the client, for instance, the menu reorder button in the admin header menu.
Suggest to add a "Read-only Filesystem" parameter in settings.

creating link from image in editor

after inserting a link into a page using the editor, then clicking add link gives the javascript error:
Error: possible_anchor_tag.match(/href="([^"]*)"/) is null
Source File: http://localhost:3000/javascripts/wymeditor/jquery.refinery.wymeditor.js?1258586292
Line: 1229

This may be the fault of the version of wymeditor bundled with refinery, but should still be addressed.

Issue with image grid

This happen when updating the site and you have preview images which have been uploaded but don't have the :grid thumbnail. Will also be an issue if users change the attachment_fu thumbnail settings. Need a fall back if there is no matching thumbnail.

Thought: You may want to have a setting where the user could specify a list of thumbnails to attempt when displaying the grid (:grid, :preview) to support older uploaded images. Maybe show a "preview not available" image if none is found.

Getting the following error:

NoMethodError in Admin/images#index

Showing vendor/plugins/images/app/views/admin/images/_grid_view.html.erb where line #8 raised:

You have a nil object when you didn't expect it!
The error occurred while evaluating nil.public_filename
Extracted source (around line #8):

5:     <%# debug image.thumbnails %>
6:     <%# break %>
7:      
>
8:          <%= image_fu image, :grid, :title => image.title %>
9:        
10:             <%= link_to image_tag('refinery/icons/application_edit.png'), edit_admin_image_path(image),
11:                                     :title => 'Edit this image' %>
Trace of template inclusion: vendor/plugins/images/app/views/admin/images/index.html.erb

RAILS_ROOT: /Users/ryanwood/code/4thpres

Application Trace | Framework Trace | Full Trace
/Users/ryanwood/code/4thpres/vendor/plugins/refinery/app/helpers/application_helper.rb:47:in `image_fu'

Requires slim_scrooge 1.0.5

Refinery requires slim_scrooge 1.0.5, but that version doesn't run on windows. slim_scrooge 1.0.4 the latest version to work on Windows.

No tabs in admin (other than logout tab)

Hi Parndt,

I just noticed something else. If i do a fresh git clone and then add the first user in the admin, this user does not see any tabs other than the logout tab. For some reason something seems to go wrong with the user plugin permissions. Do you know what might be going on ?

Thanks,

Ygor

Refinery backend and IE8

At present the backend of refinery does not work in IE8. Numerous script errors and artefacts on screen. e.g. if you press return at the end of a paragraph then the editor tries to nest

tags. hovering over paragraphs gives arrow cursor suggesting the ability to drag paragraphs around.

I had a look at the latest wymeditor and the examples provided with it however this does not present the same issues.

Images do not appear

Hi parndt, I hava a macbook pro now (with snow leopard) and am trying the latest version again. For some weird reason if I upload an image, the only image that appears on the server is the original one, none of the resized ones are created. Do you know what might be going on ? Is this perhaps some issue with rmagick ?

Thanks,

Ygor

undefined method `has_friendly_id' for NewsItem(Table doesn't exist):Class

when setting up rake db:setup and rake gems:install both give the same error

rake aborted!
undefined method `has_friendly_id' for NewsItem(Table doesn't exist):Class

application_helper in app prevents engine helper from loading

This might be a rails bug?

When a file is created in app/helpers/application_helper.rb, then Refinery complains with an undefined method "refinery_icon_tag".

Removing the helper file in app makes it work again.

Not sure if this is the expected behaviour from Rails, or in fact a bug. (One workaround might be to rename the module to e.g. layout_helper and load it with helper :layout in the controller.)

Can't put apostophes in "company name"

We can use '

Document? or patch? It crashed the demo site.

Slim_scrooge not available in windows

It appears that the latest version of refinery requires the presence of the slim_scrooge gem. But this gem is not available on Windows. Is there a solution for this?

Running rake db:setup in windows

I get the following errors.

** Couldn't load the config/environment file because something went wrong ... ***
*
* Don't worry, we'll do it the normal way and in the config/boot instead...
Couldn't create database for {"adapter"=>"mysql","username"="root", "database", collation: utf8_unicode_ci (if you set the charset manually make sure you have a matching collation)
rake aborted!
Access denied for user 'root'@'localhost' (using password: YES)

Standardize whitespace in source

I noticed you committed a change which added back some whitespace on an empty line that I stripped out in my changeset.

Trailing whitespace adds a pain point to merging. Personally, I strip it all out when saving. Can we standardize and do some housekeeping so it's nicer to work with?

Permissions don't change on logout

I created two users with differing permissions (plugin access). Because plugins are stored in a global var ($plugins), they are not reset when I log out and log back in. I have to restart the app to see the changes.

Specifically if you log in with a user that has access to no plugins and then try to login as a user with access to more plugins, the additional plugins will not show up. So on user change, plugins are subtracted, but never added back.

problem with adding news item

I am not able to add any news item to my refinery app

I did the following steps:

sudo gem install refinerycms (installed the latest version refinerycms-0.9.6.15)
refinery refinery_testapp
rake db:setup
rake gems:install

Then I launched the app and add a user.
After I created a news item with a publication date in the past I didn't see it on the newssection of the site.

Is this a bug?

Each Plugin under the User Tab is Listed Twice

When I use the fast-debugger or when running from Heroku, each plugin under the User tab is listed twice. When editing a user, under "plugin access", I see two checkboxes for "images", two for "news", and so on.
Running locally without the fast-debugger is fine.

rake db:seed fails in new install of refinery 0.9.6.2, rails 2.3.5

First time Refinery user here. I've installed all necessary gems with rake gems:install, and have verified that my versions meet the minimum requirements listed in environment.rb. Using rails 2.3.5. I issue the rake db:setup command and received an error. Looked at the trace and the error is with the rake db:seed command. So I wiped out the database to start again, and issued these steps:

rake db:create
rake db:schema:load
rake db:seed --trace

The create and schema load tasks run successfully. Here is the output of the failed seed task:

(in /home/developer/example.com)
** Invoke db:seed (first_time)
** Invoke environment (first_time)
** Execute environment
rake aborted!
stack level too deep
/usr/lib/ruby/gems/1.8/gems/friendly_id-2.3.0/lib/friendly_id/configuration.rb:117:in `strip_diacritics='
/usr/lib/ruby/gems/1.8/gems/friendly_id-2.3.0/lib/friendly_id/configuration.rb:117:in `strip_diacritics='
/usr/lib/ruby/gems/1.8/gems/friendly_id-2.3.0/lib/friendly_id/configuration.rb:83:in `send'
/usr/lib/ruby/gems/1.8/gems/friendly_id-2.3.0/lib/friendly_id/configuration.rb:83:in `initialize'
/usr/lib/ruby/gems/1.8/gems/friendly_id-2.3.0/lib/friendly_id/configuration.rb:82:in `each'
/usr/lib/ruby/gems/1.8/gems/friendly_id-2.3.0/lib/friendly_id/configuration.rb:82:in `initialize'
/usr/lib/ruby/gems/1.8/gems/friendly_id-2.3.0/lib/friendly_id/active_record2.rb:16:in `new'
/usr/lib/ruby/gems/1.8/gems/friendly_id-2.3.0/lib/friendly_id/active_record2.rb:16:in `has_friendly_id'
/usr/lib/ruby/gems/1.8/gems/refinerycms-0.9.6.2/vendor/plugins/refinery/lib/refinery.rb:16:in `has_friendly_id'
/usr/lib/ruby/gems/1.8/gems/refinerycms-0.9.6.2/vendor/plugins/news/app/models/news_item.rb:6
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:380:in `load_file'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:521:in `new_constants_in'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:379:in `load_file'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:259:in `require_or_load'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:425:in `load_missing_constant'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:80:in `const_missing'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:92:in `const_missing'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:437:in `load_missing_constant'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:80:in `const_missing'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:437:in `load_missing_constant'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:96:in `const_missing'
/usr/lib/ruby/gems/1.8/gems/refinerycms-0.9.6.2/vendor/plugins/news/rails/init.rb:6:in `evaluate_init_rb'
/usr/lib/ruby/gems/1.8/gems/refinerycms-0.9.6.2/vendor/plugins/refinery/lib/refinery/plugin.rb:5:in `register'
/usr/lib/ruby/gems/1.8/gems/refinerycms-0.9.6.2/vendor/plugins/news/rails/init.rb:1:in `evaluate_init_rb'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/plugin.rb:158:in `evaluate_init_rb'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/core_ext/kernel/reporting.rb:11:in `silence_warnings'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/plugin.rb:154:in `evaluate_init_rb'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/plugin.rb:48:in `load'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/plugin/loader.rb:38:in `load_plugins'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/plugin/loader.rb:37:in `each'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/plugin/loader.rb:37:in `load_plugins'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/initializer.rb:369:in `load_plugins'
/usr/lib/ruby/gems/1.8/gems/refinerycms-0.9.6.2/vendor/plugins/refinery/lib/refinery/initializer.rb:44:in `load_plugins'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/initializer.rb:165:in `process'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/initializer.rb:113:in `send'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/initializer.rb:113:in `run'
/usr/lib/ruby/gems/1.8/gems/refinerycms-0.9.6.2/vendor/plugins/refinery/lib/refinery/initializer.rb:39:in `run'
/home/developer/example.com/config/environment.rb:15
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:156:in `require'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:521:in `new_constants_in'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:156:in `require'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/tasks/misc.rake:4
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:636:in `call'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:636:in `execute'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:631:in `each'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:631:in `execute'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:597:in `invoke_with_call_chain'
/usr/lib/ruby/1.8/monitor.rb:242:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:590:in `invoke_with_call_chain'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:607:in `invoke_prerequisites'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:604:in `each'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:604:in `invoke_prerequisites'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:596:in `invoke_with_call_chain'
/usr/lib/ruby/1.8/monitor.rb:242:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:590:in `invoke_with_call_chain'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:583:in `invoke'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2051:in `invoke_task'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in `top_level'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in `each'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in `top_level'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2068:in `standard_exception_handling'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2023:in `top_level'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2001:in `run'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2068:in `standard_exception_handling'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1998:in `run'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/bin/rake:31
/usr/bin/rake:19:in `load'
/usr/bin/rake:19

ActionMailer::Base.template_root problem

When the inquiry plugin init loads it sets the ActionMailer::Base.template_root, this is preventing the application level mailers from working. It appears app/views is not in the list of paths when attempting to find the template. When I comment out that line it works ok.

Is there some other way to extend the action mailer base template paths rather than changing the template root completely?

App does not seem to work when using a sub uri

I am trying to set this up using a sub-uri and things dont seem to work properly. I have added the usual RailsBaseURI in the .htaccess and also config.action_controller.relative_url_root = '/myapp' in my environment.rb but I am still having problems with the admin module. The links on the tabs seem to not be using the sub uri and going to the base of the domain.

I have had a look in the code but am new to ruby and rails so couldnt figure out what was wrong.

Excellent product by the way! Nice one!

Cheers

Code It

Architectural question

Hi, another question from me :) Although I definitely like the way that refinery uses (rails) plugins to implement additional features, I am wondering about the reasons for having the refinery core in the form of a plugin. Wouldn't it be nicer to have the core reside somewhere in the app/lib part of the application ?

Ygor

Nice to have: friendly_id unspecified

Hi -- when running rake tasks, people will initially get:

undefined method `has_friendly_id' for NewsItem(Table doesn't exist):Class

unless they have the friendly_id gem. Since other gems (like aasm) are config.gem'd it would be nice to have friendly_id as well, to prevent people like me from having to google search.

Feature request: CKEditor WYSIWYG editor

I think CKEditor is a lot better than the current WYSIWYM editor. It is much more usable to the average Joe than the current one. Users love it.

CKEditor is very powerful, stable on all browsers, fast, outputs valid XHTML, excellent paste from Word, very accessible, has good undo system, cross browser, developer friendly, etc.

http://ckeditor.com/

UI way to hide the page from menues

Hi,

How can i hide the page (not making it a draft, but just not showing it in the menu) from user interface of refinery?

Reordering may fail if object created with a numeric title.

Even if the title is then renamed, e.g. 1 renamed to One it still seems to exhibit weird reordering until the object is deleted and recreated with an alpha title. Could be something to do with slugs..

Page Parts

When Page Parts is disabled, on edit page a js error is raised when try to connect the events to the missing Page Parts html controls.

No ui way to remove page section

I don't know how to do this without database frontend :)

no wysiwyg editor with disabled firebug

When I click to edit a page I can only see a text box, no editor.
If firebug is enabled all seems to work ok.

Archlinux
Firefox 3.5.3
ruby 1.8.7
Rails 2.3.4

Adding an image has wrong url when use S3

I got Refinery working with S3 (using attachment_fu). Everything works great except when you add an image to a page part, it prepends '/images/system' in front of the S3 url which breaks it.

initail setup,but face one problem.

use sqlite3
config/database:
login: &login
adapter: sqlite3
pool: 5
timeout: 5000

development:
database: db/refine_dev
<<: *login

rake db:migrate ok
rake db:schema:load ok
rake db:seed error:
└──>rake db:seed --trace
(in /Users/xiaodeshi/projects/refinerycms)
rake aborted!
Don't know how to build task 'db:seed'
/usr/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake.rb:1704:in []' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake.rb:2026:ininvoke_task'
/usr/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake.rb:2005:in top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake.rb:2005:ineach'
/usr/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake.rb:2005:in top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake.rb:2044:instandard_exception_handling'
/usr/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake.rb:1999:in top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake.rb:1977:inrun'
/usr/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake.rb:2044:in standard_exception_handling' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake.rb:1974:inrun'
/usr/local/lib/ruby/gems/1.8/gems/rake-0.8.4/bin/rake:31
/usr/local/bin/rake:19:in `load'
/usr/local/bin/rake:19

now: ./script/server
view public site: error
NoMethodError in Pages#home

Showing vendor/plugins/refinery/app/views/shared/_submenu.html.erb where line #1 raised:

You have a nil object when you didn't expect it!
The error occurred while evaluating nil.root

Extracted source (around line #1):

1: <% children = @page.root.children %>
2: <ul id='submenu'<%= " class='empty'" if children.empty? %>>
3: <%= render :partial => "/shared/submenu_branch", :collection => children %>
4:

so no idea.please test more.thanks.

Cancel page edit

Hi
Editing a page if you insert a link or image after close the dialog the Cancel link of the page form not work anymore.

Seems to be binded to tb_remove after the dialog, removing the class "close_dialog" fix the problem. But the js code could have some others side effects.

h

Showing a newly created page on a fresh refinery install fails

The error:
You have a nil object when you didn't expect it!
The error occurred while evaluating nil.public_filename
Extracted source (around line #6):

3:

4:

<%= page_title %>

5: <%= @page[:body] %>
6: <%= image_fu Image.first %>
7:

8:

9: <%= @page[:side_body] %>

Image.first probably returns nil as I don't have any images defined and that probably causes the error.

minor save & continue editing issues

these are just polish, but:

when editing side body or another section, save and continue editing returns you to the body tab, and I think it should keep you on the tab you're working on.

when creating a new page and then pressing Save & Continue editing, it takes you to creating another new page instead of editing the new page you just created.

Image linking

I think images could benefit from the use of friendly_id (slugs) so that if an image is "renamed" (uploaded over the top of an existing image with a new image name) then the links to that image would still work.
Then images would have a url like:
/images/friendly/my-image.jpg
or
/images/friendly/my-image

"friendly" being some subdirectory name that we come up with so that they can't conflict with programmatically added images..

This would also abstract the use of attachment_fu which would make it easier to swap this out with another plugin if the desire ever arose to do so..

Thoughts? Would this work? Would it be better?

theme capitalization

The builtin themes don't work when you switch them using the Themes tab, but going into Settings and lowercasing the theme name fixes it. The original setting is lowercase and works.

Migrations do not apply cleanly on commit d525f0cf496932c82e048b73642a3aea1cf05e26

After updating my local repo to the last version (d525f0c) running rake db:migrate throws errors.

The first error was this:

~/code/refinery[upstream]% rake db:migrate
(in /Users/ryanwood/code/refinery)
==  ResaveRefinerySettingsThroughSerializer: migrating ========================
==  ResaveRefinerySettingsThroughSerializer: migrated (0.0069s) ===============

==  MigratePluginsToArrayFormatOnUsers: migrating =============================
rake aborted!
An error has occurred, this and all later migrations canceled:

SQLite3::SQLException: no such table: user_plugins: SELECT * FROM "user_plugins" WHERE ("user_plugins".user_id = 2)  ORDER BY position ASC

That because you are using the User object that now has a reference to the user_plugins table which has not yet been created. So I applied the second two migrations manually. That helped but not I have other errors.

I noticed that the down steps are not really undoing the migration is a couple of cases so running a db:migrate:redo is failing as well.

I'll walk through it manually to get the db in order, but thought you may want to rework the migrations so they apply cleanly after the code is updated.

Pasting into Page Body parts

When you try to paste (Ctrl V) into a page part wysiwyg editor you get a window offering paste from word if you then press (Ctrl V) to again to paste the text you get another box underneath the first one. I believe the problem is that the text area does not get focus.

It would also be good to stop the box from appearing again if it already is visible.

Adding and removing page parts

This feature seems to be broken at the moment.

After editing "New PageParts" setting and setting it to true you get the + and - icons when editng a page. When you are in a page part ie side body and click the - you are informed that the part is deleted however go back into the page and it is back.

If you click the + and enter in the new page part title then under the first tab you get the output from the dashboard and then below that is the save. Clicking save also does not add the page part.

Image upload

Hi, I just installed refinery cms and I must say I'm really impressed! The system is simple to use and can at the same time be easily extended! Great work! I do however encounter a problem. I'm running ruby on rails on windows XP with Rmagick as image processor. Now when I try to create a new image (under images tab), all appears to go wel, i.e. there are no error messages, but the images does not appear in the list and is also not saved to disk. This is strange, since the images controller's create action clearly starts with a Image.create(params[:image) and @image.valid? returns true.

In addition, if I include an additional @image.save after the if saved line (i.e. line 42) in the images_controller.rb, then the image is in fact saved to the proper directory and does appear! Does anyone know what might be causing this strange behaviour?

Thanks!

Ygor

Refinery too big?

Is the code source of refinery too big?
Is there any way we can reduce this (besides removing vendor/rails)

Can't add comma to setting value

Due to the eval call in refinery settings, you can't have a string with a comma in it. For instance I added a setting called 'meta-description' with a value of 'Ryan, Todd' and get the following error:

SyntaxError in Admin/refinery_settings#index

Showing vendor/plugins/refinery_settings/app/views/admin/refinery_settings/index.html.erb where line #25 raised:

(eval):1:in `value': compile error
(eval):1: syntax error, unexpected $end, expecting '='
Ryan, Todd
^

If I remove the comma all is fine. I'd create a patch, but I'm not entirely sure of the intent of the eval call. Maybe using ERB would be a better option? Let me know if I can help.

-Ryan

running db:schema:load blows up with - no such file to load -- unicode

rake db:schema:load

rake aborted!
no such file to load -- unicode

Windows: IE8 javascript errors for wym editor, page sorting en image insert

When trying to sort the page, or upload an image or use the wym editor, javascript errors occur. Has the system been tested on IE 8 ?

Possible bug in the user index.html.erb

This line is giving me an error when I click on the user tab. Version 0.9.5.23
:title => "Remove this user forever" if user.ui_deletable?(current_user) %>

The error has to do with the superuser:

ActionView::TemplateError (undefined method `superuser' for #User:0x7f766dc31190) on line #19 of /usr/lib/ruby/gems/1.8/gems/refinerycms-0.9.5.23/vendor/plugins/authentication/app/views/admin/
16: <%= link_to refinery_icon_tag('delete.png'), admin_user_path(user),
17: :confirm => "Are you sure you want to delete '#{user.login}'?",
18: :class => "cancel", :method => :delete,
19: :title => "Remove this user forever" if user.ui_deletable?(current_user) %>
20: <%= link_to refinery_icon_tag('application_edit.png'), edit_admin_user_path(user),
21: :title => 'Edit this user' %>
22: <%= mail_to user.email, refinery_icon_tag('email_go.png'), :title => 'Email this user' %>

refinerycms (0.9.5.23) vendor/plugins/authentication/app/models/user.rb:125:in `ui_deletable?'

---

I replaced it with the following from an earlier version and it is now working again.
:title => "Remove this user forever" if @users.size > 1 and user.id != current_user.id %>

jqueryui Version 1.8 not found

Request to have jqueryui version 1.7.2 loaded instead.

rake db:schema:load does not work

Hi,

Just pulled the latest version (8a34d1b) for a new
project. But when I do rake db:schema:load after rake db:create it blows up:

rake db:schema:load --trace
(in     /Users/joe/projects/newproject)
** Invoke db:schema:load (first_time)
** Invoke environment (first_time)
** Execute environment
rake aborted!
Mysql::Error: Table 'newproject_development.news_items' doesn't exist: SHOW FIELDS FROM `news_items`
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activerecord-2.3.4/lib/active_record/connection_adapters/abstract_adapter.rb:219:in `log'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activerecord-2.3.4/lib/active_record/connection_adapters/mysql_adapter.rb:319:in `execute'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activerecord-2.3.4/lib/active_record/connection_adapters/mysql_adapter.rb:465:in `columns'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activerecord-2.3.4/lib/active_record/base.rb:1271:in `columns'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/friendly_id-2.2.0/lib/friendly_id.rb:65:in `has_friendly_id'
/Users/joe/projects/newproject/vendor/plugins/news/app/models/news_item.rb:5
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:380:in `load_file'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:521:in `new_constants_in'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:379:in `load_file'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:259:in `require_or_load'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:425:in `load_missing_constant'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:80:in `const_missing'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:92:in `const_missing'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:437:in `load_missing_constant'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:80:in `const_missing'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:437:in `load_missing_constant'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:96:in `const_missing'
/Users/joe/projects/newproject/vendor/plugins/news/init.rb:7:in `evaluate_init_rb'
/Users/joe/projects/newproject/vendor/plugins/refinery/lib/refinery/plugin.rb:5:in `register'
/Users/joe/projects/newproject/vendor/plugins/news/init.rb:1:in `evaluate_init_rb'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rails-2.3.4/lib/rails/plugin.rb:158:in `evaluate_init_rb'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/core_ext/kernel/reporting.rb:11:in `silence_warnings'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rails-2.3.4/lib/rails/plugin.rb:154:in `evaluate_init_rb'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rails-2.3.4/lib/rails/plugin.rb:48:in `load'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rails-2.3.4/lib/rails/plugin/loader.rb:38:in `load_plugins'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rails-2.3.4/lib/rails/plugin/loader.rb:37:in `each'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rails-2.3.4/lib/rails/plugin/loader.rb:37:in `load_plugins'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rails-2.3.4/lib/initializer.rb:369:in `load_plugins'
/Users/joe/projects/newproject/vendor/plugins/refinery/lib/refinery/initializer.rb:24:in `load_plugins'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rails-2.3.4/lib/initializer.rb:165:in `process'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rails-2.3.4/lib/initializer.rb:113:in `send'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rails-2.3.4/lib/initializer.rb:113:in `run'
/Users/joe/projects/newproject/vendor/plugins/refinery/lib/refinery/initializer.rb:19:in `run'
/Users/joe/projects/newproject/config/environment.rb:13
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:156:in `require'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:521:in `new_constants_in'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/activesupport-2.3.4/lib/active_support/dependencies.rb:156:in `require'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rails-2.3.4/lib/tasks/misc.rake:4
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:636:in `call'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:636:in `execute'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:631:in `each'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:631:in `execute'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:597:in `invoke_with_call_chain'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/1.8/monitor.rb:242:in `synchronize'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:590:in `invoke_with_call_chain'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:607:in `invoke_prerequisites'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:604:in `each'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:604:in `invoke_prerequisites'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:596:in `invoke_with_call_chain'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/1.8/monitor.rb:242:in `synchronize'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:590:in `invoke_with_call_chain'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:583:in `invoke'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2051:in `invoke_task'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in `top_level'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in `each'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in `top_level'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2068:in `standard_exception_handling'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2023:in `top_level'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2001:in `run'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2068:in `standard_exception_handling'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1998:in `run'
/opt/ruby-enterprise-1.8.7-20090928/lib/ruby/gems/1.8/gems/rake-0.8.7/bin/rake:31
/opt/ruby-enterprise-1.8.7-20090928/bin/rake:19:in `load'
/opt/ruby-enterprise-1.8.7-20090928/bin/rake:19

Feature request: option to select image size when inserting it into a page

Hi,

Thanks again for the great work. Refinery is becoming a top notch system! I particularly applaud the change to jquery! I have one feature request though. I would like to see a select menu displaying the image size (thumnail, original, etc..) when adding an image to a page.

Thanks,

Ygor

Blows up at rake db:setup

Hi,

When I do rake db:setup it blows up:

*** Couldn't load the config/environment file because something went wrong... ***
*** Don't worry, we'll do it the normal way and load in config/boot instead... ***
** Invoke db:setup (first_time)
** Invoke db:create (first_time)
** Invoke db:load_config (first_time)
** Invoke rails_env (first_time)
** Execute rails_env
** Execute db:load_config
** Execute db:create
db/refinery_development already exists
** Invoke db:schema:load (first_time)
** Invoke environment (first_time)
** Execute environment
rake aborted!
Could not find table 'refinery_settings'
/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/connection_adapters/sqlite3_adapter.rb:29:in table_structure' /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/core_ext/object/misc.rb:39:inreturning'
/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/connection_adapters/sqlite3_adapter.rb:28:in table_structure' /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/connection_adapters/sqlite_adapter.rb:228:incolumns'
/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/base.rb:1271:in columns' /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/base.rb:1284:incolumn_names'
/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/base.rb:1297:in column_methods_hash' /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/base.rb:1986:inall_attributes_exists?'
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in all?' /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/base.rb:1986:ineach'
/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/base.rb:1986:in all?' /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/base.rb:1986:inall_attributes_exists?'
/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/base.rb:1842:in method_missing_without_paginate' /home/daintonh/.gem/ruby/1.8/gems/will_paginate-2.3.12/lib/will_paginate/finder.rb:170:inmethod_missing'
/home/daintonh/veryona.com/vendor/plugins/refinery_settings/app/models/refinery_setting.rb:35:in method_missing' /home/daintonh/veryona.com/vendor/plugins/refinery_settings/app/models/refinery_setting.rb:62:in[]'
/home/daintonh/veryona.com/vendor/plugins/themes/rails/init.rb:20:in evaluate_init_rb' /usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/plugin.rb:158:inevaluate_init_rb'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/core_ext/kernel/reporting.rb:11:in silence_warnings' /usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/plugin.rb:154:inevaluate_init_rb'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/plugin.rb:48:in load' /usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/plugin/loader.rb:38:inload_plugins'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/plugin/loader.rb:37:in each' /usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/plugin/loader.rb:37:inload_plugins'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/initializer.rb:369:in load_plugins' /home/daintonh/veryona.com/vendor/plugins/refinery/lib/refinery/initializer.rb:76:inload_plugins'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/initializer.rb:165:in process' /usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/initializer.rb:113:insend'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/initializer.rb:113:in run' /home/daintonh/veryona.com/vendor/plugins/refinery/lib/refinery/initializer.rb:52:inrun'
/home/daintonh/veryona.com/config/application.rb:32
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in gem_original_require' /usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:inrequire'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:156:in require' /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:521:innew_constants_in'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:156:in require' /home/daintonh/veryona.com/config/environment.rb:2 /usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:ingem_original_require'
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in require' /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:156:inrequire'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:521:in new_constants_in' /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:156:inrequire'
/usr/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/tasks/misc.rake:4
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:636:in call' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:636:inexecute'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:631:in each' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:631:inexecute'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:597:in invoke_with_call_chain' /usr/lib/ruby/1.8/monitor.rb:242:insynchronize'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:590:in invoke_with_call_chain' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:607:ininvoke_prerequisites'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:604:in each' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:604:ininvoke_prerequisites'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:596:in invoke_with_call_chain' /usr/lib/ruby/1.8/monitor.rb:242:insynchronize'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:590:in invoke_with_call_chain' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:607:ininvoke_prerequisites'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:604:in each' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:604:ininvoke_prerequisites'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:596:in invoke_with_call_chain' /usr/lib/ruby/1.8/monitor.rb:242:insynchronize'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:590:in invoke_with_call_chain' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:583:ininvoke'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2051:in invoke_task' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:intop_level'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in each' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:intop_level'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2068:in standard_exception_handling' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2023:intop_level'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2001:in run' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2068:instandard_exception_handling'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1998:in run' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/bin/rake:31 /usr/bin/rake:19:inload'
/usr/bin/rake:19

Amazon S3 Fixes got stomped

I just merged upstream changes into a site that is using S3. It looks like commit 0cb0524 undid the fix that was committed in 8877024. So the site is broken again...

Do you want me to fix it again or can you revert that part of the the commit?

Reorder menu button not working on Firefox and Safari

I tried it on the online demo and it doesnt work.

refinery 0.9.6.4 clean install does not load with Passenger

Initially reported in issue #34, a clean install of refinery does not work on my server using Passenger. Other rails apps are working correctly. With 0.9.6.4, the refinery app homepage does not load (with 0.9.6.2, the homepage would load, but /users/new would not). When I try to load the default page, the browser just spins indefinitely. No error messages appear in the Apache error log, nor in the application's production log. Passenger appears to hang, because other Rails apps on the server stop responding once I try to load the refinery app homepage.

I don't see any useful log info anywhere, but if anyone has suggestions of somewhere else I should look I will post any additional info here.