regomne/mabi-pack2

New pack utilities for Mabinogi

mabi-pack2's Issues

[request] Adding .jpg and .raw to compression list

#3
The reason I asked for version and compression as CLI arguments was because it looked like you were using them in IT_VERSION and compress_to_vec_zlib(&stm, 5), but if it's not needed then I guess it's fine.

I was able to lower my uotiara_00001.it down from 70MB to 50MB by adding .jpg and .raw extensions because UO Tiara includes edited HD minimaps and they still work fine in the game.

算法有异动

Err: header checksum wrong
但是我和官方的version.txt对了 文件校验值是对的
是不是文件格式更了?
按照正常方案 解出的文件头的version是59

Any .it file created containing _define will cause client crashes

data\material_define..
any .it file created containing this will cause a crash on client upon load.
removing this folder and repacking removes the crash
this folder and its contents are needed to create custom textures and such.

Replacing enc.c with Snow2 stream cipher

.it pack use Snow2 cipher

Snow2 implement: https://github.com/k0dai/fsbench-density/blob/cb719fdb07354e0c39a255d8d12f3cbd50b44406/src/codecs/ecrypt/snow2_fast.c

it could be replaced by this:
c_init_enc_state => snow_loadkey_fast
c_update_enc_state => snow_keystream_fast

additional:
snow_loadkey_fast use u32, assembly code would be movzx, it may cause a bad keystream, I think i32 would be correct.

在自己测试时发现了一个诡异的事情:

我手贱把

mabi-pack2/src/snow2.h

Lines 65 to 72 in 7b52603

	typedef struct
	{
	u32 keysize;
	s8 key[32]; /* MODIFIED in Mabinogi, original type is u8 */
	u32 s15, s14, s13, s12, s11, s10, s9, s8, s7, s6, s5, s4, s3, s2, s1, s0;
	u32 r1, r2;
	} Snow2_ctx;

改成了

typedef struct
{
  u32 keysize;
  u8 key[32]; /* MODIFIED in Mabinogi, original type is u8 */

  u32 s15, s14, s13, s12, s11, s10, s9, s8, s7, s6, s5, s4, s3, s2, s1, s0;
  u32 r1, r2; 
} Snow2_ctx;

然后跑cargo test 直接过了...

我怀疑洛奇可能是直接用了u8(

---

单元测试正常≠实际测试正常