reimagined/resolve

Full stack CQRS, DDD, Event Sourcing framework for Node.js

resolve's Issues

Replace abstract SecurityContext to JWT

Now SecurityContext for command handler and query resolvers is implemented as custom free-form object provider, which should be filled and verified manually by end programmer.
It should be replaced by JWT, including verify tokens on server side out-of-the-box.

Memory driver throws exception if it is used in reSolve server config

The 'storage' field has to params - 'driver' and 'params'. All storage drivers has input as object of options excluding memory driver. It has events array. So if you pass object as params, they are interpriated as array of events and then tried to be used as array by the 'filter' function call. It leads to the error.

[resolve-scripts] Implement default values for `rootComponent` and `createReducer`

Now configuration fields rootComponent and createReducer should be manually specified in resolve.client.config.js and resolve.server.config.js, which caused by necessity of implementation custom routing and data loading flows on client and server side renderings.
It's useful in general case, but we should provide ability for default behaviour, in which rootComponent and createReducer will just be taken from pre-determinated files in appropriate folder, to provide ability for fast start for very simple application.

[resolve-scripts] Add README.md

[resolve-query] Add GraphQL Variables

Use case:
/api/query/comments?query=query comment {CommentById(id: $id)}&variables={id:"3d013c8b-10de-410e-a98f-3c48bb3be107"}

Provide a change log

It is impossible to handle error if it is thrown in aggregate event handler

1. Add aggregate command with event as result with type 'created'
2. Add 'created' event handler to aggregate with error that is thrown inside
3. Execute command with some aggregate id - handler is not executed because no one event is stored yet
4. Execute it again with the same aggregate id - handler is executed once with stored event

Error throwed in handler is impossible to catch wrapping the 'executeCommand' function by try-catch construction

No necessary data in command if its execution is failed

I want to handle 3 steps of command execution in reducer. That's what I do:

export default (state = Immutable({}), action) => {
  switch (action.type) {
    case '@@resolve/SEND_COMMAND': {
      switch (action.command.type) {
        case 'createStory': {
          return action.status.error // or action.command.error
            ? // error handling
            : // command sending handling
        }
        default: {
          return state;
        }
      }
    }
  }
};

The first problem is that if error is thrown, action.command is excluded so I can't detect whether I handle the createStory command error or not.
The second problem is that if there is not error, action.status is not included to the action. So I need to have to checks - action.status and then action.status.error to put error.

Here is solutions as I see them:

1. Do not exclude command first 'cause it contains important information
2. Use action.command to put error not to add new fields that leads to extra conditions.

[resolve-redux] Add default event handler ['SET_STATE'/'REPLACE_STATE']

[REPLACE_STATE]: (state, action) => {
    if (action.readModelName === name) {
        return action.state;
    }
    return state;
}

[resolve-scripts] Can't parse initial state, SyntaxError: Invalid or unexpected token

I created storage.json for Hacker News Demo

Rename merge to mergeState in resolve-redux package

Now resolve-redux actions have merge and replaceState actions. They have to have consistency API. That means we have to rename or merge or replaceState

[resolve-scripts] Add JSON.parse for gqlVariables

Error: Variables must be provided as an Object where each property is a variable value. Perhaps look to see if an unparsed JSON string was provided.
    at invariant (/home/mrcheater/hacker-news-demo/node_modules/graphql/jsutils/invariant.js:19:11)
    at assertValidExecutionArguments (/home/mrcheater/hacker-news-demo/node_modules/graphql/execution/execute.js:173:153)
    at executeImpl (/home/mrcheater/hacker-news-demo/node_modules/graphql/execution/execute.js:118:3)
    at execute (/home/mrcheater/hacker-news-demo/node_modules/graphql/execution/execute.js:113:150)
    at _callee3$ (/home/mrcheater/hacker-news-demo/node_modules/resolve-query/dist/index.js:188:57)
    at tryCatch (/home/mrcheater/hacker-news-demo/node_modules/regenerator-runtime/runtime.js:65:40)
    at Generator.invoke [as _invoke] (/home/mrcheater/hacker-news-demo/node_modules/regenerator-runtime/runtime.js:303:22)
    at Generator.prototype.(anonymous function) [as next] (/home/mrcheater/hacker-news-demo/node_modules/regenerator-runtime/runtime.js:117:21)
    at step (/home/mrcheater/hacker-news-demo/node_modules/resolve-query/dist/index.js:15:191)
    at /home/mrcheater/hacker-news-demo/node_modules/resolve-query/dist/index.js:15:361

[resolve-es] Deny to pass timestamp to EventStore

[resolve-scripts] Fix src/server/event_store.js

Replace:

const subscribe = bus.onEvent;

to

const subscribe = store.onEvent;

Server sides HMR doesn't work in some cases

Server-side rendering breaks hot reloading in resolve-scripts

I think it is unnecessary to use SSR in dev mode. I start server, then change some component but it is cached on the server side. Right now the only way is to restart server. So it neutralizes hot reloading.

[resolve-scripts] Add support for subdirectory

I need support for subdirectories for deploying multiple applications on a single domain

/static/ -> /${subdirectory}/static
/api/commands/ -> /${subdirectory}/api/commands
/api/:queryName/ -> /${subdirectory}/api/:queryName
ws:/// -> ws://${subdirectory}/
html-markup-template <script src="/bundle.js"> -> <script src="/${subdirectory}/bundle.js">

resolve.config.js

module.exports = {
   //...
   subdirectory: "some-app-name"
}

UnhandledPromiseRejectionWarning in resolve-scripts output

[resolve-query] Rename "projection" to "readModel" or "collection"

Cross read-model GraphQl queries

Now every GraphQL schema and appropriate resolvers are bound to each read-model separately, so, even custom resolver can't reach access to current state of another read-model.
Such behaviour should be refactored - graphql schema and resolvers should work around all read-models in current resolve-query instance.
After refactoring behaviour of on-demand read-models should stay.

[resolve-scripts] The script breaks if my application does not contain folder /static

Error: ENOENT: no such file or directory, stat '/some-application/static'

ROOT_DIRECTORY has to start with '/'

Add source map on client and server by default

Add it for dev mode.

Ability for configure output config

Now configuration in output-stats-config.js prevents all output from webpack.
In case of error in application's source code, there no ability to find error.
MUST be configured by environment variable or command line flag

Issue with bootstraping react-scripts

The 'react-scripts' package is not bootstrapped correctly when it is not prepublished.

Merge `subscribeByEventType` and `onEvent` in ES

[HMR] Error: Aborted because <filename> is not accepted

[resolve-query] Fix README.md

NOW:

const state = query('User');

AFTER:

query('User').then(state => {
    ///...
})

Delete .babelrc, .flowconfig, notes.md from template

Resolve-storage is redundant

It's possible to pass storage driver to event store without creation resolve-storage. At fact, resolve storage is the same as his drivers only with additional function onEventSaved that used only in tests.
Also, need to think about removing resolve-bus for consistency. In this case, resolve-es will accept only bus and storage drivers.

Lerna & socket.io issue

1. Lerna does not perform correct bootstrapping for dependent modules, so when launching examples from it's appropriate directories, node_modules will not installed, so webpack/babel plugins can't be found
2. Socket.io server part library perform including dependent library in run-time, which is incompatible with bundling mechanism. Should be researched, how to fix it in general case, and socket.io, in particular.

Impossible to handle response that does not trigger event

In sendCommandMiddleware from resolve-redux there is an error handing. This error is thrown if there is no connection. Other case is when server response with error. The fetch interpriates this as success and put all info to the response. So command execution is failed but request is executed successfully. In this case I can't handle error (e.g. sending info from form being unauthorized).

Investigate server bundling

Now create-resolve-app perform bundling for server and client code by isomorphic webpack configs.
Such schema allows easily attach React plugins, like CSS stylizers, both for client and server-side rendering. If server side will not be bundled by webpack, it will cause some issues, including absence for some CSS plugins for Babel, and thus impossibility of server-side rendering.
But bundling server-side code also affects other issues, like problems with npm-packages, which perform loading code in runtime, for example, socket.io. In case of socket.io there is known solution (https://stackoverflow.com/questions/46098113/socket-io-and-server-side-webpack-bundling#comment79160961_46098113 ), but issue with server-side bundling should be investigate for common case.

[resolve-storage-file] Make a valid JSON format

Storage file contains none-valid JSON format, so you can't actually change it properly.

[resolve-scripts] Add .npmignore

test
src

Show only important information in webpack log

Remove fetch-more-middleware and fetchMore action

It is not used anymore

[resolve-scripts] ExtendWebpack parameters are functions instead of objects

File: resolve.build.config.js

Implement raw event saver

Implement raw event saver in event store to provide ability for saving event with custom timestamp. It's necessary when using import scripts.

Add possibility to write resolve.build.config in ES6

It is impossible to change server port

Investigate "Socket connected"

Now resolve-script has debug output with information about connecting new sockets.io clients, i.e. new browser session. But this message appears also when one non-closing tab in browser existed, so maybe performed reconnection are caused some bugs in code.
More than, after investigation debug output should be removed

fix init script warnings

Docs improvements

• Prepare image that shows how packages interact each with other and describes CQRS in our definitions. For example:
  
• Describe each package in more details (for example params for resolve-bus-rabbitmq, resolve-bus-zmq drivers)
• Change setTrigger name to subscribe

[resolve-scripts-with-router-4] Warnings about CORS

[resolve-scripts] Support for colors in console output

Rename loadEventsByAggregateId to loadEventsByAggregateIds

loadEventsByAggregateId receives an Array of aggregateIds.
It should be renamed to loadEventsByAggregateIds.

Rename `setTrigger` to `subscribe` in bus drivers

[resolve-redux] Add actionCreator "setSubscription"

Adding custom css looks weird

const bundleCssSource =
    process.env.NODE_ENV === 'production'
        ? `${BASEDIR}/static/bundle.css`
        : 'http://localhost:3001/bundle.css';


<div className="app">
    <Helmet>
        <link rel="stylesheet" type="text/css" href={bundleCssSource} />
    </Helmet>