rekado/lv2-mdametapiano

common repo for lv2-mdaEPiano and lv2-mdaPiano

lv2-mdametapiano's Issues

make TYPE=mdaEPiano fails

While plainmake for mdaPiano works fine, given TYPE=mdaEPiano fails with:

g++ -fPIC -DPIC -O -g -Wall -pedantic -DEPIANO -shared *.cpp `pkg-config --cflags --libs lvtk-plugin-1` -o mdaEPiano.so
mdaPiano.cpp: In member function ‘void mdaPiano::handle_midi(uint32_t, unsigned char*)’:
mdaPiano.cpp:150:14: error: ‘p_modulation’ was not declared in this scope
mdaPiano.cpp: At global scope:
mdaPiano.cpp:315:12: warning: ‘_’ defined but not used [-Wunused-variable]
mdaPianoVoice.cpp: In constructor ‘mdaPianoVoice::mdaPianoVoice(double, Sample*, KGRP*)’:
mdaPianoVoice.cpp:28:27: error: ‘p_hardness’ was not declared in this scope
mdaPianoVoice.cpp:29:27: error: ‘p_treble_boost’ was not declared in this scope
mdaPianoVoice.cpp:30:27: error: ‘p_modulation’ was not declared in this scope
mdaPianoVoice.cpp:31:27: error: ‘p_lfo_rate’ was not declared in this scope
mdaPianoVoice.cpp:36:27: error: ‘p_random_tuning’ was not declared in this scope
mdaPianoVoice.cpp:37:27: error: ‘p_overdrive’ was not declared in this scope
mdaPianoVoice.cpp: In member function ‘void mdaPianoVoice::update(Param)’:
mdaPianoVoice.cpp:285:34: error: ‘p_hardness’ was not declared in this scope
mdaPianoVoice.cpp:286:26: error: ‘p_treble_boost’ was not declared in this scope
mdaPianoVoice.cpp:296:26: error: ‘p_modulation’ was not declared in this scope
mdaPianoVoice.cpp:298:53: error: ‘p_lfo_rate’ was not declared in this scope
mdaPianoVoice.cpp:301:31: error: ‘p_overdrive’ was not declared in this scope
mdaPianoVoice.cpp:302:30: error: ‘p_random_tuning’ was not declared in this scope
make: *** [mdaEPiano.so] Error 1

get in contact - wavedrum

hey @rekado , how can I mail you?
sflbepAfmfqimz/ofu <= what can I do with this? O_O
probably you should mail me. use my nickname @gmail dot com. please use wavedrum as subject. thanks!

btw: please remove this post after you mailed me!

mdaEPiano.cpp:224: possible missing string terminator ?

mdaEPiano.cpp:224]: (error) Dangerous usage of 'filepath' (strncpy doesn't always null-terminate it).

strncpy(filepath, bundle_path(), STRING_BUF);
strncat(filepath,
sample_file,
STRING_BUF - strlen(filepath));

Suggest new code

strncpy(filepath, bundle_path(), STRING_BUF);
filepath[STRING_BUF - 1] = '\0';
strncat(filepath,
sample_file,
STRING_BUF - strlen(filepath));

Fix for a compilation error

I tried to compile lv2-mdaMetaPiano but met a gcc error because of the initialisation of "samples" in the header mdaPiano.h instead of the constructor in mdaPiano.cpp. So I had to move the following initialisation line out of the header :

Sample samples = (Sample) malloc (NSAMPLES * sizeof(Sample));

It might help someone else.

looping is noisy

For some sounds looping is not seamless. This is especially noticeable in the mdaPiano plugin. This could be somewhat improved by applying a cross-fade to the samples (as it is done in the mdaEPiano plugin), but this doesn't fully remove the "click" when looping.

The mdaEPiano has a similar looping-related defect. The samples for the lower keys and the lowest velocity have a very audible ring sound to them when they are looped. The loop segment is probably too short (or the sample has been tuned up too much).

git repo not available

Hi rekado,

I dont really know how to contact you for this

https://git.elephly.net/software/lv2-mdametapiano gives a error 504

is it gonna be up again ? I have an old version of mda/piano code but I would like to have the latest updates

thanks
Phil