reksford/tea-cozy-project

Codecademy Website Intensive Project 2

tea-cozy-project's Issues

HTML - Using Comments

I would recommend adding some comments to your HTML code. While this is a pretty small project and can be read fairly easily, adding comments is a good habit to get into, especially when you build larger projects. Comments are good to explain what blocks of code are doing and make it easier for others who read your code to understand it, as well as you if you come back to it in the future.

You can add comments to HTML with the following syntax:

<!-- This is an HTML comment -->

Summary - Meets Expectations

Overall, you did a good job with this. Your HTML and CSS were formatted well, making them a pleasure to read. You also choose appropriate elements for your HTML and nice, descriptive class names for your CSS. Good job using comments on the CSS. I would recommend going back and adding some comments to the HTML as well as fixing the styles on those elements that have hard-coded pixel widths. Other than that, great job. Keep it up!

Visuals

You did a good job on the visuals. Your version looks almost identical to the target version, so good job on that. There are a few elements that are supposed to be the full width of the screen, but don't go the full width. This is a result of the fact that you have a hard-coded pixel value set on the classes that are applied to these items. On both your location-text and mission-text classes you have the property:

flex: 0 1 1200px;

This needs to be changed to the following to achieve full width:

flex: 0 1 100%;

HTML

Your HTML is pretty good. The formatting is nice with clean indentation and spacing, making it easy to read. You also used the appropriate element tags for the type of content they were displaying, which is good to see. Additionally, you utilized alt attributes in the img elements well, which is important for screen readers. Good job!

CSS

Your CSS is done well. The spacing and indentation is clean and I like that you used comments to delineate section styles. Also, great job leveraging inheritance by applying styles to high level parent element selectors such as body. This keeps your code "DRY" and makes it easier to comprehend when reading it.