Giter Site home page Giter Site logo

Comments (9)

sullimander avatar sullimander commented on May 22, 2024 3

We would need the ability to set the release branch separate from the github default branch in order for us to use it.

from release-drafter.

StewartSnow avatar StewartSnow commented on May 22, 2024 1

Hey we have the same issue here - we follow gitflow and would prefer that all draft releases are created on the master branch, rather than default develop branch (as is common under gitflow).
An additional config entry to indicate the branch that the release / tag should be drafted on would be most helpful.

Screenshot 2019-05-15 at 13 42 23

Just to elaborate on the issue:

  • We follow GitFlow, and as such the default branch is develop (not master)
  • All feature / fix branches get merged into develop first
  • Develop then gets merged into master for release
  • We have "branches: master" which correctly ensures that release-drafter updates or creates the release notes on the merge into master...
  • However, the draft release it creates is still on develop (despite the master branch being indicated in the config)

from release-drafter.

jetersen avatar jetersen commented on May 22, 2024

Change your default branch to master?

Or perhaps we should provide a way to override the default branch.

from release-drafter.

thibmaek avatar thibmaek commented on May 22, 2024

That would mean all the PRs point at master by default and checking out the repo across team members starts from master. Kind of defeats the purposes of gitflow I think

from release-drafter.

TimonVS avatar TimonVS commented on May 22, 2024

Can you walk me through the issue you're having in a little more detail? I can see that you used the branches option in your config, why doesn't that give the desired result?

from release-drafter.

thibmaek avatar thibmaek commented on May 22, 2024

This is indeed the same problem I am encountering

from release-drafter.

rvanlaak avatar rvanlaak commented on May 22, 2024

In our gitflow-like scenario we have master setup as develop, and production as master. What we see happening, is that release drafter nicely creates drafts for master`.

A problem we have (that sounds similar to the issue description) happens in the following scenario:

1 - A release branch gets created, testing starts and could take several days
2 - PRs that in the meanwhile get merged in master (read: the gitflow develop) and do not make the release - as they are not in the release branch.
3 - The release branch gets merged in production (read: the gitflow master) and gets tagged.

The actual problem that happened in the meanwhile: the PRs that get merged in step 2 do not appear in the next release draft.

from release-drafter.

mkurz avatar mkurz commented on May 22, 2024

I think the problems you are facing can be solved with the filter-by-commitish config, I came up with this comment on how to change the target_commitish of a GitHub release: #656 (comment)

from release-drafter.

mkurz avatar mkurz commented on May 22, 2024

You also might be interested in #1061

from release-drafter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.